Uh oh!
There was an error while loading. Please reload this page.
build: merge multiple on download artifact - #64633
Merged
Merged
Conversation
nodejs-github-bot
commented
Jul 20, 2026
Collaborator
Review requested:
|
When there are multiple artifacts, `actions/download-artifact` creates subdirectories for each artifact, and results in incorrect folder structure assumptions in later steps. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecasforce-pushed
the
fix-download-artifacts
branch
from
July 20, 2026 20:02
f080c94 to
66ee8bfCompare
This was referenced Jul 20, 2026
Contributor
Fast-track has been requested by @avivkeller. Please 👍 to approve. |
avivkeller
approved these changes
Jul 20, 2026
avivkeller
left a comment
Member
There was a problem hiding this comment.
This is blocking CI in PRs, so I'm requesting fast track
lpinca
approved these changes
Jul 20, 2026
benjamingr
approved these changes
Jul 20, 2026
panva
approved these changes
Jul 21, 2026
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jul 21, 2026
Collaborator
Landed in 69e982f |
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
When there are multiple artifacts, `actions/download-artifact` creates subdirectories for each artifact, and results in incorrect folder structure assumptions in later steps. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64633Fixes: #64554 Refs: https://github.com/actions/download-artifact#download-all-artifacts Refs: https://github.com/nodejs/node/actions/runs/29768247349/job/88454933457?pr=64565#step:2:24 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
When there are multiple artifacts, `actions/download-artifact` creates subdirectories for each artifact, and results in incorrect folder structure assumptions in later steps. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64633Fixes: #64554 Refs: https://github.com/actions/download-artifact#download-all-artifacts Refs: https://github.com/nodejs/node/actions/runs/29768247349/job/88454933457?pr=64565#step:2:24 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Jul 21, 2026
When there are multiple artifacts, `actions/download-artifact` creates subdirectories for each artifact, and results in incorrect folder structure assumptions in later steps. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64633Fixes: #64554 Refs: https://github.com/actions/download-artifact#download-all-artifacts Refs: https://github.com/nodejs/node/actions/runs/29768247349/job/88454933457?pr=64565#step:2:24 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jul 29, 2026
When there are multiple artifacts, `actions/download-artifact` creates subdirectories for each artifact, and results in incorrect folder structure assumptions in later steps. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> PR-URL: #64633Fixes: #64554 Refs: https://github.com/actions/download-artifact#download-all-artifacts Refs: https://github.com/nodejs/node/actions/runs/29768247349/job/88454933457?pr=64565#step:2:24 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are multiple artifacts,
actions/download-artifactcreatessubdirectories for each artifact, and results in incorrect folder
structure assumptions in later steps.
Fixes: #64554
Refs: https://github.com/actions/download-artifact#download-all-artifacts
Refs: https://github.com/nodejs/node/actions/runs/29768247349/job/88454933457?pr=64565#step:2:24