fs: treat std::errc::permission_denied as EPERM error - #64698

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
JaneaSystems:win-rmsync-eperm-retry-test
Aug 20, 2026
Merged

fs: treat std::errc::permission_denied as EPERM error#64698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
JaneaSystems:win-rmsync-eperm-retry-test

Conversation

@PickBas

@PickBasPickBas commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

std::errc::permission_denied is already treated as an EPERM error when an exception is thrown, but it is not included among the omittable errors retried by the RmSync operation. This commit adds it.

This also fixes the retryDelay calculation on Windows where the retryDelay is divided by 1000 but the win32's Sleep function takes the argument as an ms unit, dividing the supplied ms unit further to a much smaller delay.

Fixes: #64016
Refs: #64017 - This PR adds a test for the referenced PR.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Jul 23, 2026
jasnell
jasnell reviewed Jul 23, 2026
View reviewed changes
Comment threadtest/parallel/test-fs-rmSync-eperm-retries.js Outdated
jasnell
jasnell reviewed Jul 23, 2026
View reviewed changes
Comment threadsrc/node_file.cc
@PickBas
PickBasforce-pushed the win-rmsync-eperm-retry-test branch from 092d380 to b5441d9CompareJuly 23, 2026 13:23
@PickBas
PickBasforce-pushed the win-rmsync-eperm-retry-test branch 2 times, most recently from 977185e to 7cf7983CompareJuly 23, 2026 13:39
@codecov

codecovBot commented Jul 23, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (ee64033) to head (abb551f).
⚠️ Report is 212 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64698 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01% 
==========================================
Files 759 759 Lines 247754 247754 Branches 46721 46718 -3 ==========================================
- Hits 223708 223694 -14 + Misses 15521 15518 -3 - Partials 8525 8542 +17
Files with missing linesCoverage Δ
src/node_file.cc74.15% <ø> (-0.12%)⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PickBas
PickBasforce-pushed the win-rmsync-eperm-retry-test branch from 7cf7983 to ab0dc83CompareJuly 24, 2026 08:40
@StefanStojanovicStefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2026
@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75246/

@StefanStojanovicStefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 3, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75419/

@StefanStojanovicStefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75474/

louiellanand others added 2 commits August 6, 2026 13:37
@louiellan@PickBas
fs: treat std::errc::permission_denied as EPERM error
8872ec3
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
@PickBas
test: add Windows EPERM retry test for rmSync
abb551f
Fixes: nodejs#64016
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@PickBas
PickBasforce-pushed the win-rmsync-eperm-retry-test branch from ab0dc83 to abb551fCompareAugust 6, 2026 11:37
@StefanStojanovicStefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@StefanStojanovic

StefanStojanovic commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@jasnell can you reapprove this? GH says Awaiting approval, although I reapproved after rebasing, so hopefully you doing it as well will unblock the CI run and landing it afterwards.

@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75928/

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@StefanStojanovicStefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75964/

@StefanStojanovicStefanStojanovic added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5a9fd82 into nodejs:mainAug 20, 2026
90 of 91 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Landed in 5a9fd82

@nodejs-github-botnodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
95a7530
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
2de845b
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
4730757
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@vegeta897vegeta897 mentioned this pull request Sep 1, 2026
Draft
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashPRs the Commit Queue should land as one squashed commit.fsIssues and PRs related to file-system APIs and the fs module.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent retryDelay in fs.rmSync and asynchronous fs.rm (on Windows)

5 participants

@PickBas@nodejs-github-bot@StefanStojanovic@jasnell@louiellan
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fs: treat std::errc::permission_denied as EPERM error - #64698
Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Aug 20, 2026
Merged
fs: treat std::errc::permission_denied as EPERM error#64698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Conversation
@PickBas
@PickBasPickBas
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
std::errc::permission_denied is already treated as an EPERM error when an exception is thrown, but it is not included among the omittable errors retried by the RmSync operation. This commit adds it.
This also fixes the retryDelay calculation on Windows where the retryDelay is divided by 1000 but the win32's Sleep function takes the argument as an ms unit, dividing the supplied ms unit further to a much smaller delay.
Fixes: #64016

Refs: #64017 - This PR adds a test for the referenced PR.
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to file-system APIs and the fs module.
needs-ci
PRs that need a full CI run.
labels
Jul 23, 2026
jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/parallel/test-fs-rmSync-eperm-retries.js
Outdated

jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node_file.cc
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
092d380 to
b5441d9CompareJuly 23, 2026 13:23
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
2 times, most recently
from
977185e to
7cf7983CompareJuly 23, 2026 13:39
@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.28%. Comparing base (ee64033) to head (abb551f).
⚠️ Report is 212 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64698 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01% 
==========================================
Files 759 759 Lines 247754 247754 Branches 46721 46718 -3 ==========================================
- Hits 223708 223694 -14 + Misses 15521 15518 -3 - Partials 8525 8542 +17 
Files with missing linesCoverage Δ
src/node_file.cc74.15% <ø> (-0.12%)⬇️
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
7cf7983 to
ab0dc83CompareJuly 24, 2026 08:40
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 27, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 28, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75246/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75419/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75474/
louiellanand others
added 2 commits
August 6, 2026 13:37
@louiellan@PickBas
fs: treat std::errc::permission_denied as EPERM error
8872ec3
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
@PickBas
test: add Windows EPERM retry test for rmSync
abb551f
Fixes: nodejs#64016
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
ab0dc83 to
abb551fCompareAugust 6, 2026 11:37
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@StefanStojanovic
StefanStojanovic
commented
Aug 17, 2026

Copy link


Copy Markdown

Contributor
@jasnell can you reapprove this? GH says Awaiting approval, although I reapproved after rebasing, so hopefully you doing it as well will unblock the CI run and landing it afterwards.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75928/
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 17, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75964/
@StefanStojanovicStefanStojanovic
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5a9fd82
into
nodejs:mainAug 20, 2026

90 of 91 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5a9fd82
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
95a7530
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
2de845b
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
4730757
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@vegeta897vegeta897
mentioned this pull request
Sep 1, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees


No one assigned


Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashPRs the Commit Queue should land as one squashed commit.fsIssues and PRs related to file-system APIs and the fs module.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent retryDelay in fs.rmSync and asynchronous fs.rm (on Windows)


5 participants

@PickBas@nodejs-github-bot@StefanStojanovic@jasnell@louiellan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fs: treat std::errc::permission_denied as EPERM error - #64698
Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Aug 20, 2026
Merged
fs: treat std::errc::permission_denied as EPERM error#64698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Conversation
@PickBas
@PickBasPickBas
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
std::errc::permission_denied is already treated as an EPERM error when an exception is thrown, but it is not included among the omittable errors retried by the RmSync operation. This commit adds it.
This also fixes the retryDelay calculation on Windows where the retryDelay is divided by 1000 but the win32's Sleep function takes the argument as an ms unit, dividing the supplied ms unit further to a much smaller delay.
Fixes: #64016

Refs: #64017 - This PR adds a test for the referenced PR.
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to file-system APIs and the fs module.
needs-ci
PRs that need a full CI run.
labels
Jul 23, 2026
jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/parallel/test-fs-rmSync-eperm-retries.js
Outdated

jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node_file.cc
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
092d380 to
b5441d9CompareJuly 23, 2026 13:23
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
2 times, most recently
from
977185e to
7cf7983CompareJuly 23, 2026 13:39
@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.28%. Comparing base (ee64033) to head (abb551f).
⚠️ Report is 212 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64698 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01% 
==========================================
Files 759 759 Lines 247754 247754 Branches 46721 46718 -3 ==========================================
- Hits 223708 223694 -14 + Misses 15521 15518 -3 - Partials 8525 8542 +17 
Files with missing linesCoverage Δ
src/node_file.cc74.15% <ø> (-0.12%)⬇️
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
7cf7983 to
ab0dc83CompareJuly 24, 2026 08:40
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 27, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 28, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75246/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75419/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75474/
louiellanand others
added 2 commits
August 6, 2026 13:37
@louiellan@PickBas
fs: treat std::errc::permission_denied as EPERM error
8872ec3
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
@PickBas
test: add Windows EPERM retry test for rmSync
abb551f
Fixes: nodejs#64016
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
ab0dc83 to
abb551fCompareAugust 6, 2026 11:37
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@StefanStojanovic
StefanStojanovic
commented
Aug 17, 2026

Copy link


Copy Markdown

Contributor
@jasnell can you reapprove this? GH says Awaiting approval, although I reapproved after rebasing, so hopefully you doing it as well will unblock the CI run and landing it afterwards.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75928/
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 17, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75964/
@StefanStojanovicStefanStojanovic
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5a9fd82
into
nodejs:mainAug 20, 2026

90 of 91 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5a9fd82
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
95a7530
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
2de845b
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
4730757
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@vegeta897vegeta897
mentioned this pull request
Sep 1, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees


No one assigned


Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashPRs the Commit Queue should land as one squashed commit.fsIssues and PRs related to file-system APIs and the fs module.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent retryDelay in fs.rmSync and asynchronous fs.rm (on Windows)


5 participants

@PickBas@nodejs-github-bot@StefanStojanovic@jasnell@louiellan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fs: treat std::errc::permission_denied as EPERM error - #64698
Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Aug 20, 2026
Merged
fs: treat std::errc::permission_denied as EPERM error#64698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Conversation
@PickBas
@PickBasPickBas
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
std::errc::permission_denied is already treated as an EPERM error when an exception is thrown, but it is not included among the omittable errors retried by the RmSync operation. This commit adds it.
This also fixes the retryDelay calculation on Windows where the retryDelay is divided by 1000 but the win32's Sleep function takes the argument as an ms unit, dividing the supplied ms unit further to a much smaller delay.
Fixes: #64016

Refs: #64017 - This PR adds a test for the referenced PR.
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to file-system APIs and the fs module.
needs-ci
PRs that need a full CI run.
labels
Jul 23, 2026
jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/parallel/test-fs-rmSync-eperm-retries.js
Outdated

jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node_file.cc
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
092d380 to
b5441d9CompareJuly 23, 2026 13:23
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
2 times, most recently
from
977185e to
7cf7983CompareJuly 23, 2026 13:39
@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.28%. Comparing base (ee64033) to head (abb551f).
⚠️ Report is 212 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64698 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01% 
==========================================
Files 759 759 Lines 247754 247754 Branches 46721 46718 -3 ==========================================
- Hits 223708 223694 -14 + Misses 15521 15518 -3 - Partials 8525 8542 +17 
Files with missing linesCoverage Δ
src/node_file.cc74.15% <ø> (-0.12%)⬇️
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
7cf7983 to
ab0dc83CompareJuly 24, 2026 08:40
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 27, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 28, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75246/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75419/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75474/
louiellanand others
added 2 commits
August 6, 2026 13:37
@louiellan@PickBas
fs: treat std::errc::permission_denied as EPERM error
8872ec3
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
@PickBas
test: add Windows EPERM retry test for rmSync
abb551f
Fixes: nodejs#64016
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
ab0dc83 to
abb551fCompareAugust 6, 2026 11:37
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@StefanStojanovic
StefanStojanovic
commented
Aug 17, 2026

Copy link


Copy Markdown

Contributor
@jasnell can you reapprove this? GH says Awaiting approval, although I reapproved after rebasing, so hopefully you doing it as well will unblock the CI run and landing it afterwards.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75928/
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 17, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75964/
@StefanStojanovicStefanStojanovic
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5a9fd82
into
nodejs:mainAug 20, 2026

90 of 91 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5a9fd82
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
95a7530
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
2de845b
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
4730757
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@vegeta897vegeta897
mentioned this pull request
Sep 1, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees


No one assigned


Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashPRs the Commit Queue should land as one squashed commit.fsIssues and PRs related to file-system APIs and the fs module.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent retryDelay in fs.rmSync and asynchronous fs.rm (on Windows)


5 participants

@PickBas@nodejs-github-bot@StefanStojanovic@jasnell@louiellan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fs: treat std::errc::permission_denied as EPERM error - #64698
Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Aug 20, 2026
Merged
fs: treat std::errc::permission_denied as EPERM error#64698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Conversation
@PickBas
@PickBasPickBas
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
std::errc::permission_denied is already treated as an EPERM error when an exception is thrown, but it is not included among the omittable errors retried by the RmSync operation. This commit adds it.
This also fixes the retryDelay calculation on Windows where the retryDelay is divided by 1000 but the win32's Sleep function takes the argument as an ms unit, dividing the supplied ms unit further to a much smaller delay.
Fixes: #64016

Refs: #64017 - This PR adds a test for the referenced PR.
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to file-system APIs and the fs module.
needs-ci
PRs that need a full CI run.
labels
Jul 23, 2026
jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/parallel/test-fs-rmSync-eperm-retries.js
Outdated

jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node_file.cc
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
092d380 to
b5441d9CompareJuly 23, 2026 13:23
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
2 times, most recently
from
977185e to
7cf7983CompareJuly 23, 2026 13:39
@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.28%. Comparing base (ee64033) to head (abb551f).
⚠️ Report is 212 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64698 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01% 
==========================================
Files 759 759 Lines 247754 247754 Branches 46721 46718 -3 ==========================================
- Hits 223708 223694 -14 + Misses 15521 15518 -3 - Partials 8525 8542 +17 
Files with missing linesCoverage Δ
src/node_file.cc74.15% <ø> (-0.12%)⬇️
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
7cf7983 to
ab0dc83CompareJuly 24, 2026 08:40
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 27, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 28, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75246/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75419/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75474/
louiellanand others
added 2 commits
August 6, 2026 13:37
@louiellan@PickBas
fs: treat std::errc::permission_denied as EPERM error
8872ec3
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
@PickBas
test: add Windows EPERM retry test for rmSync
abb551f
Fixes: nodejs#64016
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
ab0dc83 to
abb551fCompareAugust 6, 2026 11:37
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@StefanStojanovic
StefanStojanovic
commented
Aug 17, 2026

Copy link


Copy Markdown

Contributor
@jasnell can you reapprove this? GH says Awaiting approval, although I reapproved after rebasing, so hopefully you doing it as well will unblock the CI run and landing it afterwards.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75928/
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 17, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75964/
@StefanStojanovicStefanStojanovic
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5a9fd82
into
nodejs:mainAug 20, 2026

90 of 91 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5a9fd82
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
95a7530
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
2de845b
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
4730757
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@vegeta897vegeta897
mentioned this pull request
Sep 1, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees


No one assigned


Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashPRs the Commit Queue should land as one squashed commit.fsIssues and PRs related to file-system APIs and the fs module.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent retryDelay in fs.rmSync and asynchronous fs.rm (on Windows)


5 participants

@PickBas@nodejs-github-bot@StefanStojanovic@jasnell@louiellan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fs: treat std::errc::permission_denied as EPERM error - #64698
Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Aug 20, 2026
Merged
fs: treat std::errc::permission_denied as EPERM error#64698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Conversation
@PickBas
@PickBasPickBas
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
std::errc::permission_denied is already treated as an EPERM error when an exception is thrown, but it is not included among the omittable errors retried by the RmSync operation. This commit adds it.
This also fixes the retryDelay calculation on Windows where the retryDelay is divided by 1000 but the win32's Sleep function takes the argument as an ms unit, dividing the supplied ms unit further to a much smaller delay.
Fixes: #64016

Refs: #64017 - This PR adds a test for the referenced PR.
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to file-system APIs and the fs module.
needs-ci
PRs that need a full CI run.
labels
Jul 23, 2026
jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/parallel/test-fs-rmSync-eperm-retries.js
Outdated

jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node_file.cc
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
092d380 to
b5441d9CompareJuly 23, 2026 13:23
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
2 times, most recently
from
977185e to
7cf7983CompareJuly 23, 2026 13:39
@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.28%. Comparing base (ee64033) to head (abb551f).
⚠️ Report is 212 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64698 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01% 
==========================================
Files 759 759 Lines 247754 247754 Branches 46721 46718 -3 ==========================================
- Hits 223708 223694 -14 + Misses 15521 15518 -3 - Partials 8525 8542 +17 
Files with missing linesCoverage Δ
src/node_file.cc74.15% <ø> (-0.12%)⬇️
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
7cf7983 to
ab0dc83CompareJuly 24, 2026 08:40
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 27, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 28, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75246/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75419/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75474/
louiellanand others
added 2 commits
August 6, 2026 13:37
@louiellan@PickBas
fs: treat std::errc::permission_denied as EPERM error
8872ec3
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
@PickBas
test: add Windows EPERM retry test for rmSync
abb551f
Fixes: nodejs#64016
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
ab0dc83 to
abb551fCompareAugust 6, 2026 11:37
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@StefanStojanovic
StefanStojanovic
commented
Aug 17, 2026

Copy link


Copy Markdown

Contributor
@jasnell can you reapprove this? GH says Awaiting approval, although I reapproved after rebasing, so hopefully you doing it as well will unblock the CI run and landing it afterwards.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75928/
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 17, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75964/
@StefanStojanovicStefanStojanovic
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5a9fd82
into
nodejs:mainAug 20, 2026

90 of 91 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5a9fd82
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
95a7530
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
2de845b
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
4730757
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@vegeta897vegeta897
mentioned this pull request
Sep 1, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees


No one assigned


Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashPRs the Commit Queue should land as one squashed commit.fsIssues and PRs related to file-system APIs and the fs module.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent retryDelay in fs.rmSync and asynchronous fs.rm (on Windows)


5 participants

@PickBas@nodejs-github-bot@StefanStojanovic@jasnell@louiellan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fs: treat std::errc::permission_denied as EPERM error - #64698
Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Aug 20, 2026
Merged
fs: treat std::errc::permission_denied as EPERM error#64698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Conversation
@PickBas
@PickBasPickBas
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
std::errc::permission_denied is already treated as an EPERM error when an exception is thrown, but it is not included among the omittable errors retried by the RmSync operation. This commit adds it.
This also fixes the retryDelay calculation on Windows where the retryDelay is divided by 1000 but the win32's Sleep function takes the argument as an ms unit, dividing the supplied ms unit further to a much smaller delay.
Fixes: #64016

Refs: #64017 - This PR adds a test for the referenced PR.
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to file-system APIs and the fs module.
needs-ci
PRs that need a full CI run.
labels
Jul 23, 2026
jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/parallel/test-fs-rmSync-eperm-retries.js
Outdated

jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node_file.cc
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
092d380 to
b5441d9CompareJuly 23, 2026 13:23
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
2 times, most recently
from
977185e to
7cf7983CompareJuly 23, 2026 13:39
@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.28%. Comparing base (ee64033) to head (abb551f).
⚠️ Report is 212 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64698 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01% 
==========================================
Files 759 759 Lines 247754 247754 Branches 46721 46718 -3 ==========================================
- Hits 223708 223694 -14 + Misses 15521 15518 -3 - Partials 8525 8542 +17 
Files with missing linesCoverage Δ
src/node_file.cc74.15% <ø> (-0.12%)⬇️
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
7cf7983 to
ab0dc83CompareJuly 24, 2026 08:40
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 27, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 28, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75246/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75419/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75474/
louiellanand others
added 2 commits
August 6, 2026 13:37
@louiellan@PickBas
fs: treat std::errc::permission_denied as EPERM error
8872ec3
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
@PickBas
test: add Windows EPERM retry test for rmSync
abb551f
Fixes: nodejs#64016
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
ab0dc83 to
abb551fCompareAugust 6, 2026 11:37
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@StefanStojanovic
StefanStojanovic
commented
Aug 17, 2026

Copy link


Copy Markdown

Contributor
@jasnell can you reapprove this? GH says Awaiting approval, although I reapproved after rebasing, so hopefully you doing it as well will unblock the CI run and landing it afterwards.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75928/
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 17, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75964/
@StefanStojanovicStefanStojanovic
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5a9fd82
into
nodejs:mainAug 20, 2026

90 of 91 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5a9fd82
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
95a7530
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
2de845b
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
4730757
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@vegeta897vegeta897
mentioned this pull request
Sep 1, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees


No one assigned


Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashPRs the Commit Queue should land as one squashed commit.fsIssues and PRs related to file-system APIs and the fs module.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent retryDelay in fs.rmSync and asynchronous fs.rm (on Windows)


5 participants

@PickBas@nodejs-github-bot@StefanStojanovic@jasnell@louiellan

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fs: treat std::errc::permission_denied as EPERM error - #64698
Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Aug 20, 2026
Merged
fs: treat std::errc::permission_denied as EPERM error#64698
nodejs-github-bot merged 2 commits into
nodejs:mainfrom 
JaneaSystems:win-rmsync-eperm-retry-test
Conversation
@PickBas
@PickBasPickBas
commented
Jul 23, 2026

Copy link


Copy Markdown

Contributor
std::errc::permission_denied is already treated as an EPERM error when an exception is thrown, but it is not included among the omittable errors retried by the RmSync operation. This commit adds it.
This also fixes the retryDelay calculation on Windows where the retryDelay is divided by 1000 but the win32's Sleep function takes the argument as an ms unit, dividing the supplied ms unit further to a much smaller delay.
Fixes: #64016

Refs: #64017 - This PR adds a test for the referenced PR.
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
fs
Issues and PRs related to file-system APIs and the fs module.
needs-ci
PRs that need a full CI run.
labels
Jul 23, 2026
jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadtest/parallel/test-fs-rmSync-eperm-retries.js
Outdated

jasnell
jasnell
reviewed
Jul 23, 2026
View reviewed changes
Comment threadsrc/node_file.cc
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
092d380 to
b5441d9CompareJuly 23, 2026 13:23
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
2 times, most recently
from
977185e to
7cf7983CompareJuly 23, 2026 13:39
@codecov
codecovBot
commented
Jul 23, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.28%. Comparing base (ee64033) to head (abb551f).
⚠️ Report is 212 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64698 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.01% 
==========================================
Files 759 759 Lines 247754 247754 Branches 46721 46718 -3 ==========================================
- Hits 223708 223694 -14 + Misses 15521 15518 -3 - Partials 8525 8542 +17 
Files with missing linesCoverage Δ
src/node_file.cc74.15% <ø> (-0.12%)⬇️
... and 32 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
7cf7983 to
ab0dc83CompareJuly 24, 2026 08:40
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 27, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 28, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Jul 28, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75246/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 3, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 3, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75419/
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 4, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 4, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75474/
louiellanand others
added 2 commits
August 6, 2026 13:37
@louiellan@PickBas
fs: treat std::errc::permission_denied as EPERM error
8872ec3
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
@PickBas
test: add Windows EPERM retry test for rmSync
abb551f
Fixes: nodejs#64016
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@PickBas
PickBasforce-pushed
the
win-rmsync-eperm-retry-test
branch
from
ab0dc83 to
abb551fCompareAugust 6, 2026 11:37
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@StefanStojanovic
StefanStojanovic
commented
Aug 17, 2026

Copy link


Copy Markdown

Contributor
@jasnell can you reapprove this? GH says Awaiting approval, although I reapproved after rebasing, so hopefully you doing it as well will unblock the CI run and landing it afterwards.
@nodejs-github-bot
nodejs-github-bot
commented
Aug 17, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75928/
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 17, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@StefanStojanovicStefanStojanovic
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 18, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75964/
@StefanStojanovicStefanStojanovic
added

commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 18, 2026
@nodejs-github-bot
nodejs-github-bot
merged commit 5a9fd82
into
nodejs:mainAug 20, 2026

90 of 91 checks passed

@nodejs-github-bot
nodejs-github-bot
commented
Aug 20, 2026

Copy link


Copy Markdown

Collaborator
Landed in 5a9fd82
@nodejs-github-botnodejs-github-bot
removed
the 
commit-queue
PRs queued for automated landing through the Commit Queue.
label
Aug 20, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
95a7530
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
2de845b
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actionsgithub-actionsBot
mentioned this pull request
Aug 25, 2026
 Merged

aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@PickBas@aduh95
fs: treat std::errc::permission_denied as EPERM error
4730757
In the thrown exception, `std::errc::permission_denied` is already
treated as an `EPERM` error, but it is not included in one of the
omittable errors when retrying the `RmSync` operation. This commit
includes it.
This also fixes the `retryDelay` calculation on Windows where the
`retryDelay` is divided by `1000` but the win32's `Sleep` function
takes the argument as an `ms` unit, dividing the supplied `ms` unit
further to a much smaller delay.
Signed-off-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #64698Fixes: #64016
Refs: #64017
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@vegeta897vegeta897
mentioned this pull request
Sep 1, 2026
 Draft

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes

Assignees


No one assigned


Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashPRs the Commit Queue should land as one squashed commit.fsIssues and PRs related to file-system APIs and the fs module.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Inconsistent retryDelay in fs.rmSync and asynchronous fs.rm (on Windows)


5 participants

@PickBas@nodejs-github-bot@StefanStojanovic@jasnell@louiellan