permission: reuse cached env strings - #64912

Closed
agape1225 wants to merge 1 commit into
nodejs:mainfrom
agape1225:permission-use-cached-strings
Closed

permission: reuse cached env strings#64912
agape1225 wants to merge 1 commit into
nodejs:mainfrom
agape1225:permission-use-cached-strings

Conversation

@agape1225

@agape1225agape1225 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in
src/permission/permission.cc with the Environment-cached
permission_string()/resource_string() accessors already used
elsewhere in the same file. Follow-up to #59891, which didn't cover
this file.

@agape1225
permission: reuse cached env strings
615612e
Permission::is_scope_granted() and Permission::Drop() built the
"permission" and "resource" diagnostics message keys with
FIXED_ONE_BYTE_STRING(isolate, ...) on every publish, even though
Environment already caches these exact strings via
env->permission_string() and env->resource_string()
(src/env_properties.h). One call site in the same file already used
the cached accessor; these two did not, and Environment is already
in scope at both sites.
Assisted-by: Claude Sonnet 5
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
@nodejs-github-bot

nodejs-github-bot commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 1, 2026
@codecov

codecovBot commented Aug 1, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (b9dacd4) to head (615612e).
⚠️ Report is 179 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #64912 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.03% 
==========================================
Files 760 760 Lines 247061 247061 Branches 46585 46587 +2 ==========================================
- Hits 223092 223035 -57 - Misses 15451 15496 +45 - Partials 8518 8530 +12
Files with missing linesCoverage Δ
src/permission/permission.cc82.32% <100.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

leah-1ee added a commit to leah-1ee/node that referenced this pull request Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
90c4c8a
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1eeleah-1ee mentioned this pull request Aug 5, 2026
Merged
leah-1ee added a commit to leah-1ee/node that referenced this pull request Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
ae5c463
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@daeyeondaeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75589/

nodejs-github-bot pushed a commit that referenced this pull request Aug 8, 2026
@leah-1ee
src: reuse cached env strings in remaining files
721aad4
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75689/

@daeyeondaeyeon added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 10, 2026
@nodejs-github-botnodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64912
✔ Done loading data for nodejs/node/pull/64912
----------------------------------- PR info ------------------------------------
Title permission: reuse cached env strings (#64912)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch agape1225:permission-use-cached-strings -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue
Commits 1
- permission: reuse cached env strings
Committers 1
- agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 01 Aug 2026 13:16:38 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T11:58:23Z: https://ci.nodejs.org/job/node-test-pull-request/75689/
- Querying data for job/node-test-pull-request/75689/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
ad3432189c..4a4cc1ed24 main -> origin/main
✔ origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
- ff1744022d build: deprecate always enabled `--enable-static`
- 4a4cc1ed24 build: deprecate always enabled `--enable-static`
--------------------------------------------------------------------------------
HEAD is now at 4a4cc1ed24 build: deprecate always enabled `--enable-static`
✔ Reset to origin/main
- Downloading patch for 64912
From https://github.com/nodejs/node
* branch refs/pull/64912/merge -> FETCH_HEAD
✔ Fetched commits as 5f1ef0a95376..615612e04c54
--------------------------------------------------------------------------------
Auto-merging src/permission/permission.cc
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.
You are currently cherry-picking commit 615612e04c.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output
nothing added to commit but untracked files present (use "git add" to track)

✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31401397043

@aduh95

aduh95 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Superseded by 41afbd3

@aduh95aduh95 closed this Aug 10, 2026
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
b761755
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
262d88e
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
d7463b9
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees

No one assigned

Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@agape1225@nodejs-github-bot@aduh95@jasnell@daeyeon
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
permission: reuse cached env strings - #64912
Closed
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Closed
permission: reuse cached env strings#64912
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Conversation
@agape1225
@agape1225agape1225
commented
Aug 1, 2026

Copy link


Copy Markdown

Contributor
This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in
src/permission/permission.cc with the Environment-cached
permission_string()/resource_string() accessors already used

elsewhere in the same file. Follow-up to #59891, which didn't cover

this file.
@agape1225
permission: reuse cached env strings
615612e
Permission::is_scope_granted() and Permission::Drop() built the
"permission" and "resource" diagnostics message keys with
FIXED_ONE_BYTE_STRING(isolate, ...) on every publish, even though
Environment already caches these exact strings via
env->permission_string() and env->resource_string()
(src/env_properties.h). One call site in the same file already used
the cached accessor; these two did not, and Environment is already
in scope at both sites.
Assisted-by: Claude Sonnet 5
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Aug 1, 2026
@codecov
codecovBot
commented
Aug 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.27%. Comparing base (b9dacd4) to head (615612e).
⚠️ Report is 179 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64912 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.03% 
==========================================
Files 760 760 Lines 247061 247061 Branches 46585 46587 +2 ==========================================
- Hits 223092 223035 -57 - Misses 15451 15496 +45 - Partials 8518 8530 +12 
Files with missing linesCoverage Δ
src/permission/permission.cc82.32% <100.00%> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
90c4c8a
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1eeleah-1ee
mentioned this pull request
Aug 5, 2026
 Merged

leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
ae5c463
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@daeyeondaeyeon
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75589/
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@leah-1ee
src: reuse cached env strings in remaining files
721aad4
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75689/
@daeyeondaeyeon
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64912
✔ Done loading data for nodejs/node/pull/64912
----------------------------------- PR info ------------------------------------
Title permission: reuse cached env strings (#64912)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch agape1225:permission-use-cached-strings -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue
Commits 1
- permission: reuse cached env strings
Committers 1
- agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 01 Aug 2026 13:16:38 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T11:58:23Z: https://ci.nodejs.org/job/node-test-pull-request/75689/
- Querying data for job/node-test-pull-request/75689/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
ad3432189c..4a4cc1ed24 main -> origin/main
✔ origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
- ff1744022d build: deprecate always enabled `--enable-static`
- 4a4cc1ed24 build: deprecate always enabled `--enable-static`
--------------------------------------------------------------------------------
HEAD is now at 4a4cc1ed24 build: deprecate always enabled `--enable-static`
✔ Reset to origin/main
- Downloading patch for 64912
From https://github.com/nodejs/node
* branch refs/pull/64912/merge -> FETCH_HEAD
✔ Fetched commits as 5f1ef0a95376..615612e04c54
--------------------------------------------------------------------------------
Auto-merging src/permission/permission.cc
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.
You are currently cherry-picking commit 615612e04c.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output
nothing added to commit but untracked files present (use "git add" to track)

✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31401397043
@aduh95
aduh95
commented
Aug 10, 2026

Copy link


Copy Markdown

Contributor
Superseded by 41afbd3
@aduh95aduh95
closed this
Aug 10, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
b761755
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
262d88e
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
d7463b9
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@agape1225@nodejs-github-bot@aduh95@jasnell@daeyeon

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
permission: reuse cached env strings - #64912
Closed
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Closed
permission: reuse cached env strings#64912
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Conversation
@agape1225
@agape1225agape1225
commented
Aug 1, 2026

Copy link


Copy Markdown

Contributor
This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in
src/permission/permission.cc with the Environment-cached
permission_string()/resource_string() accessors already used

elsewhere in the same file. Follow-up to #59891, which didn't cover

this file.
@agape1225
permission: reuse cached env strings
615612e
Permission::is_scope_granted() and Permission::Drop() built the
"permission" and "resource" diagnostics message keys with
FIXED_ONE_BYTE_STRING(isolate, ...) on every publish, even though
Environment already caches these exact strings via
env->permission_string() and env->resource_string()
(src/env_properties.h). One call site in the same file already used
the cached accessor; these two did not, and Environment is already
in scope at both sites.
Assisted-by: Claude Sonnet 5
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Aug 1, 2026
@codecov
codecovBot
commented
Aug 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.27%. Comparing base (b9dacd4) to head (615612e).
⚠️ Report is 179 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64912 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.03% 
==========================================
Files 760 760 Lines 247061 247061 Branches 46585 46587 +2 ==========================================
- Hits 223092 223035 -57 - Misses 15451 15496 +45 - Partials 8518 8530 +12 
Files with missing linesCoverage Δ
src/permission/permission.cc82.32% <100.00%> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
90c4c8a
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1eeleah-1ee
mentioned this pull request
Aug 5, 2026
 Merged

leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
ae5c463
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@daeyeondaeyeon
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75589/
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@leah-1ee
src: reuse cached env strings in remaining files
721aad4
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75689/
@daeyeondaeyeon
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64912
✔ Done loading data for nodejs/node/pull/64912
----------------------------------- PR info ------------------------------------
Title permission: reuse cached env strings (#64912)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch agape1225:permission-use-cached-strings -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue
Commits 1
- permission: reuse cached env strings
Committers 1
- agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 01 Aug 2026 13:16:38 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T11:58:23Z: https://ci.nodejs.org/job/node-test-pull-request/75689/
- Querying data for job/node-test-pull-request/75689/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
ad3432189c..4a4cc1ed24 main -> origin/main
✔ origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
- ff1744022d build: deprecate always enabled `--enable-static`
- 4a4cc1ed24 build: deprecate always enabled `--enable-static`
--------------------------------------------------------------------------------
HEAD is now at 4a4cc1ed24 build: deprecate always enabled `--enable-static`
✔ Reset to origin/main
- Downloading patch for 64912
From https://github.com/nodejs/node
* branch refs/pull/64912/merge -> FETCH_HEAD
✔ Fetched commits as 5f1ef0a95376..615612e04c54
--------------------------------------------------------------------------------
Auto-merging src/permission/permission.cc
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.
You are currently cherry-picking commit 615612e04c.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output
nothing added to commit but untracked files present (use "git add" to track)

✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31401397043
@aduh95
aduh95
commented
Aug 10, 2026

Copy link


Copy Markdown

Contributor
Superseded by 41afbd3
@aduh95aduh95
closed this
Aug 10, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
b761755
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
262d88e
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
d7463b9
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@agape1225@nodejs-github-bot@aduh95@jasnell@daeyeon

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
permission: reuse cached env strings - #64912
Closed
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Closed
permission: reuse cached env strings#64912
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Conversation
@agape1225
@agape1225agape1225
commented
Aug 1, 2026

Copy link


Copy Markdown

Contributor
This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in
src/permission/permission.cc with the Environment-cached
permission_string()/resource_string() accessors already used

elsewhere in the same file. Follow-up to #59891, which didn't cover

this file.
@agape1225
permission: reuse cached env strings
615612e
Permission::is_scope_granted() and Permission::Drop() built the
"permission" and "resource" diagnostics message keys with
FIXED_ONE_BYTE_STRING(isolate, ...) on every publish, even though
Environment already caches these exact strings via
env->permission_string() and env->resource_string()
(src/env_properties.h). One call site in the same file already used
the cached accessor; these two did not, and Environment is already
in scope at both sites.
Assisted-by: Claude Sonnet 5
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Aug 1, 2026
@codecov
codecovBot
commented
Aug 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.27%. Comparing base (b9dacd4) to head (615612e).
⚠️ Report is 179 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64912 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.03% 
==========================================
Files 760 760 Lines 247061 247061 Branches 46585 46587 +2 ==========================================
- Hits 223092 223035 -57 - Misses 15451 15496 +45 - Partials 8518 8530 +12 
Files with missing linesCoverage Δ
src/permission/permission.cc82.32% <100.00%> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
90c4c8a
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1eeleah-1ee
mentioned this pull request
Aug 5, 2026
 Merged

leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
ae5c463
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@daeyeondaeyeon
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75589/
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@leah-1ee
src: reuse cached env strings in remaining files
721aad4
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75689/
@daeyeondaeyeon
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64912
✔ Done loading data for nodejs/node/pull/64912
----------------------------------- PR info ------------------------------------
Title permission: reuse cached env strings (#64912)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch agape1225:permission-use-cached-strings -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue
Commits 1
- permission: reuse cached env strings
Committers 1
- agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 01 Aug 2026 13:16:38 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T11:58:23Z: https://ci.nodejs.org/job/node-test-pull-request/75689/
- Querying data for job/node-test-pull-request/75689/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
ad3432189c..4a4cc1ed24 main -> origin/main
✔ origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
- ff1744022d build: deprecate always enabled `--enable-static`
- 4a4cc1ed24 build: deprecate always enabled `--enable-static`
--------------------------------------------------------------------------------
HEAD is now at 4a4cc1ed24 build: deprecate always enabled `--enable-static`
✔ Reset to origin/main
- Downloading patch for 64912
From https://github.com/nodejs/node
* branch refs/pull/64912/merge -> FETCH_HEAD
✔ Fetched commits as 5f1ef0a95376..615612e04c54
--------------------------------------------------------------------------------
Auto-merging src/permission/permission.cc
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.
You are currently cherry-picking commit 615612e04c.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output
nothing added to commit but untracked files present (use "git add" to track)

✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31401397043
@aduh95
aduh95
commented
Aug 10, 2026

Copy link


Copy Markdown

Contributor
Superseded by 41afbd3
@aduh95aduh95
closed this
Aug 10, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
b761755
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
262d88e
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
d7463b9
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@agape1225@nodejs-github-bot@aduh95@jasnell@daeyeon

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
permission: reuse cached env strings - #64912
Closed
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Closed
permission: reuse cached env strings#64912
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Conversation
@agape1225
@agape1225agape1225
commented
Aug 1, 2026

Copy link


Copy Markdown

Contributor
This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in
src/permission/permission.cc with the Environment-cached
permission_string()/resource_string() accessors already used

elsewhere in the same file. Follow-up to #59891, which didn't cover

this file.
@agape1225
permission: reuse cached env strings
615612e
Permission::is_scope_granted() and Permission::Drop() built the
"permission" and "resource" diagnostics message keys with
FIXED_ONE_BYTE_STRING(isolate, ...) on every publish, even though
Environment already caches these exact strings via
env->permission_string() and env->resource_string()
(src/env_properties.h). One call site in the same file already used
the cached accessor; these two did not, and Environment is already
in scope at both sites.
Assisted-by: Claude Sonnet 5
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Aug 1, 2026
@codecov
codecovBot
commented
Aug 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.27%. Comparing base (b9dacd4) to head (615612e).
⚠️ Report is 179 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64912 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.03% 
==========================================
Files 760 760 Lines 247061 247061 Branches 46585 46587 +2 ==========================================
- Hits 223092 223035 -57 - Misses 15451 15496 +45 - Partials 8518 8530 +12 
Files with missing linesCoverage Δ
src/permission/permission.cc82.32% <100.00%> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
90c4c8a
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1eeleah-1ee
mentioned this pull request
Aug 5, 2026
 Merged

leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
ae5c463
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@daeyeondaeyeon
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75589/
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@leah-1ee
src: reuse cached env strings in remaining files
721aad4
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75689/
@daeyeondaeyeon
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64912
✔ Done loading data for nodejs/node/pull/64912
----------------------------------- PR info ------------------------------------
Title permission: reuse cached env strings (#64912)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch agape1225:permission-use-cached-strings -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue
Commits 1
- permission: reuse cached env strings
Committers 1
- agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 01 Aug 2026 13:16:38 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T11:58:23Z: https://ci.nodejs.org/job/node-test-pull-request/75689/
- Querying data for job/node-test-pull-request/75689/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
ad3432189c..4a4cc1ed24 main -> origin/main
✔ origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
- ff1744022d build: deprecate always enabled `--enable-static`
- 4a4cc1ed24 build: deprecate always enabled `--enable-static`
--------------------------------------------------------------------------------
HEAD is now at 4a4cc1ed24 build: deprecate always enabled `--enable-static`
✔ Reset to origin/main
- Downloading patch for 64912
From https://github.com/nodejs/node
* branch refs/pull/64912/merge -> FETCH_HEAD
✔ Fetched commits as 5f1ef0a95376..615612e04c54
--------------------------------------------------------------------------------
Auto-merging src/permission/permission.cc
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.
You are currently cherry-picking commit 615612e04c.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output
nothing added to commit but untracked files present (use "git add" to track)

✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31401397043
@aduh95
aduh95
commented
Aug 10, 2026

Copy link


Copy Markdown

Contributor
Superseded by 41afbd3
@aduh95aduh95
closed this
Aug 10, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
b761755
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
262d88e
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
d7463b9
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@agape1225@nodejs-github-bot@aduh95@jasnell@daeyeon

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
permission: reuse cached env strings - #64912
Closed
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Closed
permission: reuse cached env strings#64912
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Conversation
@agape1225
@agape1225agape1225
commented
Aug 1, 2026

Copy link


Copy Markdown

Contributor
This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in
src/permission/permission.cc with the Environment-cached
permission_string()/resource_string() accessors already used

elsewhere in the same file. Follow-up to #59891, which didn't cover

this file.
@agape1225
permission: reuse cached env strings
615612e
Permission::is_scope_granted() and Permission::Drop() built the
"permission" and "resource" diagnostics message keys with
FIXED_ONE_BYTE_STRING(isolate, ...) on every publish, even though
Environment already caches these exact strings via
env->permission_string() and env->resource_string()
(src/env_properties.h). One call site in the same file already used
the cached accessor; these two did not, and Environment is already
in scope at both sites.
Assisted-by: Claude Sonnet 5
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Aug 1, 2026
@codecov
codecovBot
commented
Aug 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.27%. Comparing base (b9dacd4) to head (615612e).
⚠️ Report is 179 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64912 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.03% 
==========================================
Files 760 760 Lines 247061 247061 Branches 46585 46587 +2 ==========================================
- Hits 223092 223035 -57 - Misses 15451 15496 +45 - Partials 8518 8530 +12 
Files with missing linesCoverage Δ
src/permission/permission.cc82.32% <100.00%> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
90c4c8a
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1eeleah-1ee
mentioned this pull request
Aug 5, 2026
 Merged

leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
ae5c463
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@daeyeondaeyeon
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75589/
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@leah-1ee
src: reuse cached env strings in remaining files
721aad4
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75689/
@daeyeondaeyeon
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64912
✔ Done loading data for nodejs/node/pull/64912
----------------------------------- PR info ------------------------------------
Title permission: reuse cached env strings (#64912)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch agape1225:permission-use-cached-strings -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue
Commits 1
- permission: reuse cached env strings
Committers 1
- agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 01 Aug 2026 13:16:38 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T11:58:23Z: https://ci.nodejs.org/job/node-test-pull-request/75689/
- Querying data for job/node-test-pull-request/75689/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
ad3432189c..4a4cc1ed24 main -> origin/main
✔ origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
- ff1744022d build: deprecate always enabled `--enable-static`
- 4a4cc1ed24 build: deprecate always enabled `--enable-static`
--------------------------------------------------------------------------------
HEAD is now at 4a4cc1ed24 build: deprecate always enabled `--enable-static`
✔ Reset to origin/main
- Downloading patch for 64912
From https://github.com/nodejs/node
* branch refs/pull/64912/merge -> FETCH_HEAD
✔ Fetched commits as 5f1ef0a95376..615612e04c54
--------------------------------------------------------------------------------
Auto-merging src/permission/permission.cc
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.
You are currently cherry-picking commit 615612e04c.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output
nothing added to commit but untracked files present (use "git add" to track)

✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31401397043
@aduh95
aduh95
commented
Aug 10, 2026

Copy link


Copy Markdown

Contributor
Superseded by 41afbd3
@aduh95aduh95
closed this
Aug 10, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
b761755
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
262d88e
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
d7463b9
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@agape1225@nodejs-github-bot@aduh95@jasnell@daeyeon

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
permission: reuse cached env strings - #64912
Closed
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Closed
permission: reuse cached env strings#64912
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Conversation
@agape1225
@agape1225agape1225
commented
Aug 1, 2026

Copy link


Copy Markdown

Contributor
This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in
src/permission/permission.cc with the Environment-cached
permission_string()/resource_string() accessors already used

elsewhere in the same file. Follow-up to #59891, which didn't cover

this file.
@agape1225
permission: reuse cached env strings
615612e
Permission::is_scope_granted() and Permission::Drop() built the
"permission" and "resource" diagnostics message keys with
FIXED_ONE_BYTE_STRING(isolate, ...) on every publish, even though
Environment already caches these exact strings via
env->permission_string() and env->resource_string()
(src/env_properties.h). One call site in the same file already used
the cached accessor; these two did not, and Environment is already
in scope at both sites.
Assisted-by: Claude Sonnet 5
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Aug 1, 2026
@codecov
codecovBot
commented
Aug 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.27%. Comparing base (b9dacd4) to head (615612e).
⚠️ Report is 179 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64912 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.03% 
==========================================
Files 760 760 Lines 247061 247061 Branches 46585 46587 +2 ==========================================
- Hits 223092 223035 -57 - Misses 15451 15496 +45 - Partials 8518 8530 +12 
Files with missing linesCoverage Δ
src/permission/permission.cc82.32% <100.00%> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
90c4c8a
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1eeleah-1ee
mentioned this pull request
Aug 5, 2026
 Merged

leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
ae5c463
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@daeyeondaeyeon
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75589/
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@leah-1ee
src: reuse cached env strings in remaining files
721aad4
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75689/
@daeyeondaeyeon
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64912
✔ Done loading data for nodejs/node/pull/64912
----------------------------------- PR info ------------------------------------
Title permission: reuse cached env strings (#64912)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch agape1225:permission-use-cached-strings -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue
Commits 1
- permission: reuse cached env strings
Committers 1
- agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 01 Aug 2026 13:16:38 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T11:58:23Z: https://ci.nodejs.org/job/node-test-pull-request/75689/
- Querying data for job/node-test-pull-request/75689/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
ad3432189c..4a4cc1ed24 main -> origin/main
✔ origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
- ff1744022d build: deprecate always enabled `--enable-static`
- 4a4cc1ed24 build: deprecate always enabled `--enable-static`
--------------------------------------------------------------------------------
HEAD is now at 4a4cc1ed24 build: deprecate always enabled `--enable-static`
✔ Reset to origin/main
- Downloading patch for 64912
From https://github.com/nodejs/node
* branch refs/pull/64912/merge -> FETCH_HEAD
✔ Fetched commits as 5f1ef0a95376..615612e04c54
--------------------------------------------------------------------------------
Auto-merging src/permission/permission.cc
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.
You are currently cherry-picking commit 615612e04c.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output
nothing added to commit but untracked files present (use "git add" to track)

✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31401397043
@aduh95
aduh95
commented
Aug 10, 2026

Copy link


Copy Markdown

Contributor
Superseded by 41afbd3
@aduh95aduh95
closed this
Aug 10, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
b761755
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
262d88e
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
d7463b9
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@agape1225@nodejs-github-bot@aduh95@jasnell@daeyeon

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
permission: reuse cached env strings - #64912
Closed
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Closed
permission: reuse cached env strings#64912
agape1225 wants to merge 1 commit into
nodejs:mainfrom 
agape1225:permission-use-cached-strings
Conversation
@agape1225
@agape1225agape1225
commented
Aug 1, 2026

Copy link


Copy Markdown

Contributor
This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in
src/permission/permission.cc with the Environment-cached
permission_string()/resource_string() accessors already used

elsewhere in the same file. Follow-up to #59891, which didn't cover

this file.
@agape1225
permission: reuse cached env strings
615612e
Permission::is_scope_granted() and Permission::Drop() built the
"permission" and "resource" diagnostics message keys with
FIXED_ONE_BYTE_STRING(isolate, ...) on every publish, even though
Environment already caches these exact strings via
env->permission_string() and env->resource_string()
(src/env_properties.h). One call site in the same file already used
the cached accessor; these two did not, and Environment is already
in scope at both sites.
Assisted-by: Claude Sonnet 5
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 1, 2026

Copy link


Copy Markdown

Collaborator
Review requested:
  •  @nodejs/security-wg
@nodejs-github-botnodejs-github-bot
added

c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Aug 1, 2026
@codecov
codecovBot
commented
Aug 1, 2026•

edited

Loading

Copy link


Copy Markdown

Codecov Report
✅ All modified and coverable lines are covered by tests.

✅ Project coverage is 90.27%. Comparing base (b9dacd4) to head (615612e).
⚠️ Report is 179 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@## main #64912 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.03% 
==========================================
Files 760 760 Lines 247061 247061 Branches 46585 46587 +2 ==========================================
- Hits 223092 223035 -57 - Misses 15451 15496 +45 - Partials 8518 8530 +12 
Files with missing linesCoverage Δ
src/permission/permission.cc82.32% <100.00%> (ø)
... and 38 files with indirect coverage changes
 🚀 New features to boost your workflow: 
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
90c4c8a
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@leah-1eeleah-1ee
mentioned this pull request
Aug 5, 2026
 Merged

leah-1ee added a commit
to leah-1ee/node
that referenced
this pull request
Aug 5, 2026
@leah-1ee
src: reuse cached env strings in remaining files
ae5c463
Follow-up to nodejs#59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by nodejs#64760.
Refs: nodejs#59891
Refs: nodejs#64760
Refs: nodejs#64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
@daeyeondaeyeon
added
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@github-actionsgithub-actionsBot
removed
the 
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 6, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 6, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75589/
nodejs-github-bot pushed a commit
that referenced
this pull request
Aug 8, 2026
@leah-1ee
src: reuse cached env strings in remaining files
721aad4
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
nodejs-github-bot
commented
Aug 9, 2026

Copy link


Copy Markdown

Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/75689/
@daeyeondaeyeon
added

author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-botnodejs-github-bot
added

commit-queue-failed
PRs whose Commit Queue landing failed and need manual intervention before retrying.
and removed

commit-queue
PRs queued for automated landing through the Commit Queue.
labels
Aug 10, 2026
@nodejs-github-bot
nodejs-github-bot
commented
Aug 10, 2026

Copy link


Copy Markdown

Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64912
✔ Done loading data for nodejs/node/pull/64912
----------------------------------- PR info ------------------------------------
Title permission: reuse cached env strings (#64912)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch agape1225:permission-use-cached-strings -> nodejs:main
Labels c++, author ready, needs-ci, commit-queue
Commits 1
- permission: reuse cached env strings
Committers 1
- agape1225 <49804691+agape1225@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64912
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 01 Aug 2026 13:16:38 GMT
✔ Approvals: 2
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-09T11:58:23Z: https://ci.nodejs.org/job/node-test-pull-request/75689/
- Querying data for job/node-test-pull-request/75689/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
ad3432189c..4a4cc1ed24 main -> origin/main
✔ origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
- ff1744022d build: deprecate always enabled `--enable-static`
- 4a4cc1ed24 build: deprecate always enabled `--enable-static`
--------------------------------------------------------------------------------
HEAD is now at 4a4cc1ed24 build: deprecate always enabled `--enable-static`
✔ Reset to origin/main
- Downloading patch for 64912
From https://github.com/nodejs/node
* branch refs/pull/64912/merge -> FETCH_HEAD
✔ Fetched commits as 5f1ef0a95376..615612e04c54
--------------------------------------------------------------------------------
Auto-merging src/permission/permission.cc
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

On branch main

Your branch is up to date with 'origin/main'.
You are currently cherry-picking commit 615612e04c.

(all conflicts fixed: run "git cherry-pick --continue")

(use "git cherry-pick --skip" to skip this patch)

(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Untracked files:

(use "git add <file>..." to include in what will be committed)

labels.json

output
nothing added to commit but untracked files present (use "git add" to track)

✘ Failed to apply patches
https://github.com/nodejs/node/actions/runs/31401397043
@aduh95
aduh95
commented
Aug 10, 2026

Copy link


Copy Markdown

Contributor
Superseded by 41afbd3
@aduh95aduh95
closed this
Aug 10, 2026
aduh95 pushed a commit
that referenced
this pull request
Aug 13, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
b761755
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 25, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
262d88e
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit
that referenced
this pull request
Aug 27, 2026
@leah-1ee@aduh95
src: reuse cached env strings in remaining files
d7463b9
Follow-up to #59891, covering files it missed.
Overlapping locations (node_ffi.cc, crypto_util.cc) were already
handled by #64760.
Refs: #59891
Refs: #64760
Refs: #64912
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65039
Refs: #59891
Refs: #64760
Refs: #64912
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees


No one assigned


Labels

author readyPRs with CI started, the required approvals, and no outstanding review comments.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-failedPRs whose Commit Queue landing failed and need manual intervention before retrying.needs-ciPRs that need a full CI run.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@agape1225@nodejs-github-bot@aduh95@jasnell@daeyeon