quic: remove unused fin flag from blob reader wakeup by trivenay · Pull Request #65315 · nodejs/node

trivenay · 2026-08-15T23:36:44Z

Fixes the dead code identified in #64767.

The blob reader used by QUIC inbound streams has two separate channels. The pull channel is where the iterator asks for data and gets a real answer: a chunk, "blocked, nothing available yet", or "end of stream". The wakeup channel exists only to wake a parked iterator after a blocked pull so it pulls again — it carries no data and answers no question.

The wakeup additionally carried a boolean label saying whether it was triggered by end-of-stream. That label is dead information: whatever it says, the woken iterator does the same single thing — loop back and pull. If the stream has ended, that next pull returns end-of-stream by itself, because the receive queue was already capped when the FIN was processed. The pull channel is the source of truth for "am I done?"; the label was a second announcement of something the very next pull confirms anyway, and the branch consuming it (if (fin) continue; as the final statement of the loop) behaves identically to not existing.

This removes the label end to end while keeping the wakeup itself: the JS iterator no longer reads a value from the wakeup promise, the C++ notifier no longer constructs or passes the boolean, and the end-of-stream path still fires a (now unlabeled) wakeup. All actual FIN processing — recording the final size, capping the receive queue, the stream state flags — is untouched.

One consequence deserves reviewer attention. The notifier coalesces wakeups: once it has woken the iterator, further wakeups are suppressed until the iterator actually pulls. Previously, end-of-stream wakeups bypassed that suppression "just in case". With the label gone the bypass goes too, so end-of-stream wakeups now coalesce like any other. This cannot stall the iterator: the iterator only parks after a pull returned "blocked", every pull resets the suppression flag on entry, and only synchronous JavaScript runs between that pull and the park — so a parked iterator always has suppression clear, and the first wakeup after parking always gets through. The bypass only ever fired while the iterator was already awake and about to pull, where an extra wakeup changes nothing.

Changes:

lib/internal/blob.js — stop reading a value from the wakeup; delete the dead branch and its comment.
src/node_blob.cc, src/node_blob.h — NotifyPull() loses its boolean parameter and JS-facing argument.
src/quic/streams.cc — the end-of-stream call site drops the argument.

No behavior change; no new test. Existing test/parallel/test-quic-* and test/parallel/test-blob* pass on the compiled binary.

nodejs-github-bot · 2026-08-15T23:36:49Z

Review requested:

@nodejs/quic

jasnell · 2026-08-16T03:42:40Z

@trivenay ... this will need a rebase

trivenay · 2026-08-16T09:46:44Z

Rebased on main — thanks for the heads-up!

codecov · 2026-08-16T11:23:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (c5eb9de) to head (2ebf33d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_blob.cc	0.00%	3 Missing ⚠️
lib/internal/blob.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65315 +/- ##
==========================================
- Coverage 91.71% 90.06% -1.66% 
==========================================
Files 402 754 +352 Lines 181151 255731 +74580 Branches 27805 48323 +20518 ==========================================
+ Hits 166147 230317 +64170 - Misses 14664 16546 +1882 - Partials 340 8868 +8528

Files with missing lines	Coverage Δ
src/node_blob.h	`37.50% <ø> (ø)`
lib/internal/blob.js	`88.40% <0.00%> (+6.77%)`	⬆️
src/node_blob.cc	`73.49% <0.00%> (ø)`

... and 482 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivenay · 2026-08-16T11:27:35Z

The x86_64-darwin: with shared libraries failure is the test-common-wpt-backends — known flaky test, unrelated to this change. Thankfully there is already a fix in flight for it in #65320.

jasnell · 2026-08-16T14:19:23Z

Just a note, this will have a few conflicts with #65309 but nothing major.

trivenay · 2026-08-16T19:16:59Z

Sure — happy to rebase once #65309 lands.

trivenay · 2026-08-28T15:35:18Z

Rebased on top of #65309 now that it has landed (05a8e91). No conflicts; the fin removal re-applies cleanly on the reworked wakeup path.

pimterry

LGTM

nodejs-github-bot · 2026-08-29T13:06:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76694/

jasnell · 2026-08-29T16:47:43Z

The PR likely needs to be rebased in order for CI to pass.

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: nodejs#64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com>

nodejs-github-bot · 2026-08-29T22:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76713/

nodejs-github-bot · 2026-08-30T12:01:18Z

Landed in f63bffd

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: #64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65315 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

trivenay · 2026-08-15T23:36:44Z

Fixes the dead code identified in #64767.

The blob reader used by QUIC inbound streams has two separate channels. The pull channel is where the iterator asks for data and gets a real answer: a chunk, "blocked, nothing available yet", or "end of stream". The wakeup channel exists only to wake a parked iterator after a blocked pull so it pulls again — it carries no data and answers no question.

The wakeup additionally carried a boolean label saying whether it was triggered by end-of-stream. That label is dead information: whatever it says, the woken iterator does the same single thing — loop back and pull. If the stream has ended, that next pull returns end-of-stream by itself, because the receive queue was already capped when the FIN was processed. The pull channel is the source of truth for "am I done?"; the label was a second announcement of something the very next pull confirms anyway, and the branch consuming it (if (fin) continue; as the final statement of the loop) behaves identically to not existing.

This removes the label end to end while keeping the wakeup itself: the JS iterator no longer reads a value from the wakeup promise, the C++ notifier no longer constructs or passes the boolean, and the end-of-stream path still fires a (now unlabeled) wakeup. All actual FIN processing — recording the final size, capping the receive queue, the stream state flags — is untouched.

One consequence deserves reviewer attention. The notifier coalesces wakeups: once it has woken the iterator, further wakeups are suppressed until the iterator actually pulls. Previously, end-of-stream wakeups bypassed that suppression "just in case". With the label gone the bypass goes too, so end-of-stream wakeups now coalesce like any other. This cannot stall the iterator: the iterator only parks after a pull returned "blocked", every pull resets the suppression flag on entry, and only synchronous JavaScript runs between that pull and the park — so a parked iterator always has suppression clear, and the first wakeup after parking always gets through. The bypass only ever fired while the iterator was already awake and about to pull, where an extra wakeup changes nothing.

Changes:

lib/internal/blob.js — stop reading a value from the wakeup; delete the dead branch and its comment.
src/node_blob.cc, src/node_blob.h — NotifyPull() loses its boolean parameter and JS-facing argument.
src/quic/streams.cc — the end-of-stream call site drops the argument.

No behavior change; no new test. Existing test/parallel/test-quic-* and test/parallel/test-blob* pass on the compiled binary.

nodejs-github-bot · 2026-08-15T23:36:49Z

Review requested:

@nodejs/quic

jasnell · 2026-08-16T03:42:40Z

@trivenay ... this will need a rebase

trivenay · 2026-08-16T09:46:44Z

Rebased on main — thanks for the heads-up!

codecov · 2026-08-16T11:23:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (c5eb9de) to head (2ebf33d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_blob.cc	0.00%	3 Missing ⚠️
lib/internal/blob.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65315 +/- ##
==========================================
- Coverage 91.71% 90.06% -1.66% 
==========================================
Files 402 754 +352 Lines 181151 255731 +74580 Branches 27805 48323 +20518 ==========================================
+ Hits 166147 230317 +64170 - Misses 14664 16546 +1882 - Partials 340 8868 +8528

Files with missing lines	Coverage Δ
src/node_blob.h	`37.50% <ø> (ø)`
lib/internal/blob.js	`88.40% <0.00%> (+6.77%)`	⬆️
src/node_blob.cc	`73.49% <0.00%> (ø)`

... and 482 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivenay · 2026-08-16T11:27:35Z

The x86_64-darwin: with shared libraries failure is the test-common-wpt-backends — known flaky test, unrelated to this change. Thankfully there is already a fix in flight for it in #65320.

jasnell · 2026-08-16T14:19:23Z

Just a note, this will have a few conflicts with #65309 but nothing major.

trivenay · 2026-08-16T19:16:59Z

Sure — happy to rebase once #65309 lands.

trivenay · 2026-08-28T15:35:18Z

Rebased on top of #65309 now that it has landed (05a8e91). No conflicts; the fin removal re-applies cleanly on the reworked wakeup path.

pimterry

LGTM

nodejs-github-bot · 2026-08-29T13:06:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76694/

jasnell · 2026-08-29T16:47:43Z

The PR likely needs to be rebased in order for CI to pass.

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: nodejs#64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com>

nodejs-github-bot · 2026-08-29T22:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76713/

nodejs-github-bot · 2026-08-30T12:01:18Z

Landed in f63bffd

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: #64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65315 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

trivenay · 2026-08-15T23:36:44Z

Fixes the dead code identified in #64767.

The blob reader used by QUIC inbound streams has two separate channels. The pull channel is where the iterator asks for data and gets a real answer: a chunk, "blocked, nothing available yet", or "end of stream". The wakeup channel exists only to wake a parked iterator after a blocked pull so it pulls again — it carries no data and answers no question.

The wakeup additionally carried a boolean label saying whether it was triggered by end-of-stream. That label is dead information: whatever it says, the woken iterator does the same single thing — loop back and pull. If the stream has ended, that next pull returns end-of-stream by itself, because the receive queue was already capped when the FIN was processed. The pull channel is the source of truth for "am I done?"; the label was a second announcement of something the very next pull confirms anyway, and the branch consuming it (if (fin) continue; as the final statement of the loop) behaves identically to not existing.

This removes the label end to end while keeping the wakeup itself: the JS iterator no longer reads a value from the wakeup promise, the C++ notifier no longer constructs or passes the boolean, and the end-of-stream path still fires a (now unlabeled) wakeup. All actual FIN processing — recording the final size, capping the receive queue, the stream state flags — is untouched.

One consequence deserves reviewer attention. The notifier coalesces wakeups: once it has woken the iterator, further wakeups are suppressed until the iterator actually pulls. Previously, end-of-stream wakeups bypassed that suppression "just in case". With the label gone the bypass goes too, so end-of-stream wakeups now coalesce like any other. This cannot stall the iterator: the iterator only parks after a pull returned "blocked", every pull resets the suppression flag on entry, and only synchronous JavaScript runs between that pull and the park — so a parked iterator always has suppression clear, and the first wakeup after parking always gets through. The bypass only ever fired while the iterator was already awake and about to pull, where an extra wakeup changes nothing.

Changes:

lib/internal/blob.js — stop reading a value from the wakeup; delete the dead branch and its comment.
src/node_blob.cc, src/node_blob.h — NotifyPull() loses its boolean parameter and JS-facing argument.
src/quic/streams.cc — the end-of-stream call site drops the argument.

No behavior change; no new test. Existing test/parallel/test-quic-* and test/parallel/test-blob* pass on the compiled binary.

nodejs-github-bot · 2026-08-15T23:36:49Z

Review requested:

@nodejs/quic

jasnell · 2026-08-16T03:42:40Z

@trivenay ... this will need a rebase

trivenay · 2026-08-16T09:46:44Z

Rebased on main — thanks for the heads-up!

codecov · 2026-08-16T11:23:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (c5eb9de) to head (2ebf33d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_blob.cc	0.00%	3 Missing ⚠️
lib/internal/blob.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65315 +/- ##
==========================================
- Coverage 91.71% 90.06% -1.66% 
==========================================
Files 402 754 +352 Lines 181151 255731 +74580 Branches 27805 48323 +20518 ==========================================
+ Hits 166147 230317 +64170 - Misses 14664 16546 +1882 - Partials 340 8868 +8528

Files with missing lines	Coverage Δ
src/node_blob.h	`37.50% <ø> (ø)`
lib/internal/blob.js	`88.40% <0.00%> (+6.77%)`	⬆️
src/node_blob.cc	`73.49% <0.00%> (ø)`

... and 482 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivenay · 2026-08-16T11:27:35Z

The x86_64-darwin: with shared libraries failure is the test-common-wpt-backends — known flaky test, unrelated to this change. Thankfully there is already a fix in flight for it in #65320.

jasnell · 2026-08-16T14:19:23Z

Just a note, this will have a few conflicts with #65309 but nothing major.

trivenay · 2026-08-16T19:16:59Z

Sure — happy to rebase once #65309 lands.

trivenay · 2026-08-28T15:35:18Z

Rebased on top of #65309 now that it has landed (05a8e91). No conflicts; the fin removal re-applies cleanly on the reworked wakeup path.

pimterry

LGTM

nodejs-github-bot · 2026-08-29T13:06:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76694/

jasnell · 2026-08-29T16:47:43Z

The PR likely needs to be rebased in order for CI to pass.

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: nodejs#64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com>

nodejs-github-bot · 2026-08-29T22:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76713/

nodejs-github-bot · 2026-08-30T12:01:18Z

Landed in f63bffd

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: #64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65315 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

trivenay · 2026-08-15T23:36:44Z

Fixes the dead code identified in #64767.

The blob reader used by QUIC inbound streams has two separate channels. The pull channel is where the iterator asks for data and gets a real answer: a chunk, "blocked, nothing available yet", or "end of stream". The wakeup channel exists only to wake a parked iterator after a blocked pull so it pulls again — it carries no data and answers no question.

The wakeup additionally carried a boolean label saying whether it was triggered by end-of-stream. That label is dead information: whatever it says, the woken iterator does the same single thing — loop back and pull. If the stream has ended, that next pull returns end-of-stream by itself, because the receive queue was already capped when the FIN was processed. The pull channel is the source of truth for "am I done?"; the label was a second announcement of something the very next pull confirms anyway, and the branch consuming it (if (fin) continue; as the final statement of the loop) behaves identically to not existing.

This removes the label end to end while keeping the wakeup itself: the JS iterator no longer reads a value from the wakeup promise, the C++ notifier no longer constructs or passes the boolean, and the end-of-stream path still fires a (now unlabeled) wakeup. All actual FIN processing — recording the final size, capping the receive queue, the stream state flags — is untouched.

One consequence deserves reviewer attention. The notifier coalesces wakeups: once it has woken the iterator, further wakeups are suppressed until the iterator actually pulls. Previously, end-of-stream wakeups bypassed that suppression "just in case". With the label gone the bypass goes too, so end-of-stream wakeups now coalesce like any other. This cannot stall the iterator: the iterator only parks after a pull returned "blocked", every pull resets the suppression flag on entry, and only synchronous JavaScript runs between that pull and the park — so a parked iterator always has suppression clear, and the first wakeup after parking always gets through. The bypass only ever fired while the iterator was already awake and about to pull, where an extra wakeup changes nothing.

Changes:

lib/internal/blob.js — stop reading a value from the wakeup; delete the dead branch and its comment.
src/node_blob.cc, src/node_blob.h — NotifyPull() loses its boolean parameter and JS-facing argument.
src/quic/streams.cc — the end-of-stream call site drops the argument.

No behavior change; no new test. Existing test/parallel/test-quic-* and test/parallel/test-blob* pass on the compiled binary.

nodejs-github-bot · 2026-08-15T23:36:49Z

Review requested:

@nodejs/quic

jasnell · 2026-08-16T03:42:40Z

@trivenay ... this will need a rebase

trivenay · 2026-08-16T09:46:44Z

Rebased on main — thanks for the heads-up!

codecov · 2026-08-16T11:23:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (c5eb9de) to head (2ebf33d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_blob.cc	0.00%	3 Missing ⚠️
lib/internal/blob.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65315 +/- ##
==========================================
- Coverage 91.71% 90.06% -1.66% 
==========================================
Files 402 754 +352 Lines 181151 255731 +74580 Branches 27805 48323 +20518 ==========================================
+ Hits 166147 230317 +64170 - Misses 14664 16546 +1882 - Partials 340 8868 +8528

Files with missing lines	Coverage Δ
src/node_blob.h	`37.50% <ø> (ø)`
lib/internal/blob.js	`88.40% <0.00%> (+6.77%)`	⬆️
src/node_blob.cc	`73.49% <0.00%> (ø)`

... and 482 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivenay · 2026-08-16T11:27:35Z

The x86_64-darwin: with shared libraries failure is the test-common-wpt-backends — known flaky test, unrelated to this change. Thankfully there is already a fix in flight for it in #65320.

jasnell · 2026-08-16T14:19:23Z

Just a note, this will have a few conflicts with #65309 but nothing major.

trivenay · 2026-08-16T19:16:59Z

Sure — happy to rebase once #65309 lands.

trivenay · 2026-08-28T15:35:18Z

Rebased on top of #65309 now that it has landed (05a8e91). No conflicts; the fin removal re-applies cleanly on the reworked wakeup path.

pimterry

LGTM

nodejs-github-bot · 2026-08-29T13:06:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76694/

jasnell · 2026-08-29T16:47:43Z

The PR likely needs to be rebased in order for CI to pass.

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: nodejs#64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com>

nodejs-github-bot · 2026-08-29T22:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76713/

nodejs-github-bot · 2026-08-30T12:01:18Z

Landed in f63bffd

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: #64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65315 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

trivenay · 2026-08-15T23:36:44Z

Fixes the dead code identified in #64767.

The blob reader used by QUIC inbound streams has two separate channels. The pull channel is where the iterator asks for data and gets a real answer: a chunk, "blocked, nothing available yet", or "end of stream". The wakeup channel exists only to wake a parked iterator after a blocked pull so it pulls again — it carries no data and answers no question.

The wakeup additionally carried a boolean label saying whether it was triggered by end-of-stream. That label is dead information: whatever it says, the woken iterator does the same single thing — loop back and pull. If the stream has ended, that next pull returns end-of-stream by itself, because the receive queue was already capped when the FIN was processed. The pull channel is the source of truth for "am I done?"; the label was a second announcement of something the very next pull confirms anyway, and the branch consuming it (if (fin) continue; as the final statement of the loop) behaves identically to not existing.

This removes the label end to end while keeping the wakeup itself: the JS iterator no longer reads a value from the wakeup promise, the C++ notifier no longer constructs or passes the boolean, and the end-of-stream path still fires a (now unlabeled) wakeup. All actual FIN processing — recording the final size, capping the receive queue, the stream state flags — is untouched.

One consequence deserves reviewer attention. The notifier coalesces wakeups: once it has woken the iterator, further wakeups are suppressed until the iterator actually pulls. Previously, end-of-stream wakeups bypassed that suppression "just in case". With the label gone the bypass goes too, so end-of-stream wakeups now coalesce like any other. This cannot stall the iterator: the iterator only parks after a pull returned "blocked", every pull resets the suppression flag on entry, and only synchronous JavaScript runs between that pull and the park — so a parked iterator always has suppression clear, and the first wakeup after parking always gets through. The bypass only ever fired while the iterator was already awake and about to pull, where an extra wakeup changes nothing.

Changes:

lib/internal/blob.js — stop reading a value from the wakeup; delete the dead branch and its comment.
src/node_blob.cc, src/node_blob.h — NotifyPull() loses its boolean parameter and JS-facing argument.
src/quic/streams.cc — the end-of-stream call site drops the argument.

No behavior change; no new test. Existing test/parallel/test-quic-* and test/parallel/test-blob* pass on the compiled binary.

nodejs-github-bot · 2026-08-15T23:36:49Z

Review requested:

@nodejs/quic

jasnell · 2026-08-16T03:42:40Z

@trivenay ... this will need a rebase

trivenay · 2026-08-16T09:46:44Z

Rebased on main — thanks for the heads-up!

codecov · 2026-08-16T11:23:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (c5eb9de) to head (2ebf33d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_blob.cc	0.00%	3 Missing ⚠️
lib/internal/blob.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65315 +/- ##
==========================================
- Coverage 91.71% 90.06% -1.66% 
==========================================
Files 402 754 +352 Lines 181151 255731 +74580 Branches 27805 48323 +20518 ==========================================
+ Hits 166147 230317 +64170 - Misses 14664 16546 +1882 - Partials 340 8868 +8528

Files with missing lines	Coverage Δ
src/node_blob.h	`37.50% <ø> (ø)`
lib/internal/blob.js	`88.40% <0.00%> (+6.77%)`	⬆️
src/node_blob.cc	`73.49% <0.00%> (ø)`

... and 482 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivenay · 2026-08-16T11:27:35Z

The x86_64-darwin: with shared libraries failure is the test-common-wpt-backends — known flaky test, unrelated to this change. Thankfully there is already a fix in flight for it in #65320.

jasnell · 2026-08-16T14:19:23Z

Just a note, this will have a few conflicts with #65309 but nothing major.

trivenay · 2026-08-16T19:16:59Z

Sure — happy to rebase once #65309 lands.

trivenay · 2026-08-28T15:35:18Z

Rebased on top of #65309 now that it has landed (05a8e91). No conflicts; the fin removal re-applies cleanly on the reworked wakeup path.

pimterry

LGTM

nodejs-github-bot · 2026-08-29T13:06:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76694/

jasnell · 2026-08-29T16:47:43Z

The PR likely needs to be rebased in order for CI to pass.

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: nodejs#64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com>

nodejs-github-bot · 2026-08-29T22:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76713/

nodejs-github-bot · 2026-08-30T12:01:18Z

Landed in f63bffd

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: #64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65315 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

trivenay · 2026-08-15T23:36:44Z

Fixes the dead code identified in #64767.

The blob reader used by QUIC inbound streams has two separate channels. The pull channel is where the iterator asks for data and gets a real answer: a chunk, "blocked, nothing available yet", or "end of stream". The wakeup channel exists only to wake a parked iterator after a blocked pull so it pulls again — it carries no data and answers no question.

The wakeup additionally carried a boolean label saying whether it was triggered by end-of-stream. That label is dead information: whatever it says, the woken iterator does the same single thing — loop back and pull. If the stream has ended, that next pull returns end-of-stream by itself, because the receive queue was already capped when the FIN was processed. The pull channel is the source of truth for "am I done?"; the label was a second announcement of something the very next pull confirms anyway, and the branch consuming it (if (fin) continue; as the final statement of the loop) behaves identically to not existing.

This removes the label end to end while keeping the wakeup itself: the JS iterator no longer reads a value from the wakeup promise, the C++ notifier no longer constructs or passes the boolean, and the end-of-stream path still fires a (now unlabeled) wakeup. All actual FIN processing — recording the final size, capping the receive queue, the stream state flags — is untouched.

One consequence deserves reviewer attention. The notifier coalesces wakeups: once it has woken the iterator, further wakeups are suppressed until the iterator actually pulls. Previously, end-of-stream wakeups bypassed that suppression "just in case". With the label gone the bypass goes too, so end-of-stream wakeups now coalesce like any other. This cannot stall the iterator: the iterator only parks after a pull returned "blocked", every pull resets the suppression flag on entry, and only synchronous JavaScript runs between that pull and the park — so a parked iterator always has suppression clear, and the first wakeup after parking always gets through. The bypass only ever fired while the iterator was already awake and about to pull, where an extra wakeup changes nothing.

Changes:

lib/internal/blob.js — stop reading a value from the wakeup; delete the dead branch and its comment.
src/node_blob.cc, src/node_blob.h — NotifyPull() loses its boolean parameter and JS-facing argument.
src/quic/streams.cc — the end-of-stream call site drops the argument.

No behavior change; no new test. Existing test/parallel/test-quic-* and test/parallel/test-blob* pass on the compiled binary.

nodejs-github-bot · 2026-08-15T23:36:49Z

Review requested:

@nodejs/quic

jasnell · 2026-08-16T03:42:40Z

@trivenay ... this will need a rebase

trivenay · 2026-08-16T09:46:44Z

Rebased on main — thanks for the heads-up!

codecov · 2026-08-16T11:23:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (c5eb9de) to head (2ebf33d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_blob.cc	0.00%	3 Missing ⚠️
lib/internal/blob.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65315 +/- ##
==========================================
- Coverage 91.71% 90.06% -1.66% 
==========================================
Files 402 754 +352 Lines 181151 255731 +74580 Branches 27805 48323 +20518 ==========================================
+ Hits 166147 230317 +64170 - Misses 14664 16546 +1882 - Partials 340 8868 +8528

Files with missing lines	Coverage Δ
src/node_blob.h	`37.50% <ø> (ø)`
lib/internal/blob.js	`88.40% <0.00%> (+6.77%)`	⬆️
src/node_blob.cc	`73.49% <0.00%> (ø)`

... and 482 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivenay · 2026-08-16T11:27:35Z

The x86_64-darwin: with shared libraries failure is the test-common-wpt-backends — known flaky test, unrelated to this change. Thankfully there is already a fix in flight for it in #65320.

jasnell · 2026-08-16T14:19:23Z

Just a note, this will have a few conflicts with #65309 but nothing major.

trivenay · 2026-08-16T19:16:59Z

Sure — happy to rebase once #65309 lands.

trivenay · 2026-08-28T15:35:18Z

Rebased on top of #65309 now that it has landed (05a8e91). No conflicts; the fin removal re-applies cleanly on the reworked wakeup path.

pimterry

LGTM

nodejs-github-bot · 2026-08-29T13:06:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76694/

jasnell · 2026-08-29T16:47:43Z

The PR likely needs to be rebased in order for CI to pass.

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: nodejs#64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com>

nodejs-github-bot · 2026-08-29T22:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76713/

nodejs-github-bot · 2026-08-30T12:01:18Z

Landed in f63bffd

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: #64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65315 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

trivenay · 2026-08-15T23:36:44Z

Fixes the dead code identified in #64767.

The blob reader used by QUIC inbound streams has two separate channels. The pull channel is where the iterator asks for data and gets a real answer: a chunk, "blocked, nothing available yet", or "end of stream". The wakeup channel exists only to wake a parked iterator after a blocked pull so it pulls again — it carries no data and answers no question.

The wakeup additionally carried a boolean label saying whether it was triggered by end-of-stream. That label is dead information: whatever it says, the woken iterator does the same single thing — loop back and pull. If the stream has ended, that next pull returns end-of-stream by itself, because the receive queue was already capped when the FIN was processed. The pull channel is the source of truth for "am I done?"; the label was a second announcement of something the very next pull confirms anyway, and the branch consuming it (if (fin) continue; as the final statement of the loop) behaves identically to not existing.

This removes the label end to end while keeping the wakeup itself: the JS iterator no longer reads a value from the wakeup promise, the C++ notifier no longer constructs or passes the boolean, and the end-of-stream path still fires a (now unlabeled) wakeup. All actual FIN processing — recording the final size, capping the receive queue, the stream state flags — is untouched.

One consequence deserves reviewer attention. The notifier coalesces wakeups: once it has woken the iterator, further wakeups are suppressed until the iterator actually pulls. Previously, end-of-stream wakeups bypassed that suppression "just in case". With the label gone the bypass goes too, so end-of-stream wakeups now coalesce like any other. This cannot stall the iterator: the iterator only parks after a pull returned "blocked", every pull resets the suppression flag on entry, and only synchronous JavaScript runs between that pull and the park — so a parked iterator always has suppression clear, and the first wakeup after parking always gets through. The bypass only ever fired while the iterator was already awake and about to pull, where an extra wakeup changes nothing.

Changes:

lib/internal/blob.js — stop reading a value from the wakeup; delete the dead branch and its comment.
src/node_blob.cc, src/node_blob.h — NotifyPull() loses its boolean parameter and JS-facing argument.
src/quic/streams.cc — the end-of-stream call site drops the argument.

No behavior change; no new test. Existing test/parallel/test-quic-* and test/parallel/test-blob* pass on the compiled binary.

nodejs-github-bot · 2026-08-15T23:36:49Z

Review requested:

@nodejs/quic

jasnell · 2026-08-16T03:42:40Z

@trivenay ... this will need a rebase

trivenay · 2026-08-16T09:46:44Z

Rebased on main — thanks for the heads-up!

codecov · 2026-08-16T11:23:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (c5eb9de) to head (2ebf33d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_blob.cc	0.00%	3 Missing ⚠️
lib/internal/blob.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65315 +/- ##
==========================================
- Coverage 91.71% 90.06% -1.66% 
==========================================
Files 402 754 +352 Lines 181151 255731 +74580 Branches 27805 48323 +20518 ==========================================
+ Hits 166147 230317 +64170 - Misses 14664 16546 +1882 - Partials 340 8868 +8528

Files with missing lines	Coverage Δ
src/node_blob.h	`37.50% <ø> (ø)`
lib/internal/blob.js	`88.40% <0.00%> (+6.77%)`	⬆️
src/node_blob.cc	`73.49% <0.00%> (ø)`

... and 482 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivenay · 2026-08-16T11:27:35Z

The x86_64-darwin: with shared libraries failure is the test-common-wpt-backends — known flaky test, unrelated to this change. Thankfully there is already a fix in flight for it in #65320.

jasnell · 2026-08-16T14:19:23Z

Just a note, this will have a few conflicts with #65309 but nothing major.

trivenay · 2026-08-16T19:16:59Z

Sure — happy to rebase once #65309 lands.

trivenay · 2026-08-28T15:35:18Z

Rebased on top of #65309 now that it has landed (05a8e91). No conflicts; the fin removal re-applies cleanly on the reworked wakeup path.

pimterry

LGTM

nodejs-github-bot · 2026-08-29T13:06:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76694/

jasnell · 2026-08-29T16:47:43Z

The PR likely needs to be rebased in order for CI to pass.

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: nodejs#64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com>

nodejs-github-bot · 2026-08-29T22:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76713/

nodejs-github-bot · 2026-08-30T12:01:18Z

Landed in f63bffd

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: #64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65315 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

trivenay · 2026-08-15T23:36:44Z

Fixes the dead code identified in #64767.

The blob reader used by QUIC inbound streams has two separate channels. The pull channel is where the iterator asks for data and gets a real answer: a chunk, "blocked, nothing available yet", or "end of stream". The wakeup channel exists only to wake a parked iterator after a blocked pull so it pulls again — it carries no data and answers no question.

The wakeup additionally carried a boolean label saying whether it was triggered by end-of-stream. That label is dead information: whatever it says, the woken iterator does the same single thing — loop back and pull. If the stream has ended, that next pull returns end-of-stream by itself, because the receive queue was already capped when the FIN was processed. The pull channel is the source of truth for "am I done?"; the label was a second announcement of something the very next pull confirms anyway, and the branch consuming it (if (fin) continue; as the final statement of the loop) behaves identically to not existing.

This removes the label end to end while keeping the wakeup itself: the JS iterator no longer reads a value from the wakeup promise, the C++ notifier no longer constructs or passes the boolean, and the end-of-stream path still fires a (now unlabeled) wakeup. All actual FIN processing — recording the final size, capping the receive queue, the stream state flags — is untouched.

One consequence deserves reviewer attention. The notifier coalesces wakeups: once it has woken the iterator, further wakeups are suppressed until the iterator actually pulls. Previously, end-of-stream wakeups bypassed that suppression "just in case". With the label gone the bypass goes too, so end-of-stream wakeups now coalesce like any other. This cannot stall the iterator: the iterator only parks after a pull returned "blocked", every pull resets the suppression flag on entry, and only synchronous JavaScript runs between that pull and the park — so a parked iterator always has suppression clear, and the first wakeup after parking always gets through. The bypass only ever fired while the iterator was already awake and about to pull, where an extra wakeup changes nothing.

Changes:

lib/internal/blob.js — stop reading a value from the wakeup; delete the dead branch and its comment.
src/node_blob.cc, src/node_blob.h — NotifyPull() loses its boolean parameter and JS-facing argument.
src/quic/streams.cc — the end-of-stream call site drops the argument.

No behavior change; no new test. Existing test/parallel/test-quic-* and test/parallel/test-blob* pass on the compiled binary.

nodejs-github-bot · 2026-08-15T23:36:49Z

Review requested:

@nodejs/quic

jasnell · 2026-08-16T03:42:40Z

@trivenay ... this will need a rebase

trivenay · 2026-08-16T09:46:44Z

Rebased on main — thanks for the heads-up!

codecov · 2026-08-16T11:23:17Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (c5eb9de) to head (2ebf33d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_blob.cc	0.00%	3 Missing ⚠️
lib/internal/blob.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65315 +/- ##
==========================================
- Coverage 91.71% 90.06% -1.66% 
==========================================
Files 402 754 +352 Lines 181151 255731 +74580 Branches 27805 48323 +20518 ==========================================
+ Hits 166147 230317 +64170 - Misses 14664 16546 +1882 - Partials 340 8868 +8528

Files with missing lines	Coverage Δ
src/node_blob.h	`37.50% <ø> (ø)`
lib/internal/blob.js	`88.40% <0.00%> (+6.77%)`	⬆️
src/node_blob.cc	`73.49% <0.00%> (ø)`

... and 482 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivenay · 2026-08-16T11:27:35Z

The x86_64-darwin: with shared libraries failure is the test-common-wpt-backends — known flaky test, unrelated to this change. Thankfully there is already a fix in flight for it in #65320.

jasnell · 2026-08-16T14:19:23Z

Just a note, this will have a few conflicts with #65309 but nothing major.

trivenay · 2026-08-16T19:16:59Z

Sure — happy to rebase once #65309 lands.

trivenay · 2026-08-28T15:35:18Z

Rebased on top of #65309 now that it has landed (05a8e91). No conflicts; the fin removal re-applies cleanly on the reworked wakeup path.

pimterry

LGTM

nodejs-github-bot · 2026-08-29T13:06:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76694/

jasnell · 2026-08-29T16:47:43Z

The PR likely needs to be rebased in order for CI to pass.

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: nodejs#64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com>

nodejs-github-bot · 2026-08-29T22:57:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76713/

nodejs-github-bot · 2026-08-30T12:01:18Z

Landed in f63bffd

The fin argument threaded from Blob::Reader::NotifyPull to the JS blob reader iterator was dead: the only consumer, `if (fin) continue;`, was the last statement in the loop and behaved identically to falling through. End-of-stream is always discovered by the subsequent pull returning EOS, never via the wakeup label. Remove the flag from the JS iterator, NotifyPull's signature/argv, and the EndReadable call site. The `!fin` coalescing bypass collapses safely because a parked reader always has pull_pending_ == false, so the first wakeup after parking always fires. Refs: #64767 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65315 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 15, 2026

trivenay mentioned this pull request Aug 15, 2026
quic/blob: dead code for fin? #64767
Open

trivenay force-pushed the quic-blob-remove-dead-fin branch from 9a01ab0 to 9cbb5e4Compare August 16, 2026 09:46

trivenay force-pushed the quic-blob-remove-dead-fin branch from 9cbb5e4 to ebbaec7Compare August 28, 2026 15:35

pimterry approved these changes Aug 28, 2026
View reviewed changes

pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2026

This comment was marked as outdated.
Sign in to view

jasnell approved these changes Aug 29, 2026
View reviewed changes

trivenay force-pushed the quic-blob-remove-dead-fin branch from ebbaec7 to 2ebf33dCompare August 29, 2026 18:47

trivikr approved these changes Aug 29, 2026
View reviewed changes

trivikr added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 29, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2026

bjohansebas approved these changes Aug 29, 2026
View reviewed changes

trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 30, 2026

nodejs-github-bot merged commit f63bffd into nodejs:mainAug 30, 2026
77 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 30, 2026