test: keep WPT backend checks alive by panva · Pull Request #65320 · nodejs/node

panva · 2026-08-16T06:12:18Z

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

codecov · 2026-08-16T07:47:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65320 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 251569 251569 Branches 47264 47273 +9 ==========================================
- Hits 226724 226712 -12 - Misses 16188 16213 +25 + Partials 8657 8644 -13

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

panva · 2026-08-16T08:48:34Z

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

nodejs-github-bot · 2026-08-16T10:53:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75882/

Hardanish-Singh · 2026-08-17T16:53:48Z

+ );
+ try {
+ await handle.finished;
+ } finally {


[nit]: we should add a catch block here as well

nodejs-github-bot · 2026-08-18T06:20:54Z

Landed in 1c9baec

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

panva · 2026-08-16T06:12:18Z

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

codecov · 2026-08-16T07:47:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65320 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 251569 251569 Branches 47264 47273 +9 ==========================================
- Hits 226724 226712 -12 - Misses 16188 16213 +25 + Partials 8657 8644 -13

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

panva · 2026-08-16T08:48:34Z

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

nodejs-github-bot · 2026-08-16T10:53:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75882/

Hardanish-Singh · 2026-08-17T16:53:48Z

+ );
+ try {
+ await handle.finished;
+ } finally {


[nit]: we should add a catch block here as well

nodejs-github-bot · 2026-08-18T06:20:54Z

Landed in 1c9baec

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

panva · 2026-08-16T06:12:18Z

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

codecov · 2026-08-16T07:47:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65320 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 251569 251569 Branches 47264 47273 +9 ==========================================
- Hits 226724 226712 -12 - Misses 16188 16213 +25 + Partials 8657 8644 -13

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

panva · 2026-08-16T08:48:34Z

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

nodejs-github-bot · 2026-08-16T10:53:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75882/

Hardanish-Singh · 2026-08-17T16:53:48Z

+ );
+ try {
+ await handle.finished;
+ } finally {


[nit]: we should add a catch block here as well

nodejs-github-bot · 2026-08-18T06:20:54Z

Landed in 1c9baec

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

panva · 2026-08-16T06:12:18Z

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

codecov · 2026-08-16T07:47:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65320 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 251569 251569 Branches 47264 47273 +9 ==========================================
- Hits 226724 226712 -12 - Misses 16188 16213 +25 + Partials 8657 8644 -13

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

panva · 2026-08-16T08:48:34Z

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

nodejs-github-bot · 2026-08-16T10:53:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75882/

Hardanish-Singh · 2026-08-17T16:53:48Z

+ );
+ try {
+ await handle.finished;
+ } finally {


[nit]: we should add a catch block here as well

nodejs-github-bot · 2026-08-18T06:20:54Z

Landed in 1c9baec

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

panva · 2026-08-16T06:12:18Z

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

codecov · 2026-08-16T07:47:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65320 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 251569 251569 Branches 47264 47273 +9 ==========================================
- Hits 226724 226712 -12 - Misses 16188 16213 +25 + Partials 8657 8644 -13

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

panva · 2026-08-16T08:48:34Z

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

nodejs-github-bot · 2026-08-16T10:53:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75882/

Hardanish-Singh · 2026-08-17T16:53:48Z

+ );
+ try {
+ await handle.finished;
+ } finally {


[nit]: we should add a catch block here as well

nodejs-github-bot · 2026-08-18T06:20:54Z

Landed in 1c9baec

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

panva · 2026-08-16T06:12:18Z

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

codecov · 2026-08-16T07:47:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65320 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 251569 251569 Branches 47264 47273 +9 ==========================================
- Hits 226724 226712 -12 - Misses 16188 16213 +25 + Partials 8657 8644 -13

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

panva · 2026-08-16T08:48:34Z

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

nodejs-github-bot · 2026-08-16T10:53:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75882/

Hardanish-Singh · 2026-08-17T16:53:48Z

+ );
+ try {
+ await handle.finished;
+ } finally {


[nit]: we should add a catch block here as well

nodejs-github-bot · 2026-08-18T06:20:54Z

Landed in 1c9baec

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

panva · 2026-08-16T06:12:18Z

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

codecov · 2026-08-16T07:47:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65320 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 251569 251569 Branches 47264 47273 +9 ==========================================
- Hits 226724 226712 -12 - Misses 16188 16213 +25 + Partials 8657 8644 -13

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

panva · 2026-08-16T08:48:34Z

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

nodejs-github-bot · 2026-08-16T10:53:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75882/

Hardanish-Singh · 2026-08-17T16:53:48Z

+ );
+ try {
+ await handle.finished;
+ } finally {


[nit]: we should add a catch block here as well

nodejs-github-bot · 2026-08-18T06:20:54Z

Landed in 1c9baec

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

panva · 2026-08-16T06:12:18Z

Deflakes parallel/test-common-wpt-backends.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>

codecov · 2026-08-16T07:47:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (d099639) to head (573b75e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65320 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.01% 
==========================================
Files 752 752 Lines 251569 251569 Branches 47264 47273 +9 ==========================================
- Hits 226724 226712 -12 - Misses 16188 16213 +25 + Partials 8657 8644 -13

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

panva · 2026-08-16T08:48:34Z

This is not ideal, feeling the need to add a setTimeout is quite smelly, but is certainly OK as a temporary solution

Yeah the test runner's natural timeout might as well be used as a stop gap instead. I'll revisit this if need be.

nodejs-github-bot · 2026-08-16T10:53:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75882/

Hardanish-Singh · 2026-08-17T16:53:48Z

+ );
+ try {
+ await handle.finished;
+ } finally {


[nit]: we should add a catch block here as well

nodejs-github-bot · 2026-08-18T06:20:54Z

Landed in 1c9baec

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65320 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test: keep WPT backend checks alive
573b75e
Signed-off-by: Filip Skokan <panva.ip@gmail.com>

panva added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Aug 16, 2026

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 16, 2026

This comment was marked as outdated.
Sign in to view

aduh95 approved these changes Aug 16, 2026
View reviewed changes

aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 16, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2026

This comment was marked as outdated.
Sign in to view

trivenay mentioned this pull request Aug 16, 2026
quic: remove unused fin flag from blob reader wakeup #65315
Merged

panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 16, 2026

avivkeller approved these changes Aug 16, 2026
View reviewed changes

Hardanish-Singh reviewed Aug 17, 2026
View reviewed changes

lpinca approved these changes Aug 17, 2026
View reviewed changes

nodejs-github-bot merged commit 1c9baec into nodejs:mainAug 18, 2026
99 of 100 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 18, 2026

panva deleted the fix-wpt-backends-lifetime branch August 18, 2026 07:02