module: change return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback by caiolima · Pull Request #65375 · nodejs/node

caiolima · 2026-08-18T10:22:56Z

This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 and https://chromium-review.googlesource.com/c/v8/v8/+/8223168. The core of this change is to make clear on return type of SyntheticModuleEvaluationSteps that it should be a MaybeLocal<Promise> instead of MaybeLocal<Value>. The latter API will be removed soon from V8.

The PR is including the backport of both commits mentioned above and they are combined here to allow the change on Node side without causing compilation issues. Current code already always return a Promise, so the effective change is just the return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback.

Original commit message: [api][module] Return a Promise from Module::Evaluate() Module evaluation always produces a Promise, but the public API exposed the result as MaybeLocal<Value>, and for synthetic modules it could even hand back the raw, non-Promise value returned by the embedder's evaluation steps. Embedders therefore had to defensively cast the result, and the actual contract was invisible in the type system. This CL makes the contract explicit: - SyntheticModule::Evaluate() now returns the top-level capability Promise instead of the raw value produced by the evaluation steps, so the completion value is always a Promise, matching source text modules and the documented behavior. - SyntheticModule::Evaluate() nows CHECK if callback result from EvaluationSteps is a Promise. The reasoning behind it is that the behavior for an embedder that relies on non-promise result was already inconsistent, given the first call would return the result form callback (an arbitrary Local<Value>), but subsequent calls for module->Evaluate() would return the capability with `undefined` as result. - Module::Evaluate() and their variant now returns `MaybeDirectHandle<JSPromise>` to be more explicit by the return type. Bug: 531396274 Change-Id: Ifbfed4f849bb47d8db1e022bfb750d9ad2d6308b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8131138 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#109010} Refs: v8/v8@e778593 Co-authored-by: Caio Lima <caiolima@igalia.com>

Original commit message: [api][module] Type-check synthetic module evaluation steps Synthetic module evaluation steps are required to return a Promise, which becomes the module's top-level capability. Their signature returned a MaybeLocal<Value> though, so that requirement was only enforced by a CHECK in SyntheticModule::Evaluate(). SyntheticModuleEvaluationSteps now returns a MaybeLocal<Promise>, with a matching CreateSyntheticModule() overload. The old signature remains available as LegacySyntheticModuleEvaluationSteps so that embedders can be migrated in a separate CL; it will be deprecated and then removed once embedders migrate. d8 and the existing tests move to the Promise-returning version, with one cctest checking the legacy version. Bug: 545375591 Change-Id: Id55db730678455f81394bf8a68f66f93d22f5547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223168 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Cr-Commit-Position: refs/heads/main@{#109273} Refs: v8/v8@970d651 Co-authored-by: Caio Lima <caiolima@igalia.com>

… MaybeLocal<Promise>

nodejs-github-bot · 2026-08-18T10:23:01Z

caiolima · 2026-08-18T10:24:38Z

+ V8_DEPRECATE_SOON(
+ "Use the CreateSyntheticModule overload whose evaluation_steps return a "
+ "MaybeLocal<Promise>")
+ static Local<Module> CreateSyntheticModule(


This becomes dead-code here once we migrate ModuleWrap::SyntheticModuleEvaluationStepsCallback to return MaybeLocal<Promise>. I'm keeping it here just to have minimal difference from original V8 commit.

caiolima · 2026-08-18T10:24:54Z

 }

+START_ALLOW_USE_DEPRECATED()
+Local<Module> Module::CreateSyntheticModule(


ditto about dead-code.

codecov · 2026-08-18T13:20:21Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (3781ebc) to head (579df3c).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	50.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65375 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 752 752 Lines 251820 251861 +41 Branches 47351 47363 +12 =======================================
+ Hits 226923 226982 +59 - Misses 16223 16226 +3 + Partials 8674 8653 -21

Files with missing lines	Coverage Δ
src/module_wrap.h	`52.94% <ø> (ø)`
src/module_wrap.cc	`74.21% <50.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caiolima · 2026-08-18T14:00:30Z

As a reference, this is the change on Blink without the need of backports: https://chromium-review.googlesource.com/c/chromium/src/+/8257345

joyeecheung · 2026-08-18T15:03:45Z

 * If IsGraphAsync() is false, the returned Promise is settled.
 */
- V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Promise> Evaluate(Local<Context> context);


This would break the ABI - I think if we want to backport to 22-26, this would need to be a duplicate method with a different name. Otherwise this needs to be dont-land-on-v26.x etc. and mostly just expediting things a bit more over #65161

I'm not planning to backport, given it doesn't change pretty much anything in practice. The goal here is to make sure that we will be able to remove the callback that returns MaybeLocal<Value> eventually.

nodejs-github-bot · 2026-08-18T15:20:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75968/

joyeecheung · 2026-09-03T10:30:30Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

caiolima · 2026-09-03T18:41:54Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

Sure. I'll do it. Thanks for the heads up.

caiolima · 2026-08-18T10:22:56Z

This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 and https://chromium-review.googlesource.com/c/v8/v8/+/8223168. The core of this change is to make clear on return type of SyntheticModuleEvaluationSteps that it should be a MaybeLocal<Promise> instead of MaybeLocal<Value>. The latter API will be removed soon from V8.

The PR is including the backport of both commits mentioned above and they are combined here to allow the change on Node side without causing compilation issues. Current code already always return a Promise, so the effective change is just the return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback.

Original commit message: [api][module] Return a Promise from Module::Evaluate() Module evaluation always produces a Promise, but the public API exposed the result as MaybeLocal<Value>, and for synthetic modules it could even hand back the raw, non-Promise value returned by the embedder's evaluation steps. Embedders therefore had to defensively cast the result, and the actual contract was invisible in the type system. This CL makes the contract explicit: - SyntheticModule::Evaluate() now returns the top-level capability Promise instead of the raw value produced by the evaluation steps, so the completion value is always a Promise, matching source text modules and the documented behavior. - SyntheticModule::Evaluate() nows CHECK if callback result from EvaluationSteps is a Promise. The reasoning behind it is that the behavior for an embedder that relies on non-promise result was already inconsistent, given the first call would return the result form callback (an arbitrary Local<Value>), but subsequent calls for module->Evaluate() would return the capability with `undefined` as result. - Module::Evaluate() and their variant now returns `MaybeDirectHandle<JSPromise>` to be more explicit by the return type. Bug: 531396274 Change-Id: Ifbfed4f849bb47d8db1e022bfb750d9ad2d6308b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8131138 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#109010} Refs: v8/v8@e778593 Co-authored-by: Caio Lima <caiolima@igalia.com>

Original commit message: [api][module] Type-check synthetic module evaluation steps Synthetic module evaluation steps are required to return a Promise, which becomes the module's top-level capability. Their signature returned a MaybeLocal<Value> though, so that requirement was only enforced by a CHECK in SyntheticModule::Evaluate(). SyntheticModuleEvaluationSteps now returns a MaybeLocal<Promise>, with a matching CreateSyntheticModule() overload. The old signature remains available as LegacySyntheticModuleEvaluationSteps so that embedders can be migrated in a separate CL; it will be deprecated and then removed once embedders migrate. d8 and the existing tests move to the Promise-returning version, with one cctest checking the legacy version. Bug: 545375591 Change-Id: Id55db730678455f81394bf8a68f66f93d22f5547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223168 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Cr-Commit-Position: refs/heads/main@{#109273} Refs: v8/v8@970d651 Co-authored-by: Caio Lima <caiolima@igalia.com>

… MaybeLocal<Promise>

nodejs-github-bot · 2026-08-18T10:23:01Z

caiolima · 2026-08-18T10:24:38Z

+ V8_DEPRECATE_SOON(
+ "Use the CreateSyntheticModule overload whose evaluation_steps return a "
+ "MaybeLocal<Promise>")
+ static Local<Module> CreateSyntheticModule(


This becomes dead-code here once we migrate ModuleWrap::SyntheticModuleEvaluationStepsCallback to return MaybeLocal<Promise>. I'm keeping it here just to have minimal difference from original V8 commit.

caiolima · 2026-08-18T10:24:54Z

 }

+START_ALLOW_USE_DEPRECATED()
+Local<Module> Module::CreateSyntheticModule(


ditto about dead-code.

codecov · 2026-08-18T13:20:21Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (3781ebc) to head (579df3c).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	50.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65375 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 752 752 Lines 251820 251861 +41 Branches 47351 47363 +12 =======================================
+ Hits 226923 226982 +59 - Misses 16223 16226 +3 + Partials 8674 8653 -21

Files with missing lines	Coverage Δ
src/module_wrap.h	`52.94% <ø> (ø)`
src/module_wrap.cc	`74.21% <50.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caiolima · 2026-08-18T14:00:30Z

As a reference, this is the change on Blink without the need of backports: https://chromium-review.googlesource.com/c/chromium/src/+/8257345

joyeecheung · 2026-08-18T15:03:45Z

 * If IsGraphAsync() is false, the returned Promise is settled.
 */
- V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Promise> Evaluate(Local<Context> context);


This would break the ABI - I think if we want to backport to 22-26, this would need to be a duplicate method with a different name. Otherwise this needs to be dont-land-on-v26.x etc. and mostly just expediting things a bit more over #65161

I'm not planning to backport, given it doesn't change pretty much anything in practice. The goal here is to make sure that we will be able to remove the callback that returns MaybeLocal<Value> eventually.

nodejs-github-bot · 2026-08-18T15:20:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75968/

joyeecheung · 2026-09-03T10:30:30Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

caiolima · 2026-09-03T18:41:54Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

Sure. I'll do it. Thanks for the heads up.

caiolima · 2026-08-18T10:22:56Z

This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 and https://chromium-review.googlesource.com/c/v8/v8/+/8223168. The core of this change is to make clear on return type of SyntheticModuleEvaluationSteps that it should be a MaybeLocal<Promise> instead of MaybeLocal<Value>. The latter API will be removed soon from V8.

The PR is including the backport of both commits mentioned above and they are combined here to allow the change on Node side without causing compilation issues. Current code already always return a Promise, so the effective change is just the return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback.

Original commit message: [api][module] Return a Promise from Module::Evaluate() Module evaluation always produces a Promise, but the public API exposed the result as MaybeLocal<Value>, and for synthetic modules it could even hand back the raw, non-Promise value returned by the embedder's evaluation steps. Embedders therefore had to defensively cast the result, and the actual contract was invisible in the type system. This CL makes the contract explicit: - SyntheticModule::Evaluate() now returns the top-level capability Promise instead of the raw value produced by the evaluation steps, so the completion value is always a Promise, matching source text modules and the documented behavior. - SyntheticModule::Evaluate() nows CHECK if callback result from EvaluationSteps is a Promise. The reasoning behind it is that the behavior for an embedder that relies on non-promise result was already inconsistent, given the first call would return the result form callback (an arbitrary Local<Value>), but subsequent calls for module->Evaluate() would return the capability with `undefined` as result. - Module::Evaluate() and their variant now returns `MaybeDirectHandle<JSPromise>` to be more explicit by the return type. Bug: 531396274 Change-Id: Ifbfed4f849bb47d8db1e022bfb750d9ad2d6308b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8131138 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#109010} Refs: v8/v8@e778593 Co-authored-by: Caio Lima <caiolima@igalia.com>

Original commit message: [api][module] Type-check synthetic module evaluation steps Synthetic module evaluation steps are required to return a Promise, which becomes the module's top-level capability. Their signature returned a MaybeLocal<Value> though, so that requirement was only enforced by a CHECK in SyntheticModule::Evaluate(). SyntheticModuleEvaluationSteps now returns a MaybeLocal<Promise>, with a matching CreateSyntheticModule() overload. The old signature remains available as LegacySyntheticModuleEvaluationSteps so that embedders can be migrated in a separate CL; it will be deprecated and then removed once embedders migrate. d8 and the existing tests move to the Promise-returning version, with one cctest checking the legacy version. Bug: 545375591 Change-Id: Id55db730678455f81394bf8a68f66f93d22f5547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223168 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Cr-Commit-Position: refs/heads/main@{#109273} Refs: v8/v8@970d651 Co-authored-by: Caio Lima <caiolima@igalia.com>

… MaybeLocal<Promise>

nodejs-github-bot · 2026-08-18T10:23:01Z

caiolima · 2026-08-18T10:24:38Z

+ V8_DEPRECATE_SOON(
+ "Use the CreateSyntheticModule overload whose evaluation_steps return a "
+ "MaybeLocal<Promise>")
+ static Local<Module> CreateSyntheticModule(


This becomes dead-code here once we migrate ModuleWrap::SyntheticModuleEvaluationStepsCallback to return MaybeLocal<Promise>. I'm keeping it here just to have minimal difference from original V8 commit.

caiolima · 2026-08-18T10:24:54Z

 }

+START_ALLOW_USE_DEPRECATED()
+Local<Module> Module::CreateSyntheticModule(


ditto about dead-code.

codecov · 2026-08-18T13:20:21Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (3781ebc) to head (579df3c).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	50.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65375 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 752 752 Lines 251820 251861 +41 Branches 47351 47363 +12 =======================================
+ Hits 226923 226982 +59 - Misses 16223 16226 +3 + Partials 8674 8653 -21

Files with missing lines	Coverage Δ
src/module_wrap.h	`52.94% <ø> (ø)`
src/module_wrap.cc	`74.21% <50.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caiolima · 2026-08-18T14:00:30Z

As a reference, this is the change on Blink without the need of backports: https://chromium-review.googlesource.com/c/chromium/src/+/8257345

joyeecheung · 2026-08-18T15:03:45Z

 * If IsGraphAsync() is false, the returned Promise is settled.
 */
- V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Promise> Evaluate(Local<Context> context);


This would break the ABI - I think if we want to backport to 22-26, this would need to be a duplicate method with a different name. Otherwise this needs to be dont-land-on-v26.x etc. and mostly just expediting things a bit more over #65161

I'm not planning to backport, given it doesn't change pretty much anything in practice. The goal here is to make sure that we will be able to remove the callback that returns MaybeLocal<Value> eventually.

nodejs-github-bot · 2026-08-18T15:20:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75968/

joyeecheung · 2026-09-03T10:30:30Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

caiolima · 2026-09-03T18:41:54Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

Sure. I'll do it. Thanks for the heads up.

caiolima · 2026-08-18T10:22:56Z

This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 and https://chromium-review.googlesource.com/c/v8/v8/+/8223168. The core of this change is to make clear on return type of SyntheticModuleEvaluationSteps that it should be a MaybeLocal<Promise> instead of MaybeLocal<Value>. The latter API will be removed soon from V8.

The PR is including the backport of both commits mentioned above and they are combined here to allow the change on Node side without causing compilation issues. Current code already always return a Promise, so the effective change is just the return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback.

Original commit message: [api][module] Return a Promise from Module::Evaluate() Module evaluation always produces a Promise, but the public API exposed the result as MaybeLocal<Value>, and for synthetic modules it could even hand back the raw, non-Promise value returned by the embedder's evaluation steps. Embedders therefore had to defensively cast the result, and the actual contract was invisible in the type system. This CL makes the contract explicit: - SyntheticModule::Evaluate() now returns the top-level capability Promise instead of the raw value produced by the evaluation steps, so the completion value is always a Promise, matching source text modules and the documented behavior. - SyntheticModule::Evaluate() nows CHECK if callback result from EvaluationSteps is a Promise. The reasoning behind it is that the behavior for an embedder that relies on non-promise result was already inconsistent, given the first call would return the result form callback (an arbitrary Local<Value>), but subsequent calls for module->Evaluate() would return the capability with `undefined` as result. - Module::Evaluate() and their variant now returns `MaybeDirectHandle<JSPromise>` to be more explicit by the return type. Bug: 531396274 Change-Id: Ifbfed4f849bb47d8db1e022bfb750d9ad2d6308b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8131138 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#109010} Refs: v8/v8@e778593 Co-authored-by: Caio Lima <caiolima@igalia.com>

Original commit message: [api][module] Type-check synthetic module evaluation steps Synthetic module evaluation steps are required to return a Promise, which becomes the module's top-level capability. Their signature returned a MaybeLocal<Value> though, so that requirement was only enforced by a CHECK in SyntheticModule::Evaluate(). SyntheticModuleEvaluationSteps now returns a MaybeLocal<Promise>, with a matching CreateSyntheticModule() overload. The old signature remains available as LegacySyntheticModuleEvaluationSteps so that embedders can be migrated in a separate CL; it will be deprecated and then removed once embedders migrate. d8 and the existing tests move to the Promise-returning version, with one cctest checking the legacy version. Bug: 545375591 Change-Id: Id55db730678455f81394bf8a68f66f93d22f5547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223168 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Cr-Commit-Position: refs/heads/main@{#109273} Refs: v8/v8@970d651 Co-authored-by: Caio Lima <caiolima@igalia.com>

… MaybeLocal<Promise>

nodejs-github-bot · 2026-08-18T10:23:01Z

caiolima · 2026-08-18T10:24:38Z

+ V8_DEPRECATE_SOON(
+ "Use the CreateSyntheticModule overload whose evaluation_steps return a "
+ "MaybeLocal<Promise>")
+ static Local<Module> CreateSyntheticModule(


This becomes dead-code here once we migrate ModuleWrap::SyntheticModuleEvaluationStepsCallback to return MaybeLocal<Promise>. I'm keeping it here just to have minimal difference from original V8 commit.

caiolima · 2026-08-18T10:24:54Z

 }

+START_ALLOW_USE_DEPRECATED()
+Local<Module> Module::CreateSyntheticModule(


ditto about dead-code.

codecov · 2026-08-18T13:20:21Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (3781ebc) to head (579df3c).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	50.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65375 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 752 752 Lines 251820 251861 +41 Branches 47351 47363 +12 =======================================
+ Hits 226923 226982 +59 - Misses 16223 16226 +3 + Partials 8674 8653 -21

Files with missing lines	Coverage Δ
src/module_wrap.h	`52.94% <ø> (ø)`
src/module_wrap.cc	`74.21% <50.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caiolima · 2026-08-18T14:00:30Z

As a reference, this is the change on Blink without the need of backports: https://chromium-review.googlesource.com/c/chromium/src/+/8257345

joyeecheung · 2026-08-18T15:03:45Z

 * If IsGraphAsync() is false, the returned Promise is settled.
 */
- V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Promise> Evaluate(Local<Context> context);


This would break the ABI - I think if we want to backport to 22-26, this would need to be a duplicate method with a different name. Otherwise this needs to be dont-land-on-v26.x etc. and mostly just expediting things a bit more over #65161

I'm not planning to backport, given it doesn't change pretty much anything in practice. The goal here is to make sure that we will be able to remove the callback that returns MaybeLocal<Value> eventually.

nodejs-github-bot · 2026-08-18T15:20:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75968/

joyeecheung · 2026-09-03T10:30:30Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

caiolima · 2026-09-03T18:41:54Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

Sure. I'll do it. Thanks for the heads up.

caiolima · 2026-08-18T10:22:56Z

This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 and https://chromium-review.googlesource.com/c/v8/v8/+/8223168. The core of this change is to make clear on return type of SyntheticModuleEvaluationSteps that it should be a MaybeLocal<Promise> instead of MaybeLocal<Value>. The latter API will be removed soon from V8.

The PR is including the backport of both commits mentioned above and they are combined here to allow the change on Node side without causing compilation issues. Current code already always return a Promise, so the effective change is just the return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback.

Original commit message: [api][module] Return a Promise from Module::Evaluate() Module evaluation always produces a Promise, but the public API exposed the result as MaybeLocal<Value>, and for synthetic modules it could even hand back the raw, non-Promise value returned by the embedder's evaluation steps. Embedders therefore had to defensively cast the result, and the actual contract was invisible in the type system. This CL makes the contract explicit: - SyntheticModule::Evaluate() now returns the top-level capability Promise instead of the raw value produced by the evaluation steps, so the completion value is always a Promise, matching source text modules and the documented behavior. - SyntheticModule::Evaluate() nows CHECK if callback result from EvaluationSteps is a Promise. The reasoning behind it is that the behavior for an embedder that relies on non-promise result was already inconsistent, given the first call would return the result form callback (an arbitrary Local<Value>), but subsequent calls for module->Evaluate() would return the capability with `undefined` as result. - Module::Evaluate() and their variant now returns `MaybeDirectHandle<JSPromise>` to be more explicit by the return type. Bug: 531396274 Change-Id: Ifbfed4f849bb47d8db1e022bfb750d9ad2d6308b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8131138 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#109010} Refs: v8/v8@e778593 Co-authored-by: Caio Lima <caiolima@igalia.com>

Original commit message: [api][module] Type-check synthetic module evaluation steps Synthetic module evaluation steps are required to return a Promise, which becomes the module's top-level capability. Their signature returned a MaybeLocal<Value> though, so that requirement was only enforced by a CHECK in SyntheticModule::Evaluate(). SyntheticModuleEvaluationSteps now returns a MaybeLocal<Promise>, with a matching CreateSyntheticModule() overload. The old signature remains available as LegacySyntheticModuleEvaluationSteps so that embedders can be migrated in a separate CL; it will be deprecated and then removed once embedders migrate. d8 and the existing tests move to the Promise-returning version, with one cctest checking the legacy version. Bug: 545375591 Change-Id: Id55db730678455f81394bf8a68f66f93d22f5547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223168 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Cr-Commit-Position: refs/heads/main@{#109273} Refs: v8/v8@970d651 Co-authored-by: Caio Lima <caiolima@igalia.com>

… MaybeLocal<Promise>

nodejs-github-bot · 2026-08-18T10:23:01Z

caiolima · 2026-08-18T10:24:38Z

+ V8_DEPRECATE_SOON(
+ "Use the CreateSyntheticModule overload whose evaluation_steps return a "
+ "MaybeLocal<Promise>")
+ static Local<Module> CreateSyntheticModule(


This becomes dead-code here once we migrate ModuleWrap::SyntheticModuleEvaluationStepsCallback to return MaybeLocal<Promise>. I'm keeping it here just to have minimal difference from original V8 commit.

caiolima · 2026-08-18T10:24:54Z

 }

+START_ALLOW_USE_DEPRECATED()
+Local<Module> Module::CreateSyntheticModule(


ditto about dead-code.

codecov · 2026-08-18T13:20:21Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (3781ebc) to head (579df3c).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	50.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65375 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 752 752 Lines 251820 251861 +41 Branches 47351 47363 +12 =======================================
+ Hits 226923 226982 +59 - Misses 16223 16226 +3 + Partials 8674 8653 -21

Files with missing lines	Coverage Δ
src/module_wrap.h	`52.94% <ø> (ø)`
src/module_wrap.cc	`74.21% <50.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caiolima · 2026-08-18T14:00:30Z

As a reference, this is the change on Blink without the need of backports: https://chromium-review.googlesource.com/c/chromium/src/+/8257345

joyeecheung · 2026-08-18T15:03:45Z

 * If IsGraphAsync() is false, the returned Promise is settled.
 */
- V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Promise> Evaluate(Local<Context> context);


This would break the ABI - I think if we want to backport to 22-26, this would need to be a duplicate method with a different name. Otherwise this needs to be dont-land-on-v26.x etc. and mostly just expediting things a bit more over #65161

I'm not planning to backport, given it doesn't change pretty much anything in practice. The goal here is to make sure that we will be able to remove the callback that returns MaybeLocal<Value> eventually.

nodejs-github-bot · 2026-08-18T15:20:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75968/

joyeecheung · 2026-09-03T10:30:30Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

caiolima · 2026-09-03T18:41:54Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

Sure. I'll do it. Thanks for the heads up.

caiolima · 2026-08-18T10:22:56Z

This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 and https://chromium-review.googlesource.com/c/v8/v8/+/8223168. The core of this change is to make clear on return type of SyntheticModuleEvaluationSteps that it should be a MaybeLocal<Promise> instead of MaybeLocal<Value>. The latter API will be removed soon from V8.

The PR is including the backport of both commits mentioned above and they are combined here to allow the change on Node side without causing compilation issues. Current code already always return a Promise, so the effective change is just the return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback.

Original commit message: [api][module] Return a Promise from Module::Evaluate() Module evaluation always produces a Promise, but the public API exposed the result as MaybeLocal<Value>, and for synthetic modules it could even hand back the raw, non-Promise value returned by the embedder's evaluation steps. Embedders therefore had to defensively cast the result, and the actual contract was invisible in the type system. This CL makes the contract explicit: - SyntheticModule::Evaluate() now returns the top-level capability Promise instead of the raw value produced by the evaluation steps, so the completion value is always a Promise, matching source text modules and the documented behavior. - SyntheticModule::Evaluate() nows CHECK if callback result from EvaluationSteps is a Promise. The reasoning behind it is that the behavior for an embedder that relies on non-promise result was already inconsistent, given the first call would return the result form callback (an arbitrary Local<Value>), but subsequent calls for module->Evaluate() would return the capability with `undefined` as result. - Module::Evaluate() and their variant now returns `MaybeDirectHandle<JSPromise>` to be more explicit by the return type. Bug: 531396274 Change-Id: Ifbfed4f849bb47d8db1e022bfb750d9ad2d6308b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8131138 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#109010} Refs: v8/v8@e778593 Co-authored-by: Caio Lima <caiolima@igalia.com>

Original commit message: [api][module] Type-check synthetic module evaluation steps Synthetic module evaluation steps are required to return a Promise, which becomes the module's top-level capability. Their signature returned a MaybeLocal<Value> though, so that requirement was only enforced by a CHECK in SyntheticModule::Evaluate(). SyntheticModuleEvaluationSteps now returns a MaybeLocal<Promise>, with a matching CreateSyntheticModule() overload. The old signature remains available as LegacySyntheticModuleEvaluationSteps so that embedders can be migrated in a separate CL; it will be deprecated and then removed once embedders migrate. d8 and the existing tests move to the Promise-returning version, with one cctest checking the legacy version. Bug: 545375591 Change-Id: Id55db730678455f81394bf8a68f66f93d22f5547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223168 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Cr-Commit-Position: refs/heads/main@{#109273} Refs: v8/v8@970d651 Co-authored-by: Caio Lima <caiolima@igalia.com>

… MaybeLocal<Promise>

nodejs-github-bot · 2026-08-18T10:23:01Z

caiolima · 2026-08-18T10:24:38Z

+ V8_DEPRECATE_SOON(
+ "Use the CreateSyntheticModule overload whose evaluation_steps return a "
+ "MaybeLocal<Promise>")
+ static Local<Module> CreateSyntheticModule(


This becomes dead-code here once we migrate ModuleWrap::SyntheticModuleEvaluationStepsCallback to return MaybeLocal<Promise>. I'm keeping it here just to have minimal difference from original V8 commit.

caiolima · 2026-08-18T10:24:54Z

 }

+START_ALLOW_USE_DEPRECATED()
+Local<Module> Module::CreateSyntheticModule(


ditto about dead-code.

codecov · 2026-08-18T13:20:21Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (3781ebc) to head (579df3c).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	50.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65375 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 752 752 Lines 251820 251861 +41 Branches 47351 47363 +12 =======================================
+ Hits 226923 226982 +59 - Misses 16223 16226 +3 + Partials 8674 8653 -21

Files with missing lines	Coverage Δ
src/module_wrap.h	`52.94% <ø> (ø)`
src/module_wrap.cc	`74.21% <50.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caiolima · 2026-08-18T14:00:30Z

As a reference, this is the change on Blink without the need of backports: https://chromium-review.googlesource.com/c/chromium/src/+/8257345

joyeecheung · 2026-08-18T15:03:45Z

 * If IsGraphAsync() is false, the returned Promise is settled.
 */
- V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Promise> Evaluate(Local<Context> context);


This would break the ABI - I think if we want to backport to 22-26, this would need to be a duplicate method with a different name. Otherwise this needs to be dont-land-on-v26.x etc. and mostly just expediting things a bit more over #65161

I'm not planning to backport, given it doesn't change pretty much anything in practice. The goal here is to make sure that we will be able to remove the callback that returns MaybeLocal<Value> eventually.

nodejs-github-bot · 2026-08-18T15:20:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75968/

joyeecheung · 2026-09-03T10:30:30Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

caiolima · 2026-09-03T18:41:54Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

Sure. I'll do it. Thanks for the heads up.

caiolima · 2026-08-18T10:22:56Z

This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 and https://chromium-review.googlesource.com/c/v8/v8/+/8223168. The core of this change is to make clear on return type of SyntheticModuleEvaluationSteps that it should be a MaybeLocal<Promise> instead of MaybeLocal<Value>. The latter API will be removed soon from V8.

The PR is including the backport of both commits mentioned above and they are combined here to allow the change on Node side without causing compilation issues. Current code already always return a Promise, so the effective change is just the return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback.

Original commit message: [api][module] Return a Promise from Module::Evaluate() Module evaluation always produces a Promise, but the public API exposed the result as MaybeLocal<Value>, and for synthetic modules it could even hand back the raw, non-Promise value returned by the embedder's evaluation steps. Embedders therefore had to defensively cast the result, and the actual contract was invisible in the type system. This CL makes the contract explicit: - SyntheticModule::Evaluate() now returns the top-level capability Promise instead of the raw value produced by the evaluation steps, so the completion value is always a Promise, matching source text modules and the documented behavior. - SyntheticModule::Evaluate() nows CHECK if callback result from EvaluationSteps is a Promise. The reasoning behind it is that the behavior for an embedder that relies on non-promise result was already inconsistent, given the first call would return the result form callback (an arbitrary Local<Value>), but subsequent calls for module->Evaluate() would return the capability with `undefined` as result. - Module::Evaluate() and their variant now returns `MaybeDirectHandle<JSPromise>` to be more explicit by the return type. Bug: 531396274 Change-Id: Ifbfed4f849bb47d8db1e022bfb750d9ad2d6308b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8131138 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#109010} Refs: v8/v8@e778593 Co-authored-by: Caio Lima <caiolima@igalia.com>

Original commit message: [api][module] Type-check synthetic module evaluation steps Synthetic module evaluation steps are required to return a Promise, which becomes the module's top-level capability. Their signature returned a MaybeLocal<Value> though, so that requirement was only enforced by a CHECK in SyntheticModule::Evaluate(). SyntheticModuleEvaluationSteps now returns a MaybeLocal<Promise>, with a matching CreateSyntheticModule() overload. The old signature remains available as LegacySyntheticModuleEvaluationSteps so that embedders can be migrated in a separate CL; it will be deprecated and then removed once embedders migrate. d8 and the existing tests move to the Promise-returning version, with one cctest checking the legacy version. Bug: 545375591 Change-Id: Id55db730678455f81394bf8a68f66f93d22f5547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223168 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Cr-Commit-Position: refs/heads/main@{#109273} Refs: v8/v8@970d651 Co-authored-by: Caio Lima <caiolima@igalia.com>

… MaybeLocal<Promise>

nodejs-github-bot · 2026-08-18T10:23:01Z

caiolima · 2026-08-18T10:24:38Z

+ V8_DEPRECATE_SOON(
+ "Use the CreateSyntheticModule overload whose evaluation_steps return a "
+ "MaybeLocal<Promise>")
+ static Local<Module> CreateSyntheticModule(


This becomes dead-code here once we migrate ModuleWrap::SyntheticModuleEvaluationStepsCallback to return MaybeLocal<Promise>. I'm keeping it here just to have minimal difference from original V8 commit.

caiolima · 2026-08-18T10:24:54Z

 }

+START_ALLOW_USE_DEPRECATED()
+Local<Module> Module::CreateSyntheticModule(


ditto about dead-code.

codecov · 2026-08-18T13:20:21Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (3781ebc) to head (579df3c).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	50.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65375 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 752 752 Lines 251820 251861 +41 Branches 47351 47363 +12 =======================================
+ Hits 226923 226982 +59 - Misses 16223 16226 +3 + Partials 8674 8653 -21

Files with missing lines	Coverage Δ
src/module_wrap.h	`52.94% <ø> (ø)`
src/module_wrap.cc	`74.21% <50.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caiolima · 2026-08-18T14:00:30Z

As a reference, this is the change on Blink without the need of backports: https://chromium-review.googlesource.com/c/chromium/src/+/8257345

joyeecheung · 2026-08-18T15:03:45Z

 * If IsGraphAsync() is false, the returned Promise is settled.
 */
- V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Promise> Evaluate(Local<Context> context);


This would break the ABI - I think if we want to backport to 22-26, this would need to be a duplicate method with a different name. Otherwise this needs to be dont-land-on-v26.x etc. and mostly just expediting things a bit more over #65161

I'm not planning to backport, given it doesn't change pretty much anything in practice. The goal here is to make sure that we will be able to remove the callback that returns MaybeLocal<Value> eventually.

nodejs-github-bot · 2026-08-18T15:20:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75968/

joyeecheung · 2026-09-03T10:30:30Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

caiolima · 2026-09-03T18:41:54Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

Sure. I'll do it. Thanks for the heads up.

caiolima · 2026-08-18T10:22:56Z

This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 and https://chromium-review.googlesource.com/c/v8/v8/+/8223168. The core of this change is to make clear on return type of SyntheticModuleEvaluationSteps that it should be a MaybeLocal<Promise> instead of MaybeLocal<Value>. The latter API will be removed soon from V8.

The PR is including the backport of both commits mentioned above and they are combined here to allow the change on Node side without causing compilation issues. Current code already always return a Promise, so the effective change is just the return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback.

Original commit message: [api][module] Return a Promise from Module::Evaluate() Module evaluation always produces a Promise, but the public API exposed the result as MaybeLocal<Value>, and for synthetic modules it could even hand back the raw, non-Promise value returned by the embedder's evaluation steps. Embedders therefore had to defensively cast the result, and the actual contract was invisible in the type system. This CL makes the contract explicit: - SyntheticModule::Evaluate() now returns the top-level capability Promise instead of the raw value produced by the evaluation steps, so the completion value is always a Promise, matching source text modules and the documented behavior. - SyntheticModule::Evaluate() nows CHECK if callback result from EvaluationSteps is a Promise. The reasoning behind it is that the behavior for an embedder that relies on non-promise result was already inconsistent, given the first call would return the result form callback (an arbitrary Local<Value>), but subsequent calls for module->Evaluate() would return the capability with `undefined` as result. - Module::Evaluate() and their variant now returns `MaybeDirectHandle<JSPromise>` to be more explicit by the return type. Bug: 531396274 Change-Id: Ifbfed4f849bb47d8db1e022bfb750d9ad2d6308b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8131138 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Reviewed-by: Olivier Flückiger <olivf@chromium.org> Cr-Commit-Position: refs/heads/main@{#109010} Refs: v8/v8@e778593 Co-authored-by: Caio Lima <caiolima@igalia.com>

Original commit message: [api][module] Type-check synthetic module evaluation steps Synthetic module evaluation steps are required to return a Promise, which becomes the module's top-level capability. Their signature returned a MaybeLocal<Value> though, so that requirement was only enforced by a CHECK in SyntheticModule::Evaluate(). SyntheticModuleEvaluationSteps now returns a MaybeLocal<Promise>, with a matching CreateSyntheticModule() overload. The old signature remains available as LegacySyntheticModuleEvaluationSteps so that embedders can be migrated in a separate CL; it will be deprecated and then removed once embedders migrate. d8 and the existing tests move to the Promise-returning version, with one cctest checking the legacy version. Bug: 545375591 Change-Id: Id55db730678455f81394bf8a68f66f93d22f5547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223168 Reviewed-by: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Caio Lima <caiolima@igalia.com> Cr-Commit-Position: refs/heads/main@{#109273} Refs: v8/v8@970d651 Co-authored-by: Caio Lima <caiolima@igalia.com>

… MaybeLocal<Promise>

nodejs-github-bot · 2026-08-18T10:23:01Z

caiolima · 2026-08-18T10:24:38Z

+ V8_DEPRECATE_SOON(
+ "Use the CreateSyntheticModule overload whose evaluation_steps return a "
+ "MaybeLocal<Promise>")
+ static Local<Module> CreateSyntheticModule(


This becomes dead-code here once we migrate ModuleWrap::SyntheticModuleEvaluationStepsCallback to return MaybeLocal<Promise>. I'm keeping it here just to have minimal difference from original V8 commit.

caiolima · 2026-08-18T10:24:54Z

 }

+START_ALLOW_USE_DEPRECATED()
+Local<Module> Module::CreateSyntheticModule(


ditto about dead-code.

codecov · 2026-08-18T13:20:21Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (3781ebc) to head (579df3c).
⚠️ Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
src/module_wrap.cc	50.00%	2 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65375 +/- ##
=======================================
Coverage 90.11% 90.12% =======================================
Files 752 752 Lines 251820 251861 +41 Branches 47351 47363 +12 =======================================
+ Hits 226923 226982 +59 - Misses 16223 16226 +3 + Partials 8674 8653 -21

Files with missing lines	Coverage Δ
src/module_wrap.h	`52.94% <ø> (ø)`
src/module_wrap.cc	`74.21% <50.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

caiolima · 2026-08-18T14:00:30Z

As a reference, this is the change on Blink without the need of backports: https://chromium-review.googlesource.com/c/chromium/src/+/8257345

joyeecheung · 2026-08-18T15:03:45Z

 * If IsGraphAsync() is false, the returned Promise is settled.
 */
- V8_WARN_UNUSED_RESULT MaybeLocal<Value> Evaluate(Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Promise> Evaluate(Local<Context> context);


This would break the ABI - I think if we want to backport to 22-26, this would need to be a duplicate method with a different name. Otherwise this needs to be dont-land-on-v26.x etc. and mostly just expediting things a bit more over #65161

I'm not planning to backport, given it doesn't change pretty much anything in practice. The goal here is to make sure that we will be able to remove the callback that returns MaybeLocal<Value> eventually.

nodejs-github-bot · 2026-08-18T15:20:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75968/

joyeecheung · 2026-09-03T10:30:30Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

caiolima · 2026-09-03T18:41:54Z

@caiolima Another commit has bumped the V8 embedder version, can you rebase and resolve the merge conflict?

Sure. I'll do it. Thanks for the heads up.

caiolima added 3 commits August 17, 2026 13:56

Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…
579df3c
… MaybeLocal<Promise>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 18, 2026

caiolima commented Aug 18, 2026
View reviewed changes

joyeecheung reviewed Aug 18, 2026
View reviewed changes

joyeecheung approved these changes Aug 18, 2026
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

caiolima added 3 commits August 17, 2026 13:56

Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…
579df3c
… MaybeLocal<Promise>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 18, 2026

caiolima commented Aug 18, 2026
View reviewed changes

joyeecheung reviewed Aug 18, 2026
View reviewed changes

joyeecheung approved these changes Aug 18, 2026
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

caiolima added 3 commits August 17, 2026 13:56

Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…
579df3c
… MaybeLocal<Promise>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 18, 2026

caiolima commented Aug 18, 2026
View reviewed changes

joyeecheung reviewed Aug 18, 2026
View reviewed changes

joyeecheung approved these changes Aug 18, 2026
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

caiolima added 3 commits August 17, 2026 13:56

Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…
579df3c
… MaybeLocal<Promise>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 18, 2026

caiolima commented Aug 18, 2026
View reviewed changes

joyeecheung reviewed Aug 18, 2026
View reviewed changes

joyeecheung approved these changes Aug 18, 2026
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

caiolima added 3 commits August 17, 2026 13:56

Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…
579df3c
… MaybeLocal<Promise>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 18, 2026

caiolima commented Aug 18, 2026
View reviewed changes

joyeecheung reviewed Aug 18, 2026
View reviewed changes

joyeecheung approved these changes Aug 18, 2026
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

caiolima added 3 commits August 17, 2026 13:56

Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…
579df3c
… MaybeLocal<Promise>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 18, 2026

caiolima commented Aug 18, 2026
View reviewed changes

joyeecheung reviewed Aug 18, 2026
View reviewed changes

joyeecheung approved these changes Aug 18, 2026
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

caiolima added 3 commits August 17, 2026 13:56

Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…
579df3c
… MaybeLocal<Promise>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 18, 2026

caiolima commented Aug 18, 2026
View reviewed changes

joyeecheung reviewed Aug 18, 2026
View reviewed changes

joyeecheung approved these changes Aug 18, 2026
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

caiolima added 3 commits August 17, 2026 13:56

Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…
579df3c
… MaybeLocal<Promise>

nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 18, 2026

caiolima commented Aug 18, 2026
View reviewed changes

joyeecheung reviewed Aug 18, 2026
View reviewed changes

joyeecheung approved these changes Aug 18, 2026
View reviewed changes

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2026

Uh oh!

Uh oh!

Conversation

caiolima commented Aug 18, 2026

Uh oh!

nodejs-github-bot commented Aug 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Aug 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

caiolima commented Aug 18, 2026

Uh oh!

joyeecheungAug 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 18, 2026

Uh oh!

joyeecheung commented Sep 3, 2026

Uh oh!

caiolima commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

caiolima commented Aug 18, 2026

Uh oh!

nodejs-github-bot commented Aug 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Aug 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

caiolima commented Aug 18, 2026

Uh oh!

joyeecheungAug 18, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 18, 2026

Uh oh!

joyeecheung commented Sep 3, 2026

Uh oh!

caiolima commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

caiolima commented Aug 18, 2026

Uh oh!

nodejs-github-bot commented Aug 18, 2026

codecovBot commented Aug 18, 2026•
edited
Loading

joyeecheungAug 18, 2026•
edited
Loading

codecovBot commented Aug 18, 2026•
edited
Loading

joyeecheungAug 18, 2026•
edited
Loading

codecovBot commented Aug 18, 2026•
edited
Loading

joyeecheungAug 18, 2026•
edited
Loading