Uh oh!
There was an error while loading. Please reload this page.
deps: update V8 to 15.2 - #65161
Conversation
Review requested:
|
targos
commented
Aug 9, 2026
I guess this is blocked by #64408 (https://github.com/nodejs/node/actions/runs/31307061482/job/93228984418?pr=65161) |
joyeecheung
commented
Aug 10, 2026
Uploaded https://chromium-review.googlesource.com/c/v8/v8/+/8223266 to fix the Linux AArch64 build (haven't tested on real Linux AArch64 yet, but that's what the error message suggests) |
GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs/node#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230}
Original commit message: [simd] Disable SVE implementation of array search for GCC GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230} Refs: v8/v8@68cf9ec
richardlau
commented
Aug 13, 2026
FWIW https://chromium-review.googlesource.com/c/v8/v8/+/8236132 was opened by @sravani1510 to address the AIX build failure that is occurring on our V8 nightly builds. |
targos
commented
Aug 13, 2026
@nodejs/platform-windows We're hitting a weird error on Windows: https://github.com/nodejs/node/actions/runs/31699320590/job/94444346312?pr=65161 This wrong path doesn't exist in the code. |
targos
commented
Aug 13, 2026
@legendecas Can you help with the perfetto build? |
legendecas
commented
Aug 14, 2026
Fixed the perfetto build. But I think the CI is failing for tests in large pages. Likely not related. |
targos
commented
Aug 14, 2026
Thanks. Summary of the remaining issues in GitHub CI: I'll start a Jenkins CI for more coverage. |
nodejs-github-bot
commented
Aug 14, 2026
nodejs-github-bot
commented
Aug 14, 2026
richardlau
commented
Aug 14, 2026
Been talking to @miladfarca about this: The Linux ppc64le and s390x machines being tested on have 8GB RAM and this test is allocating 16GB. |
miladfarca
commented
Aug 14, 2026
Patched it here: https://crrev.com/c/8252113 |
joyeecheung
commented
Aug 19, 2026
For the SEA test failures: they should not have run in the first place. #63751 should fix it. |
joyeecheung
commented
Aug 20, 2026
This should fix the alpine failures https://chromium-review.googlesource.com/c/v8/v8/+/8254825 |
For most libcs, pthread_getattr_np() returns the the stack reserved limit on the main thread, but musl only returns the current high-water mark at the time of the call. There's no macro to detect musl, so just fallback to the conservative stack limit in cases where the libc is not one that is known to work. Refs: nodejs/node#65161 Change-Id: Ie2b51269b9e8d2d3451d5d68ad1a233d396af935 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8254825 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109406}
Original commit message: [simd] Disable SVE implementation of array search for GCC GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230} Refs: v8/v8@68cf9ec
Original commit message: [simd] Disable SVE implementation of array search for GCC GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230} Refs: v8/v8@68cf9ec
Co-Authored-By: Joyee Cheung <joyeec9h3@gmail.com> Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Post-mortem libraries should use v8's debug_helper library instead.
- Set/GetPrototype - Holder Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
ICU_UTIL_DATA_SHARED had been removed since https://crrev.com/c/1513615, but Node.js still defined it and relied on the removed path on Windows, so the ICU initialization in mksnapshot had been silently failing since then. https://crrev.com/c/7679153 made the failure visible so the build started breaking on Windows. Fix it by always using ICU_UTIL_DATA_STATIC since we already compile the ICU data statically in. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
V8 bumped its wire-format version from 0x0f to 0x10. Update the expected hex in test-v8-serdes, and derive the v8 header bytes dynamically in test-runner-v8-deserializer so it tracks future bumps automatically. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
V8 no longer supports JSON.parse on worker isolates while the shared string table is enabled. Since --harmony-struct enables that table and Node workers parse process.config during bootstrap, use direct MessageChannel instead of a worker. Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Original commit message: [platform][posix] Fallback to conservative stack limit on musl For most libcs, pthread_getattr_np() returns the the stack reserved limit on the main thread, but musl only returns the current high-water mark at the time of the call. There's no macro to detect musl, so just fallback to the conservative stack limit in cases where the libc is not one that is known to work. Refs: nodejs#65161 Change-Id: Ie2b51269b9e8d2d3451d5d68ad1a233d396af935 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8254825 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109406} Refs: v8/v8@ba4ef8d
Original commit message: Skip regress-498816446-3 when there is not enough memory Currently causing a test failure on a machine with 8Gb of memory: ``` regress-498816446-3.js:25: RangeError: Array buffer allocation failed ``` Change-Id: I9e0396445c0b870d0070d666f9d6081b93e80f9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8252113 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#109426} Refs: v8/v8@811fe8b
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
nodejs-github-bot
commented
Sep 1, 2026
aduh95
commented
Sep 2, 2026
Test failing across multiple platforms: |
targos
commented
Sep 2, 2026
Just recompiled the branch. On my computer (macOS) it no longer prints the error and stack trace there's just: |
joyeecheung
commented
Sep 2, 2026
Looks like a regression from #65589 |
joyeecheung
commented
Sep 2, 2026
Looks like it's caused by https://chromium-review.googlesource.com/c/v8/v8/+/7705483, we should configure V8_LOGGING_LEVEL in gyp so that it prints something when CHECK fails. |
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
commented
Sep 2, 2026
Pushed #65744 to this branch to check how the CI responds.. |
Refs: #64784