fs: validate copyFile paths in the existing C++ binding#65376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonrig wants to merge 2 commits into
base:main
Choose a base branch
from
Open

fs: validate copyFile paths in the existing C++ binding #65376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4dc3a1
fs: implement copyFileSync in C++
anonrig Aug 18, 2026
0fcda9b
fs: validate copyFile paths in the existing C++ binding
cursoragent Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions lib/fs.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3659,8 +3659,6 @@ function copyFile(src, dest, mode, callback) {
const h = vfsState.handlers;
if (h !== null && vfsVoid(h.copyFile(src, dest, mode), callback)) return;

src = getValidatedPath(src, 'src');
dest = getValidatedPath(dest, 'dest');
callback = makeCallback(callback);

const req = new FSReqCallback();
Expand All@@ -3682,11 +3680,7 @@ function copyFileSync(src, dest, mode) {
const result = h.copyFileSync(src, dest, mode);
if (result !== undefined) return;
}
binding.copyFile(
getValidatedPath(src, 'src'),
getValidatedPath(dest, 'dest'),
mode,
);
binding.copyFile(src, dest, mode);
}

/**
Expand Down
7 changes: 1 addition & 6 deletions lib/internal/fs/promises.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1335,12 +1335,7 @@ async function copyFile(src, dest, mode) {
if (promise !== undefined) { await promise; return; }
}
return await PromisePrototypeThen(
binding.copyFile(
getValidatedPath(src, 'src'),
getValidatedPath(dest, 'dest'),
mode,
kUsePromises,
),
binding.copyFile(src, dest, mode, kUsePromises),
undefined,
handleErrorFromBinding,
);
Expand Down
162 changes: 156 additions & 6 deletions src/node_file.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
#include <errno.h>
#include <cerrno>
#include <cstdio>
#include <cstring>
#include <filesystem>

#if defined(__MINGW32__) || defined(_MSC_VER)
Expand DownExpand Up@@ -77,6 +78,7 @@ using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Nothing;
using v8::Number;
using v8::Object;
Expand DownExpand Up@@ -2416,24 +2418,172 @@ static void OpenFileHandle(const FunctionCallbackInfo<Value>& args) {
}
}

// Matches lib/internal/url.js isURL(): duck-type WHATWG URL objects vs
// legacy url.parse() results (which have `auth` and `path` properties).
static bool IsUrlLike(Environment* env, Local<Value> value) {
if (!value->IsObject() || value->IsUint8Array()) {
return false;
}

Isolate* isolate = env->isolate();
Local<Context> context = env->context();
Local<Object> obj = value.As<Object>();

Local<Value> href;
if (!obj->Get(context, env->href_string()).ToLocal(&href)) {
return false;
}
if (!href->BooleanValue(isolate)) {
return false;
}

Local<Value> protocol;
if (!obj->Get(context, env->protocol_string()).ToLocal(&protocol)) {
return false;
}
if (!protocol->BooleanValue(isolate)) {
return false;
}

Local<Value> auth;
if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "auth"))
.ToLocal(&auth)) {
return false;
}

Local<Value> path;
if (!obj->Get(context, env->path_string()).ToLocal(&path)) {
return false;
}

return auth->IsUndefined() && path->IsUndefined();
}

static bool ContainsNul(const BufferValue& path) {
return path.length() > 0 &&
std::memchr(path.out(), '\0', path.length()) != nullptr;
}

// C++ equivalent of getValidatedPath(value, propName), used by CopyFile for
// the sync, callback, and promises paths. Accepts string, Uint8Array/Buffer,
// or WHATWG URL, rejects embedded NUL bytes, and converts file: URLs to
// paths. Returns an empty MaybeLocal and throws on failure.
static MaybeLocal<Value> GetValidatedPath(Environment* env,
Local<Value> input,
const char* prop_name) {
Isolate* isolate = env->isolate();

if (input->IsString() || input->IsUint8Array()) {
return input;
}

if (IsUrlLike(env, input)) {
Local<Context> context = env->context();
Local<Value> href;
if (!input.As<Object>()->Get(context, env->href_string()).ToLocal(&href)) {
return MaybeLocal<Value>();
}

Utf8Value href_utf8(isolate, href);
auto parsed = ada::parse<ada::url_aggregator>(href_utf8.ToStringView());
if (!parsed) {
url::ThrowInvalidURL(env, href_utf8.ToStringView(), std::nullopt);
return MaybeLocal<Value>();
}

// Match lib/internal/url.js fileURLToPath(): non-file schemes throw
// ERR_INVALID_URL_SCHEME with the same message as JS (`file`, not `file:`).
if (parsed->type != ada::scheme::FILE) {
THROW_ERR_INVALID_URL_SCHEME(isolate, "The URL must be of scheme file");
return MaybeLocal<Value>();
}

std::optional<std::string> file_path = url::FileURLToPath(env, *parsed);
if (!file_path.has_value()) {
return MaybeLocal<Value>();
}

if (file_path->find('\0') != std::string::npos) {
THROW_ERR_INVALID_ARG_VALUE(
env,
"The argument '%s' must be a string, Uint8Array, or URL "
"without null bytes. Received %s",
prop_name,
DetermineSpecificErrorType(env, input));
return MaybeLocal<Value>();
}

Local<String> path_string;
if (!String::NewFromUtf8(isolate,
file_path->data(),
NewStringType::kNormal,
static_cast<int>(file_path->size()))
.ToLocal(&path_string)) {
return MaybeLocal<Value>();
}
return path_string;
}

if (isolate->HasPendingException()) {
return MaybeLocal<Value>();
}

THROW_ERR_INVALID_ARG_TYPE(
env,
"The \"%s\" argument must be of type string or an instance of "
"Buffer or URL. Received %s",
prop_name,
DetermineSpecificErrorType(env, input));
return MaybeLocal<Value>();
}

// Shared by the sync, callback, and promises copyFile paths. Path validation
// (string / Uint8Array / file: URL, NUL checks) happens here so JS callers
// can pass the original arguments through.
static void CopyFile(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
Isolate* isolate = env->isolate();

const int argc = args.Length();
CHECK_GE(argc, 3); // src, dest, flags
CHECK_GE(argc, 3); // src, dest, flags[, req]

int flags;
if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
Local<Value> src_val;
if (!GetValidatedPath(env, args[0], "src").ToLocal(&src_val)) {
return;
}
Local<Value> dest_val;
if (!GetValidatedPath(env, args[1], "dest").ToLocal(&dest_val)) {
return;
}

BufferValue src(isolate, args[0]);
BufferValue src(isolate, src_val);
CHECK_NOT_NULL(*src);
ToNamespacedPath(env, &src);
if (ContainsNul(src)) {
THROW_ERR_INVALID_ARG_VALUE(
env,
"The argument 'src' must be a string, Uint8Array, or URL "
"without null bytes. Received %s",
DetermineSpecificErrorType(env, args[0]));
return;
}

BufferValue dest(isolate, args[1]);
BufferValue dest(isolate, dest_val);
CHECK_NOT_NULL(*dest);
if (ContainsNul(dest)) {
THROW_ERR_INVALID_ARG_VALUE(
env,
"The argument 'dest' must be a string, Uint8Array, or URL "
"without null bytes. Received %s",
DetermineSpecificErrorType(env, args[1]));
return;
}

int flags;
if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
return;
}

ToNamespacedPath(env, &src);
ToNamespacedPath(env, &dest);

if (argc > 3) { // copyFile(src, dest, flags, req)
Expand Down
2 changes: 1 addition & 1 deletion src/node_url.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -688,7 +688,7 @@ std::optional<std::string> FileURLToPath(Environment* env,
if (hostname.size() > 0) {
THROW_ERR_INVALID_FILE_URL_HOST(
env->isolate(),
"File URL host must be \"localhost\" or empty on ",
"File URL host must be \"localhost\" or empty on %s",
std::string(per_process::metadata.platform));
return std::nullopt;
}
Expand Down
62 changes: 62 additions & 0 deletions test/parallel/test-fs-copyfile.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ const {
UV_ENOENT,
UV_EEXIST
} = internalBinding('uv');
const { pathToFileURL } = require('url');
const src = fixtures.path('a.js');
const dest = tmpdir.resolve('copyfile.out');
const {
Expand DownExpand Up@@ -55,6 +56,22 @@ verify(src, dest);
fs.copyFileSync(src, dest, 0);
verify(src, dest);

// Verify Buffer and file: URL paths.
{
const destBuf = tmpdir.resolve('copyfile.buffer');
fs.copyFileSync(Buffer.from(src), Buffer.from(destBuf));
verify(src, destBuf);

const destUrl = tmpdir.resolve('copyfile.url');
fs.copyFileSync(pathToFileURL(src), pathToFileURL(destUrl));
verify(src, destUrl);

const destU8 = tmpdir.resolve('copyfile.uint8');
fs.copyFileSync(new Uint8Array(Buffer.from(src)),
new Uint8Array(Buffer.from(destU8)));
verify(src, destU8);
}

// Verify that UV_FS_COPYFILE_FICLONE can be used.
fs.unlinkSync(dest);
fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
Expand DownExpand Up@@ -142,6 +159,51 @@ assert.throws(() => {
);
});

assert.throws(() => {
fs.copyFileSync(new URL('http://example.com/a'), dest);
}, {
code: 'ERR_INVALID_URL_SCHEME',
name: 'TypeError',
message: 'The URL must be of scheme file',
});

assert.throws(() => {
fs.copyFile(new URL('http://example.com/a'), dest, common.mustNotCall());
}, {
code: 'ERR_INVALID_URL_SCHEME',
name: 'TypeError',
message: 'The URL must be of scheme file',
});

if (common.isWindows) {
['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
assert.throws(
() => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
{
code: 'ERR_INVALID_FILE_URL_PATH',
name: 'TypeError',
}
);
});
} else {
['%2f', '%2F'].forEach((i) => {
assert.throws(
() => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
{
code: 'ERR_INVALID_FILE_URL_PATH',
name: 'TypeError',
}
);
});
assert.throws(
() => fs.copyFileSync(new URL('file://hostname/a/b/c'), dest),
{
code: 'ERR_INVALID_FILE_URL_HOST',
name: 'TypeError',
}
);
}

assert.throws(() => {
fs.copyFileSync(src, dest, 'r');
}, {
Expand Down
7 changes: 4 additions & 3 deletions typings/internalBinding/fs.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,9 +72,10 @@ declare namespace InternalFSBinding {
function close(fd: number, req: FSReqCallback): void;
function close(fd: number): void;

function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: FSReqCallback): void;
function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: undefined, ctx: FSSyncContext): void;
function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, usePromises: typeof kUsePromises): Promise<void>;
function copyFile(src: unknown, dest: unknown, mode?: unknown): void;
function copyFile(src: unknown, dest: unknown, mode: unknown, req: FSReqCallback): void;
function copyFile(src: unknown, dest: unknown, mode: unknown, req: undefined, ctx: FSSyncContext): void;
function copyFile(src: unknown, dest: unknown, mode: unknown, usePromises: typeof kUsePromises): Promise<void>;

function cpSyncCheckPaths(src: StringOrBuffer, dest: StringOrBuffer, dereference: boolean, recursive: boolean): void;
function cpSyncOverrideFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, preserveTimestamps: boolean): void;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fs: validate copyFile paths in the existing C++ binding#65376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

anonrig
wants to merge
2
commits into

base:main
Choose a base branch

from

 Open


fs: validate copyFile paths in the existing C++ binding
#65376
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e4dc3a1

fs: implement copyFileSync in C++


anonrig Aug 18, 2026
0fcda9b

fs: validate copyFile paths in the existing C++ binding


cursoragent Aug 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 1 addition & 7 deletions
lib/fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3659,8 +3659,6 @@ function copyFile(src, dest, mode, callback) {
 const h = vfsState.handlers;
 if (h !== null && vfsVoid(h.copyFile(src, dest, mode), callback)) return;

 src = getValidatedPath(src, 'src');
 dest = getValidatedPath(dest, 'dest');
 callback = makeCallback(callback);

 const req = new FSReqCallback();
Expand All@@ -3682,11 +3680,7 @@ function copyFileSync(src, dest, mode) {
 const result = h.copyFileSync(src, dest, mode);
 if (result !== undefined) return;
 }
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 );
 binding.copyFile(src, dest, mode);
}

/**
Expand Down

7 changes: 1 addition & 6 deletions
lib/internal/fs/promises.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1335,12 +1335,7 @@ async function copyFile(src, dest, mode) {
 if (promise !== undefined) { await promise; return; }
 }
 return await PromisePrototypeThen(
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 kUsePromises,
 ),
 binding.copyFile(src, dest, mode, kUsePromises),
 undefined,
 handleErrorFromBinding,
 );
Expand Down

162 changes: 156 additions & 6 deletions
src/node_file.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
#include <errno.h>
#include <cerrno>
#include <cstdio>
#include <cstring>
#include <filesystem>

#if defined(__MINGW32__) || defined(_MSC_VER)
Expand DownExpand Up@@ -77,6 +78,7 @@ using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Nothing;
using v8::Number;
using v8::Object;
Expand DownExpand Up@@ -2416,24 +2418,172 @@ static void OpenFileHandle(const FunctionCallbackInfo<Value>& args) {
 }
}

// Matches lib/internal/url.js isURL(): duck-type WHATWG URL objects vs
// legacy url.parse() results (which have `auth` and `path` properties).
static bool IsUrlLike(Environment* env, Local<Value> value) {
 if (!value->IsObject() || value->IsUint8Array()) {
 return false;
 }

 Isolate* isolate = env->isolate();
 Local<Context> context = env->context();
 Local<Object> obj = value.As<Object>();

 Local<Value> href;
 if (!obj->Get(context, env->href_string()).ToLocal(&href)) {
 return false;
 }
 if (!href->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> protocol;
 if (!obj->Get(context, env->protocol_string()).ToLocal(&protocol)) {
 return false;
 }
 if (!protocol->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> auth;
 if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "auth"))
 .ToLocal(&auth)) {
 return false;
 }

 Local<Value> path;
 if (!obj->Get(context, env->path_string()).ToLocal(&path)) {
 return false;
 }

 return auth->IsUndefined() && path->IsUndefined();
}

static bool ContainsNul(const BufferValue& path) {
 return path.length() > 0 &&
 std::memchr(path.out(), '\0', path.length()) != nullptr;
}

// C++ equivalent of getValidatedPath(value, propName), used by CopyFile for
// the sync, callback, and promises paths. Accepts string, Uint8Array/Buffer,
// or WHATWG URL, rejects embedded NUL bytes, and converts file: URLs to
// paths. Returns an empty MaybeLocal and throws on failure.
static MaybeLocal<Value> GetValidatedPath(Environment* env,
 Local<Value> input,
 const char* prop_name) {
 Isolate* isolate = env->isolate();

 if (input->IsString() || input->IsUint8Array()) {
 return input;
 }

 if (IsUrlLike(env, input)) {
 Local<Context> context = env->context();
 Local<Value> href;
 if (!input.As<Object>()->Get(context, env->href_string()).ToLocal(&href)) {
 return MaybeLocal<Value>();
 }

 Utf8Value href_utf8(isolate, href);
 auto parsed = ada::parse<ada::url_aggregator>(href_utf8.ToStringView());
 if (!parsed) {
 url::ThrowInvalidURL(env, href_utf8.ToStringView(), std::nullopt);
 return MaybeLocal<Value>();
 }

 // Match lib/internal/url.js fileURLToPath(): non-file schemes throw
 // ERR_INVALID_URL_SCHEME with the same message as JS (`file`, not `file:`).
 if (parsed->type != ada::scheme::FILE) {
 THROW_ERR_INVALID_URL_SCHEME(isolate, "The URL must be of scheme file");
 return MaybeLocal<Value>();
 }

 std::optional<std::string> file_path = url::FileURLToPath(env, *parsed);
 if (!file_path.has_value()) {
 return MaybeLocal<Value>();
 }

 if (file_path->find('\0') != std::string::npos) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument '%s' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
 }

 Local<String> path_string;
 if (!String::NewFromUtf8(isolate,
 file_path->data(),
 NewStringType::kNormal,
 static_cast<int>(file_path->size()))
 .ToLocal(&path_string)) {
 return MaybeLocal<Value>();
 }
 return path_string;
 }

 if (isolate->HasPendingException()) {
 return MaybeLocal<Value>();
 }

 THROW_ERR_INVALID_ARG_TYPE(
 env,
 "The \"%s\" argument must be of type string or an instance of "
 "Buffer or URL. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
}

// Shared by the sync, callback, and promises copyFile paths. Path validation
// (string / Uint8Array / file: URL, NUL checks) happens here so JS callers
// can pass the original arguments through.
static void CopyFile(const FunctionCallbackInfo<Value>& args) {
 Environment* env = Environment::GetCurrent(args);
 Isolate* isolate = env->isolate();

 const int argc = args.Length();
 CHECK_GE(argc, 3); // src, dest, flags
 CHECK_GE(argc, 3); // src, dest, flags[, req]

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 Local<Value> src_val;
 if (!GetValidatedPath(env, args[0], "src").ToLocal(&src_val)) {
 return;
 }
 Local<Value> dest_val;
 if (!GetValidatedPath(env, args[1], "dest").ToLocal(&dest_val)) {
 return;
 }

 BufferValue src(isolate, args[0]);
 BufferValue src(isolate, src_val);
 CHECK_NOT_NULL(*src);
 ToNamespacedPath(env, &src);
 if (ContainsNul(src)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'src' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[0]));
 return;
 }

 BufferValue dest(isolate, args[1]);
 BufferValue dest(isolate, dest_val);
 CHECK_NOT_NULL(*dest);
 if (ContainsNul(dest)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'dest' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[1]));
 return;
 }

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 return;
 }

 ToNamespacedPath(env, &src);
 ToNamespacedPath(env, &dest);

 if (argc > 3) { // copyFile(src, dest, flags, req)
Expand Down

2 changes: 1 addition & 1 deletion
src/node_url.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -688,7 +688,7 @@ std::optional<std::string> FileURLToPath(Environment* env,
 if (hostname.size() > 0) {
 THROW_ERR_INVALID_FILE_URL_HOST(
 env->isolate(),
 "File URL host must be \"localhost\" or empty on ",
 "File URL host must be \"localhost\" or empty on %s",
 std::string(per_process::metadata.platform));
 return std::nullopt;
 }
Expand Down

62 changes: 62 additions & 0 deletions
test/parallel/test-fs-copyfile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ const {
 UV_ENOENT,
 UV_EEXIST
} = internalBinding('uv');
const { pathToFileURL } = require('url');
const src = fixtures.path('a.js');
const dest = tmpdir.resolve('copyfile.out');
const {
Expand DownExpand Up@@ -55,6 +56,22 @@ verify(src, dest);
fs.copyFileSync(src, dest, 0);
verify(src, dest);

// Verify Buffer and file: URL paths.
{
 const destBuf = tmpdir.resolve('copyfile.buffer');
 fs.copyFileSync(Buffer.from(src), Buffer.from(destBuf));
 verify(src, destBuf);

 const destUrl = tmpdir.resolve('copyfile.url');
 fs.copyFileSync(pathToFileURL(src), pathToFileURL(destUrl));
 verify(src, destUrl);

 const destU8 = tmpdir.resolve('copyfile.uint8');
 fs.copyFileSync(new Uint8Array(Buffer.from(src)),
 new Uint8Array(Buffer.from(destU8)));
 verify(src, destU8);
}

// Verify that UV_FS_COPYFILE_FICLONE can be used.
fs.unlinkSync(dest);
fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
Expand DownExpand Up@@ -142,6 +159,51 @@ assert.throws(() => {
 );
});

assert.throws(() => {
 fs.copyFileSync(new URL('http://example.com/a'), dest);
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

assert.throws(() => {
 fs.copyFile(new URL('http://example.com/a'), dest, common.mustNotCall());
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

if (common.isWindows) {
 ['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
} else {
 ['%2f', '%2F'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
 assert.throws(
 () => fs.copyFileSync(new URL('file://hostname/a/b/c'), dest),
 {
 code: 'ERR_INVALID_FILE_URL_HOST',
 name: 'TypeError',
 }
 );
}

assert.throws(() => {
 fs.copyFileSync(src, dest, 'r');
}, {
Expand Down

7 changes: 4 additions & 3 deletions
typings/internalBinding/fs.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,9 +72,10 @@ declare namespace InternalFSBinding {
 function close(fd: number, req: FSReqCallback): void;
 function close(fd: number): void;

 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: FSReqCallback): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, usePromises: typeof kUsePromises): Promise<void>;
 function copyFile(src: unknown, dest: unknown, mode?: unknown): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: FSReqCallback): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, usePromises: typeof kUsePromises): Promise<void>;

 function cpSyncCheckPaths(src: StringOrBuffer, dest: StringOrBuffer, dereference: boolean, recursive: boolean): void;
 function cpSyncOverrideFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, preserveTimestamps: boolean): void;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fs: validate copyFile paths in the existing C++ binding#65376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

anonrig
wants to merge
2
commits into

base:main
Choose a base branch

from

 Open


fs: validate copyFile paths in the existing C++ binding
#65376
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e4dc3a1

fs: implement copyFileSync in C++


anonrig Aug 18, 2026
0fcda9b

fs: validate copyFile paths in the existing C++ binding


cursoragent Aug 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 1 addition & 7 deletions
lib/fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3659,8 +3659,6 @@ function copyFile(src, dest, mode, callback) {
 const h = vfsState.handlers;
 if (h !== null && vfsVoid(h.copyFile(src, dest, mode), callback)) return;

 src = getValidatedPath(src, 'src');
 dest = getValidatedPath(dest, 'dest');
 callback = makeCallback(callback);

 const req = new FSReqCallback();
Expand All@@ -3682,11 +3680,7 @@ function copyFileSync(src, dest, mode) {
 const result = h.copyFileSync(src, dest, mode);
 if (result !== undefined) return;
 }
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 );
 binding.copyFile(src, dest, mode);
}

/**
Expand Down

7 changes: 1 addition & 6 deletions
lib/internal/fs/promises.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1335,12 +1335,7 @@ async function copyFile(src, dest, mode) {
 if (promise !== undefined) { await promise; return; }
 }
 return await PromisePrototypeThen(
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 kUsePromises,
 ),
 binding.copyFile(src, dest, mode, kUsePromises),
 undefined,
 handleErrorFromBinding,
 );
Expand Down

162 changes: 156 additions & 6 deletions
src/node_file.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
#include <errno.h>
#include <cerrno>
#include <cstdio>
#include <cstring>
#include <filesystem>

#if defined(__MINGW32__) || defined(_MSC_VER)
Expand DownExpand Up@@ -77,6 +78,7 @@ using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Nothing;
using v8::Number;
using v8::Object;
Expand DownExpand Up@@ -2416,24 +2418,172 @@ static void OpenFileHandle(const FunctionCallbackInfo<Value>& args) {
 }
}

// Matches lib/internal/url.js isURL(): duck-type WHATWG URL objects vs
// legacy url.parse() results (which have `auth` and `path` properties).
static bool IsUrlLike(Environment* env, Local<Value> value) {
 if (!value->IsObject() || value->IsUint8Array()) {
 return false;
 }

 Isolate* isolate = env->isolate();
 Local<Context> context = env->context();
 Local<Object> obj = value.As<Object>();

 Local<Value> href;
 if (!obj->Get(context, env->href_string()).ToLocal(&href)) {
 return false;
 }
 if (!href->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> protocol;
 if (!obj->Get(context, env->protocol_string()).ToLocal(&protocol)) {
 return false;
 }
 if (!protocol->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> auth;
 if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "auth"))
 .ToLocal(&auth)) {
 return false;
 }

 Local<Value> path;
 if (!obj->Get(context, env->path_string()).ToLocal(&path)) {
 return false;
 }

 return auth->IsUndefined() && path->IsUndefined();
}

static bool ContainsNul(const BufferValue& path) {
 return path.length() > 0 &&
 std::memchr(path.out(), '\0', path.length()) != nullptr;
}

// C++ equivalent of getValidatedPath(value, propName), used by CopyFile for
// the sync, callback, and promises paths. Accepts string, Uint8Array/Buffer,
// or WHATWG URL, rejects embedded NUL bytes, and converts file: URLs to
// paths. Returns an empty MaybeLocal and throws on failure.
static MaybeLocal<Value> GetValidatedPath(Environment* env,
 Local<Value> input,
 const char* prop_name) {
 Isolate* isolate = env->isolate();

 if (input->IsString() || input->IsUint8Array()) {
 return input;
 }

 if (IsUrlLike(env, input)) {
 Local<Context> context = env->context();
 Local<Value> href;
 if (!input.As<Object>()->Get(context, env->href_string()).ToLocal(&href)) {
 return MaybeLocal<Value>();
 }

 Utf8Value href_utf8(isolate, href);
 auto parsed = ada::parse<ada::url_aggregator>(href_utf8.ToStringView());
 if (!parsed) {
 url::ThrowInvalidURL(env, href_utf8.ToStringView(), std::nullopt);
 return MaybeLocal<Value>();
 }

 // Match lib/internal/url.js fileURLToPath(): non-file schemes throw
 // ERR_INVALID_URL_SCHEME with the same message as JS (`file`, not `file:`).
 if (parsed->type != ada::scheme::FILE) {
 THROW_ERR_INVALID_URL_SCHEME(isolate, "The URL must be of scheme file");
 return MaybeLocal<Value>();
 }

 std::optional<std::string> file_path = url::FileURLToPath(env, *parsed);
 if (!file_path.has_value()) {
 return MaybeLocal<Value>();
 }

 if (file_path->find('\0') != std::string::npos) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument '%s' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
 }

 Local<String> path_string;
 if (!String::NewFromUtf8(isolate,
 file_path->data(),
 NewStringType::kNormal,
 static_cast<int>(file_path->size()))
 .ToLocal(&path_string)) {
 return MaybeLocal<Value>();
 }
 return path_string;
 }

 if (isolate->HasPendingException()) {
 return MaybeLocal<Value>();
 }

 THROW_ERR_INVALID_ARG_TYPE(
 env,
 "The \"%s\" argument must be of type string or an instance of "
 "Buffer or URL. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
}

// Shared by the sync, callback, and promises copyFile paths. Path validation
// (string / Uint8Array / file: URL, NUL checks) happens here so JS callers
// can pass the original arguments through.
static void CopyFile(const FunctionCallbackInfo<Value>& args) {
 Environment* env = Environment::GetCurrent(args);
 Isolate* isolate = env->isolate();

 const int argc = args.Length();
 CHECK_GE(argc, 3); // src, dest, flags
 CHECK_GE(argc, 3); // src, dest, flags[, req]

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 Local<Value> src_val;
 if (!GetValidatedPath(env, args[0], "src").ToLocal(&src_val)) {
 return;
 }
 Local<Value> dest_val;
 if (!GetValidatedPath(env, args[1], "dest").ToLocal(&dest_val)) {
 return;
 }

 BufferValue src(isolate, args[0]);
 BufferValue src(isolate, src_val);
 CHECK_NOT_NULL(*src);
 ToNamespacedPath(env, &src);
 if (ContainsNul(src)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'src' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[0]));
 return;
 }

 BufferValue dest(isolate, args[1]);
 BufferValue dest(isolate, dest_val);
 CHECK_NOT_NULL(*dest);
 if (ContainsNul(dest)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'dest' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[1]));
 return;
 }

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 return;
 }

 ToNamespacedPath(env, &src);
 ToNamespacedPath(env, &dest);

 if (argc > 3) { // copyFile(src, dest, flags, req)
Expand Down

2 changes: 1 addition & 1 deletion
src/node_url.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -688,7 +688,7 @@ std::optional<std::string> FileURLToPath(Environment* env,
 if (hostname.size() > 0) {
 THROW_ERR_INVALID_FILE_URL_HOST(
 env->isolate(),
 "File URL host must be \"localhost\" or empty on ",
 "File URL host must be \"localhost\" or empty on %s",
 std::string(per_process::metadata.platform));
 return std::nullopt;
 }
Expand Down

62 changes: 62 additions & 0 deletions
test/parallel/test-fs-copyfile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ const {
 UV_ENOENT,
 UV_EEXIST
} = internalBinding('uv');
const { pathToFileURL } = require('url');
const src = fixtures.path('a.js');
const dest = tmpdir.resolve('copyfile.out');
const {
Expand DownExpand Up@@ -55,6 +56,22 @@ verify(src, dest);
fs.copyFileSync(src, dest, 0);
verify(src, dest);

// Verify Buffer and file: URL paths.
{
 const destBuf = tmpdir.resolve('copyfile.buffer');
 fs.copyFileSync(Buffer.from(src), Buffer.from(destBuf));
 verify(src, destBuf);

 const destUrl = tmpdir.resolve('copyfile.url');
 fs.copyFileSync(pathToFileURL(src), pathToFileURL(destUrl));
 verify(src, destUrl);

 const destU8 = tmpdir.resolve('copyfile.uint8');
 fs.copyFileSync(new Uint8Array(Buffer.from(src)),
 new Uint8Array(Buffer.from(destU8)));
 verify(src, destU8);
}

// Verify that UV_FS_COPYFILE_FICLONE can be used.
fs.unlinkSync(dest);
fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
Expand DownExpand Up@@ -142,6 +159,51 @@ assert.throws(() => {
 );
});

assert.throws(() => {
 fs.copyFileSync(new URL('http://example.com/a'), dest);
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

assert.throws(() => {
 fs.copyFile(new URL('http://example.com/a'), dest, common.mustNotCall());
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

if (common.isWindows) {
 ['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
} else {
 ['%2f', '%2F'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
 assert.throws(
 () => fs.copyFileSync(new URL('file://hostname/a/b/c'), dest),
 {
 code: 'ERR_INVALID_FILE_URL_HOST',
 name: 'TypeError',
 }
 );
}

assert.throws(() => {
 fs.copyFileSync(src, dest, 'r');
}, {
Expand Down

7 changes: 4 additions & 3 deletions
typings/internalBinding/fs.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,9 +72,10 @@ declare namespace InternalFSBinding {
 function close(fd: number, req: FSReqCallback): void;
 function close(fd: number): void;

 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: FSReqCallback): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, usePromises: typeof kUsePromises): Promise<void>;
 function copyFile(src: unknown, dest: unknown, mode?: unknown): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: FSReqCallback): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, usePromises: typeof kUsePromises): Promise<void>;

 function cpSyncCheckPaths(src: StringOrBuffer, dest: StringOrBuffer, dereference: boolean, recursive: boolean): void;
 function cpSyncOverrideFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, preserveTimestamps: boolean): void;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fs: validate copyFile paths in the existing C++ binding#65376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

anonrig
wants to merge
2
commits into

base:main
Choose a base branch

from

 Open


fs: validate copyFile paths in the existing C++ binding
#65376
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e4dc3a1

fs: implement copyFileSync in C++


anonrig Aug 18, 2026
0fcda9b

fs: validate copyFile paths in the existing C++ binding


cursoragent Aug 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 1 addition & 7 deletions
lib/fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3659,8 +3659,6 @@ function copyFile(src, dest, mode, callback) {
 const h = vfsState.handlers;
 if (h !== null && vfsVoid(h.copyFile(src, dest, mode), callback)) return;

 src = getValidatedPath(src, 'src');
 dest = getValidatedPath(dest, 'dest');
 callback = makeCallback(callback);

 const req = new FSReqCallback();
Expand All@@ -3682,11 +3680,7 @@ function copyFileSync(src, dest, mode) {
 const result = h.copyFileSync(src, dest, mode);
 if (result !== undefined) return;
 }
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 );
 binding.copyFile(src, dest, mode);
}

/**
Expand Down

7 changes: 1 addition & 6 deletions
lib/internal/fs/promises.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1335,12 +1335,7 @@ async function copyFile(src, dest, mode) {
 if (promise !== undefined) { await promise; return; }
 }
 return await PromisePrototypeThen(
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 kUsePromises,
 ),
 binding.copyFile(src, dest, mode, kUsePromises),
 undefined,
 handleErrorFromBinding,
 );
Expand Down

162 changes: 156 additions & 6 deletions
src/node_file.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
#include <errno.h>
#include <cerrno>
#include <cstdio>
#include <cstring>
#include <filesystem>

#if defined(__MINGW32__) || defined(_MSC_VER)
Expand DownExpand Up@@ -77,6 +78,7 @@ using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Nothing;
using v8::Number;
using v8::Object;
Expand DownExpand Up@@ -2416,24 +2418,172 @@ static void OpenFileHandle(const FunctionCallbackInfo<Value>& args) {
 }
}

// Matches lib/internal/url.js isURL(): duck-type WHATWG URL objects vs
// legacy url.parse() results (which have `auth` and `path` properties).
static bool IsUrlLike(Environment* env, Local<Value> value) {
 if (!value->IsObject() || value->IsUint8Array()) {
 return false;
 }

 Isolate* isolate = env->isolate();
 Local<Context> context = env->context();
 Local<Object> obj = value.As<Object>();

 Local<Value> href;
 if (!obj->Get(context, env->href_string()).ToLocal(&href)) {
 return false;
 }
 if (!href->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> protocol;
 if (!obj->Get(context, env->protocol_string()).ToLocal(&protocol)) {
 return false;
 }
 if (!protocol->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> auth;
 if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "auth"))
 .ToLocal(&auth)) {
 return false;
 }

 Local<Value> path;
 if (!obj->Get(context, env->path_string()).ToLocal(&path)) {
 return false;
 }

 return auth->IsUndefined() && path->IsUndefined();
}

static bool ContainsNul(const BufferValue& path) {
 return path.length() > 0 &&
 std::memchr(path.out(), '\0', path.length()) != nullptr;
}

// C++ equivalent of getValidatedPath(value, propName), used by CopyFile for
// the sync, callback, and promises paths. Accepts string, Uint8Array/Buffer,
// or WHATWG URL, rejects embedded NUL bytes, and converts file: URLs to
// paths. Returns an empty MaybeLocal and throws on failure.
static MaybeLocal<Value> GetValidatedPath(Environment* env,
 Local<Value> input,
 const char* prop_name) {
 Isolate* isolate = env->isolate();

 if (input->IsString() || input->IsUint8Array()) {
 return input;
 }

 if (IsUrlLike(env, input)) {
 Local<Context> context = env->context();
 Local<Value> href;
 if (!input.As<Object>()->Get(context, env->href_string()).ToLocal(&href)) {
 return MaybeLocal<Value>();
 }

 Utf8Value href_utf8(isolate, href);
 auto parsed = ada::parse<ada::url_aggregator>(href_utf8.ToStringView());
 if (!parsed) {
 url::ThrowInvalidURL(env, href_utf8.ToStringView(), std::nullopt);
 return MaybeLocal<Value>();
 }

 // Match lib/internal/url.js fileURLToPath(): non-file schemes throw
 // ERR_INVALID_URL_SCHEME with the same message as JS (`file`, not `file:`).
 if (parsed->type != ada::scheme::FILE) {
 THROW_ERR_INVALID_URL_SCHEME(isolate, "The URL must be of scheme file");
 return MaybeLocal<Value>();
 }

 std::optional<std::string> file_path = url::FileURLToPath(env, *parsed);
 if (!file_path.has_value()) {
 return MaybeLocal<Value>();
 }

 if (file_path->find('\0') != std::string::npos) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument '%s' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
 }

 Local<String> path_string;
 if (!String::NewFromUtf8(isolate,
 file_path->data(),
 NewStringType::kNormal,
 static_cast<int>(file_path->size()))
 .ToLocal(&path_string)) {
 return MaybeLocal<Value>();
 }
 return path_string;
 }

 if (isolate->HasPendingException()) {
 return MaybeLocal<Value>();
 }

 THROW_ERR_INVALID_ARG_TYPE(
 env,
 "The \"%s\" argument must be of type string or an instance of "
 "Buffer or URL. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
}

// Shared by the sync, callback, and promises copyFile paths. Path validation
// (string / Uint8Array / file: URL, NUL checks) happens here so JS callers
// can pass the original arguments through.
static void CopyFile(const FunctionCallbackInfo<Value>& args) {
 Environment* env = Environment::GetCurrent(args);
 Isolate* isolate = env->isolate();

 const int argc = args.Length();
 CHECK_GE(argc, 3); // src, dest, flags
 CHECK_GE(argc, 3); // src, dest, flags[, req]

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 Local<Value> src_val;
 if (!GetValidatedPath(env, args[0], "src").ToLocal(&src_val)) {
 return;
 }
 Local<Value> dest_val;
 if (!GetValidatedPath(env, args[1], "dest").ToLocal(&dest_val)) {
 return;
 }

 BufferValue src(isolate, args[0]);
 BufferValue src(isolate, src_val);
 CHECK_NOT_NULL(*src);
 ToNamespacedPath(env, &src);
 if (ContainsNul(src)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'src' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[0]));
 return;
 }

 BufferValue dest(isolate, args[1]);
 BufferValue dest(isolate, dest_val);
 CHECK_NOT_NULL(*dest);
 if (ContainsNul(dest)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'dest' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[1]));
 return;
 }

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 return;
 }

 ToNamespacedPath(env, &src);
 ToNamespacedPath(env, &dest);

 if (argc > 3) { // copyFile(src, dest, flags, req)
Expand Down

2 changes: 1 addition & 1 deletion
src/node_url.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -688,7 +688,7 @@ std::optional<std::string> FileURLToPath(Environment* env,
 if (hostname.size() > 0) {
 THROW_ERR_INVALID_FILE_URL_HOST(
 env->isolate(),
 "File URL host must be \"localhost\" or empty on ",
 "File URL host must be \"localhost\" or empty on %s",
 std::string(per_process::metadata.platform));
 return std::nullopt;
 }
Expand Down

62 changes: 62 additions & 0 deletions
test/parallel/test-fs-copyfile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ const {
 UV_ENOENT,
 UV_EEXIST
} = internalBinding('uv');
const { pathToFileURL } = require('url');
const src = fixtures.path('a.js');
const dest = tmpdir.resolve('copyfile.out');
const {
Expand DownExpand Up@@ -55,6 +56,22 @@ verify(src, dest);
fs.copyFileSync(src, dest, 0);
verify(src, dest);

// Verify Buffer and file: URL paths.
{
 const destBuf = tmpdir.resolve('copyfile.buffer');
 fs.copyFileSync(Buffer.from(src), Buffer.from(destBuf));
 verify(src, destBuf);

 const destUrl = tmpdir.resolve('copyfile.url');
 fs.copyFileSync(pathToFileURL(src), pathToFileURL(destUrl));
 verify(src, destUrl);

 const destU8 = tmpdir.resolve('copyfile.uint8');
 fs.copyFileSync(new Uint8Array(Buffer.from(src)),
 new Uint8Array(Buffer.from(destU8)));
 verify(src, destU8);
}

// Verify that UV_FS_COPYFILE_FICLONE can be used.
fs.unlinkSync(dest);
fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
Expand DownExpand Up@@ -142,6 +159,51 @@ assert.throws(() => {
 );
});

assert.throws(() => {
 fs.copyFileSync(new URL('http://example.com/a'), dest);
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

assert.throws(() => {
 fs.copyFile(new URL('http://example.com/a'), dest, common.mustNotCall());
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

if (common.isWindows) {
 ['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
} else {
 ['%2f', '%2F'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
 assert.throws(
 () => fs.copyFileSync(new URL('file://hostname/a/b/c'), dest),
 {
 code: 'ERR_INVALID_FILE_URL_HOST',
 name: 'TypeError',
 }
 );
}

assert.throws(() => {
 fs.copyFileSync(src, dest, 'r');
}, {
Expand Down

7 changes: 4 additions & 3 deletions
typings/internalBinding/fs.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,9 +72,10 @@ declare namespace InternalFSBinding {
 function close(fd: number, req: FSReqCallback): void;
 function close(fd: number): void;

 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: FSReqCallback): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, usePromises: typeof kUsePromises): Promise<void>;
 function copyFile(src: unknown, dest: unknown, mode?: unknown): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: FSReqCallback): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, usePromises: typeof kUsePromises): Promise<void>;

 function cpSyncCheckPaths(src: StringOrBuffer, dest: StringOrBuffer, dereference: boolean, recursive: boolean): void;
 function cpSyncOverrideFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, preserveTimestamps: boolean): void;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fs: validate copyFile paths in the existing C++ binding#65376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

anonrig
wants to merge
2
commits into

base:main
Choose a base branch

from

 Open


fs: validate copyFile paths in the existing C++ binding
#65376
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e4dc3a1

fs: implement copyFileSync in C++


anonrig Aug 18, 2026
0fcda9b

fs: validate copyFile paths in the existing C++ binding


cursoragent Aug 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 1 addition & 7 deletions
lib/fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3659,8 +3659,6 @@ function copyFile(src, dest, mode, callback) {
 const h = vfsState.handlers;
 if (h !== null && vfsVoid(h.copyFile(src, dest, mode), callback)) return;

 src = getValidatedPath(src, 'src');
 dest = getValidatedPath(dest, 'dest');
 callback = makeCallback(callback);

 const req = new FSReqCallback();
Expand All@@ -3682,11 +3680,7 @@ function copyFileSync(src, dest, mode) {
 const result = h.copyFileSync(src, dest, mode);
 if (result !== undefined) return;
 }
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 );
 binding.copyFile(src, dest, mode);
}

/**
Expand Down

7 changes: 1 addition & 6 deletions
lib/internal/fs/promises.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1335,12 +1335,7 @@ async function copyFile(src, dest, mode) {
 if (promise !== undefined) { await promise; return; }
 }
 return await PromisePrototypeThen(
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 kUsePromises,
 ),
 binding.copyFile(src, dest, mode, kUsePromises),
 undefined,
 handleErrorFromBinding,
 );
Expand Down

162 changes: 156 additions & 6 deletions
src/node_file.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
#include <errno.h>
#include <cerrno>
#include <cstdio>
#include <cstring>
#include <filesystem>

#if defined(__MINGW32__) || defined(_MSC_VER)
Expand DownExpand Up@@ -77,6 +78,7 @@ using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Nothing;
using v8::Number;
using v8::Object;
Expand DownExpand Up@@ -2416,24 +2418,172 @@ static void OpenFileHandle(const FunctionCallbackInfo<Value>& args) {
 }
}

// Matches lib/internal/url.js isURL(): duck-type WHATWG URL objects vs
// legacy url.parse() results (which have `auth` and `path` properties).
static bool IsUrlLike(Environment* env, Local<Value> value) {
 if (!value->IsObject() || value->IsUint8Array()) {
 return false;
 }

 Isolate* isolate = env->isolate();
 Local<Context> context = env->context();
 Local<Object> obj = value.As<Object>();

 Local<Value> href;
 if (!obj->Get(context, env->href_string()).ToLocal(&href)) {
 return false;
 }
 if (!href->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> protocol;
 if (!obj->Get(context, env->protocol_string()).ToLocal(&protocol)) {
 return false;
 }
 if (!protocol->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> auth;
 if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "auth"))
 .ToLocal(&auth)) {
 return false;
 }

 Local<Value> path;
 if (!obj->Get(context, env->path_string()).ToLocal(&path)) {
 return false;
 }

 return auth->IsUndefined() && path->IsUndefined();
}

static bool ContainsNul(const BufferValue& path) {
 return path.length() > 0 &&
 std::memchr(path.out(), '\0', path.length()) != nullptr;
}

// C++ equivalent of getValidatedPath(value, propName), used by CopyFile for
// the sync, callback, and promises paths. Accepts string, Uint8Array/Buffer,
// or WHATWG URL, rejects embedded NUL bytes, and converts file: URLs to
// paths. Returns an empty MaybeLocal and throws on failure.
static MaybeLocal<Value> GetValidatedPath(Environment* env,
 Local<Value> input,
 const char* prop_name) {
 Isolate* isolate = env->isolate();

 if (input->IsString() || input->IsUint8Array()) {
 return input;
 }

 if (IsUrlLike(env, input)) {
 Local<Context> context = env->context();
 Local<Value> href;
 if (!input.As<Object>()->Get(context, env->href_string()).ToLocal(&href)) {
 return MaybeLocal<Value>();
 }

 Utf8Value href_utf8(isolate, href);
 auto parsed = ada::parse<ada::url_aggregator>(href_utf8.ToStringView());
 if (!parsed) {
 url::ThrowInvalidURL(env, href_utf8.ToStringView(), std::nullopt);
 return MaybeLocal<Value>();
 }

 // Match lib/internal/url.js fileURLToPath(): non-file schemes throw
 // ERR_INVALID_URL_SCHEME with the same message as JS (`file`, not `file:`).
 if (parsed->type != ada::scheme::FILE) {
 THROW_ERR_INVALID_URL_SCHEME(isolate, "The URL must be of scheme file");
 return MaybeLocal<Value>();
 }

 std::optional<std::string> file_path = url::FileURLToPath(env, *parsed);
 if (!file_path.has_value()) {
 return MaybeLocal<Value>();
 }

 if (file_path->find('\0') != std::string::npos) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument '%s' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
 }

 Local<String> path_string;
 if (!String::NewFromUtf8(isolate,
 file_path->data(),
 NewStringType::kNormal,
 static_cast<int>(file_path->size()))
 .ToLocal(&path_string)) {
 return MaybeLocal<Value>();
 }
 return path_string;
 }

 if (isolate->HasPendingException()) {
 return MaybeLocal<Value>();
 }

 THROW_ERR_INVALID_ARG_TYPE(
 env,
 "The \"%s\" argument must be of type string or an instance of "
 "Buffer or URL. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
}

// Shared by the sync, callback, and promises copyFile paths. Path validation
// (string / Uint8Array / file: URL, NUL checks) happens here so JS callers
// can pass the original arguments through.
static void CopyFile(const FunctionCallbackInfo<Value>& args) {
 Environment* env = Environment::GetCurrent(args);
 Isolate* isolate = env->isolate();

 const int argc = args.Length();
 CHECK_GE(argc, 3); // src, dest, flags
 CHECK_GE(argc, 3); // src, dest, flags[, req]

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 Local<Value> src_val;
 if (!GetValidatedPath(env, args[0], "src").ToLocal(&src_val)) {
 return;
 }
 Local<Value> dest_val;
 if (!GetValidatedPath(env, args[1], "dest").ToLocal(&dest_val)) {
 return;
 }

 BufferValue src(isolate, args[0]);
 BufferValue src(isolate, src_val);
 CHECK_NOT_NULL(*src);
 ToNamespacedPath(env, &src);
 if (ContainsNul(src)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'src' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[0]));
 return;
 }

 BufferValue dest(isolate, args[1]);
 BufferValue dest(isolate, dest_val);
 CHECK_NOT_NULL(*dest);
 if (ContainsNul(dest)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'dest' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[1]));
 return;
 }

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 return;
 }

 ToNamespacedPath(env, &src);
 ToNamespacedPath(env, &dest);

 if (argc > 3) { // copyFile(src, dest, flags, req)
Expand Down

2 changes: 1 addition & 1 deletion
src/node_url.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -688,7 +688,7 @@ std::optional<std::string> FileURLToPath(Environment* env,
 if (hostname.size() > 0) {
 THROW_ERR_INVALID_FILE_URL_HOST(
 env->isolate(),
 "File URL host must be \"localhost\" or empty on ",
 "File URL host must be \"localhost\" or empty on %s",
 std::string(per_process::metadata.platform));
 return std::nullopt;
 }
Expand Down

62 changes: 62 additions & 0 deletions
test/parallel/test-fs-copyfile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ const {
 UV_ENOENT,
 UV_EEXIST
} = internalBinding('uv');
const { pathToFileURL } = require('url');
const src = fixtures.path('a.js');
const dest = tmpdir.resolve('copyfile.out');
const {
Expand DownExpand Up@@ -55,6 +56,22 @@ verify(src, dest);
fs.copyFileSync(src, dest, 0);
verify(src, dest);

// Verify Buffer and file: URL paths.
{
 const destBuf = tmpdir.resolve('copyfile.buffer');
 fs.copyFileSync(Buffer.from(src), Buffer.from(destBuf));
 verify(src, destBuf);

 const destUrl = tmpdir.resolve('copyfile.url');
 fs.copyFileSync(pathToFileURL(src), pathToFileURL(destUrl));
 verify(src, destUrl);

 const destU8 = tmpdir.resolve('copyfile.uint8');
 fs.copyFileSync(new Uint8Array(Buffer.from(src)),
 new Uint8Array(Buffer.from(destU8)));
 verify(src, destU8);
}

// Verify that UV_FS_COPYFILE_FICLONE can be used.
fs.unlinkSync(dest);
fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
Expand DownExpand Up@@ -142,6 +159,51 @@ assert.throws(() => {
 );
});

assert.throws(() => {
 fs.copyFileSync(new URL('http://example.com/a'), dest);
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

assert.throws(() => {
 fs.copyFile(new URL('http://example.com/a'), dest, common.mustNotCall());
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

if (common.isWindows) {
 ['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
} else {
 ['%2f', '%2F'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
 assert.throws(
 () => fs.copyFileSync(new URL('file://hostname/a/b/c'), dest),
 {
 code: 'ERR_INVALID_FILE_URL_HOST',
 name: 'TypeError',
 }
 );
}

assert.throws(() => {
 fs.copyFileSync(src, dest, 'r');
}, {
Expand Down

7 changes: 4 additions & 3 deletions
typings/internalBinding/fs.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,9 +72,10 @@ declare namespace InternalFSBinding {
 function close(fd: number, req: FSReqCallback): void;
 function close(fd: number): void;

 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: FSReqCallback): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, usePromises: typeof kUsePromises): Promise<void>;
 function copyFile(src: unknown, dest: unknown, mode?: unknown): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: FSReqCallback): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, usePromises: typeof kUsePromises): Promise<void>;

 function cpSyncCheckPaths(src: StringOrBuffer, dest: StringOrBuffer, dereference: boolean, recursive: boolean): void;
 function cpSyncOverrideFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, preserveTimestamps: boolean): void;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fs: validate copyFile paths in the existing C++ binding#65376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

anonrig
wants to merge
2
commits into

base:main
Choose a base branch

from

 Open


fs: validate copyFile paths in the existing C++ binding
#65376
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e4dc3a1

fs: implement copyFileSync in C++


anonrig Aug 18, 2026
0fcda9b

fs: validate copyFile paths in the existing C++ binding


cursoragent Aug 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 1 addition & 7 deletions
lib/fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3659,8 +3659,6 @@ function copyFile(src, dest, mode, callback) {
 const h = vfsState.handlers;
 if (h !== null && vfsVoid(h.copyFile(src, dest, mode), callback)) return;

 src = getValidatedPath(src, 'src');
 dest = getValidatedPath(dest, 'dest');
 callback = makeCallback(callback);

 const req = new FSReqCallback();
Expand All@@ -3682,11 +3680,7 @@ function copyFileSync(src, dest, mode) {
 const result = h.copyFileSync(src, dest, mode);
 if (result !== undefined) return;
 }
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 );
 binding.copyFile(src, dest, mode);
}

/**
Expand Down

7 changes: 1 addition & 6 deletions
lib/internal/fs/promises.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1335,12 +1335,7 @@ async function copyFile(src, dest, mode) {
 if (promise !== undefined) { await promise; return; }
 }
 return await PromisePrototypeThen(
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 kUsePromises,
 ),
 binding.copyFile(src, dest, mode, kUsePromises),
 undefined,
 handleErrorFromBinding,
 );
Expand Down

162 changes: 156 additions & 6 deletions
src/node_file.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
#include <errno.h>
#include <cerrno>
#include <cstdio>
#include <cstring>
#include <filesystem>

#if defined(__MINGW32__) || defined(_MSC_VER)
Expand DownExpand Up@@ -77,6 +78,7 @@ using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Nothing;
using v8::Number;
using v8::Object;
Expand DownExpand Up@@ -2416,24 +2418,172 @@ static void OpenFileHandle(const FunctionCallbackInfo<Value>& args) {
 }
}

// Matches lib/internal/url.js isURL(): duck-type WHATWG URL objects vs
// legacy url.parse() results (which have `auth` and `path` properties).
static bool IsUrlLike(Environment* env, Local<Value> value) {
 if (!value->IsObject() || value->IsUint8Array()) {
 return false;
 }

 Isolate* isolate = env->isolate();
 Local<Context> context = env->context();
 Local<Object> obj = value.As<Object>();

 Local<Value> href;
 if (!obj->Get(context, env->href_string()).ToLocal(&href)) {
 return false;
 }
 if (!href->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> protocol;
 if (!obj->Get(context, env->protocol_string()).ToLocal(&protocol)) {
 return false;
 }
 if (!protocol->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> auth;
 if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "auth"))
 .ToLocal(&auth)) {
 return false;
 }

 Local<Value> path;
 if (!obj->Get(context, env->path_string()).ToLocal(&path)) {
 return false;
 }

 return auth->IsUndefined() && path->IsUndefined();
}

static bool ContainsNul(const BufferValue& path) {
 return path.length() > 0 &&
 std::memchr(path.out(), '\0', path.length()) != nullptr;
}

// C++ equivalent of getValidatedPath(value, propName), used by CopyFile for
// the sync, callback, and promises paths. Accepts string, Uint8Array/Buffer,
// or WHATWG URL, rejects embedded NUL bytes, and converts file: URLs to
// paths. Returns an empty MaybeLocal and throws on failure.
static MaybeLocal<Value> GetValidatedPath(Environment* env,
 Local<Value> input,
 const char* prop_name) {
 Isolate* isolate = env->isolate();

 if (input->IsString() || input->IsUint8Array()) {
 return input;
 }

 if (IsUrlLike(env, input)) {
 Local<Context> context = env->context();
 Local<Value> href;
 if (!input.As<Object>()->Get(context, env->href_string()).ToLocal(&href)) {
 return MaybeLocal<Value>();
 }

 Utf8Value href_utf8(isolate, href);
 auto parsed = ada::parse<ada::url_aggregator>(href_utf8.ToStringView());
 if (!parsed) {
 url::ThrowInvalidURL(env, href_utf8.ToStringView(), std::nullopt);
 return MaybeLocal<Value>();
 }

 // Match lib/internal/url.js fileURLToPath(): non-file schemes throw
 // ERR_INVALID_URL_SCHEME with the same message as JS (`file`, not `file:`).
 if (parsed->type != ada::scheme::FILE) {
 THROW_ERR_INVALID_URL_SCHEME(isolate, "The URL must be of scheme file");
 return MaybeLocal<Value>();
 }

 std::optional<std::string> file_path = url::FileURLToPath(env, *parsed);
 if (!file_path.has_value()) {
 return MaybeLocal<Value>();
 }

 if (file_path->find('\0') != std::string::npos) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument '%s' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
 }

 Local<String> path_string;
 if (!String::NewFromUtf8(isolate,
 file_path->data(),
 NewStringType::kNormal,
 static_cast<int>(file_path->size()))
 .ToLocal(&path_string)) {
 return MaybeLocal<Value>();
 }
 return path_string;
 }

 if (isolate->HasPendingException()) {
 return MaybeLocal<Value>();
 }

 THROW_ERR_INVALID_ARG_TYPE(
 env,
 "The \"%s\" argument must be of type string or an instance of "
 "Buffer or URL. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
}

// Shared by the sync, callback, and promises copyFile paths. Path validation
// (string / Uint8Array / file: URL, NUL checks) happens here so JS callers
// can pass the original arguments through.
static void CopyFile(const FunctionCallbackInfo<Value>& args) {
 Environment* env = Environment::GetCurrent(args);
 Isolate* isolate = env->isolate();

 const int argc = args.Length();
 CHECK_GE(argc, 3); // src, dest, flags
 CHECK_GE(argc, 3); // src, dest, flags[, req]

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 Local<Value> src_val;
 if (!GetValidatedPath(env, args[0], "src").ToLocal(&src_val)) {
 return;
 }
 Local<Value> dest_val;
 if (!GetValidatedPath(env, args[1], "dest").ToLocal(&dest_val)) {
 return;
 }

 BufferValue src(isolate, args[0]);
 BufferValue src(isolate, src_val);
 CHECK_NOT_NULL(*src);
 ToNamespacedPath(env, &src);
 if (ContainsNul(src)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'src' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[0]));
 return;
 }

 BufferValue dest(isolate, args[1]);
 BufferValue dest(isolate, dest_val);
 CHECK_NOT_NULL(*dest);
 if (ContainsNul(dest)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'dest' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[1]));
 return;
 }

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 return;
 }

 ToNamespacedPath(env, &src);
 ToNamespacedPath(env, &dest);

 if (argc > 3) { // copyFile(src, dest, flags, req)
Expand Down

2 changes: 1 addition & 1 deletion
src/node_url.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -688,7 +688,7 @@ std::optional<std::string> FileURLToPath(Environment* env,
 if (hostname.size() > 0) {
 THROW_ERR_INVALID_FILE_URL_HOST(
 env->isolate(),
 "File URL host must be \"localhost\" or empty on ",
 "File URL host must be \"localhost\" or empty on %s",
 std::string(per_process::metadata.platform));
 return std::nullopt;
 }
Expand Down

62 changes: 62 additions & 0 deletions
test/parallel/test-fs-copyfile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ const {
 UV_ENOENT,
 UV_EEXIST
} = internalBinding('uv');
const { pathToFileURL } = require('url');
const src = fixtures.path('a.js');
const dest = tmpdir.resolve('copyfile.out');
const {
Expand DownExpand Up@@ -55,6 +56,22 @@ verify(src, dest);
fs.copyFileSync(src, dest, 0);
verify(src, dest);

// Verify Buffer and file: URL paths.
{
 const destBuf = tmpdir.resolve('copyfile.buffer');
 fs.copyFileSync(Buffer.from(src), Buffer.from(destBuf));
 verify(src, destBuf);

 const destUrl = tmpdir.resolve('copyfile.url');
 fs.copyFileSync(pathToFileURL(src), pathToFileURL(destUrl));
 verify(src, destUrl);

 const destU8 = tmpdir.resolve('copyfile.uint8');
 fs.copyFileSync(new Uint8Array(Buffer.from(src)),
 new Uint8Array(Buffer.from(destU8)));
 verify(src, destU8);
}

// Verify that UV_FS_COPYFILE_FICLONE can be used.
fs.unlinkSync(dest);
fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
Expand DownExpand Up@@ -142,6 +159,51 @@ assert.throws(() => {
 );
});

assert.throws(() => {
 fs.copyFileSync(new URL('http://example.com/a'), dest);
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

assert.throws(() => {
 fs.copyFile(new URL('http://example.com/a'), dest, common.mustNotCall());
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

if (common.isWindows) {
 ['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
} else {
 ['%2f', '%2F'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
 assert.throws(
 () => fs.copyFileSync(new URL('file://hostname/a/b/c'), dest),
 {
 code: 'ERR_INVALID_FILE_URL_HOST',
 name: 'TypeError',
 }
 );
}

assert.throws(() => {
 fs.copyFileSync(src, dest, 'r');
}, {
Expand Down

7 changes: 4 additions & 3 deletions
typings/internalBinding/fs.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,9 +72,10 @@ declare namespace InternalFSBinding {
 function close(fd: number, req: FSReqCallback): void;
 function close(fd: number): void;

 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: FSReqCallback): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, usePromises: typeof kUsePromises): Promise<void>;
 function copyFile(src: unknown, dest: unknown, mode?: unknown): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: FSReqCallback): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, usePromises: typeof kUsePromises): Promise<void>;

 function cpSyncCheckPaths(src: StringOrBuffer, dest: StringOrBuffer, dereference: boolean, recursive: boolean): void;
 function cpSyncOverrideFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, preserveTimestamps: boolean): void;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fs: validate copyFile paths in the existing C++ binding#65376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

anonrig
wants to merge
2
commits into

base:main
Choose a base branch

from

 Open


fs: validate copyFile paths in the existing C++ binding
#65376
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e4dc3a1

fs: implement copyFileSync in C++


anonrig Aug 18, 2026
0fcda9b

fs: validate copyFile paths in the existing C++ binding


cursoragent Aug 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 1 addition & 7 deletions
lib/fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3659,8 +3659,6 @@ function copyFile(src, dest, mode, callback) {
 const h = vfsState.handlers;
 if (h !== null && vfsVoid(h.copyFile(src, dest, mode), callback)) return;

 src = getValidatedPath(src, 'src');
 dest = getValidatedPath(dest, 'dest');
 callback = makeCallback(callback);

 const req = new FSReqCallback();
Expand All@@ -3682,11 +3680,7 @@ function copyFileSync(src, dest, mode) {
 const result = h.copyFileSync(src, dest, mode);
 if (result !== undefined) return;
 }
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 );
 binding.copyFile(src, dest, mode);
}

/**
Expand Down

7 changes: 1 addition & 6 deletions
lib/internal/fs/promises.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1335,12 +1335,7 @@ async function copyFile(src, dest, mode) {
 if (promise !== undefined) { await promise; return; }
 }
 return await PromisePrototypeThen(
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 kUsePromises,
 ),
 binding.copyFile(src, dest, mode, kUsePromises),
 undefined,
 handleErrorFromBinding,
 );
Expand Down

162 changes: 156 additions & 6 deletions
src/node_file.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
#include <errno.h>
#include <cerrno>
#include <cstdio>
#include <cstring>
#include <filesystem>

#if defined(__MINGW32__) || defined(_MSC_VER)
Expand DownExpand Up@@ -77,6 +78,7 @@ using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Nothing;
using v8::Number;
using v8::Object;
Expand DownExpand Up@@ -2416,24 +2418,172 @@ static void OpenFileHandle(const FunctionCallbackInfo<Value>& args) {
 }
}

// Matches lib/internal/url.js isURL(): duck-type WHATWG URL objects vs
// legacy url.parse() results (which have `auth` and `path` properties).
static bool IsUrlLike(Environment* env, Local<Value> value) {
 if (!value->IsObject() || value->IsUint8Array()) {
 return false;
 }

 Isolate* isolate = env->isolate();
 Local<Context> context = env->context();
 Local<Object> obj = value.As<Object>();

 Local<Value> href;
 if (!obj->Get(context, env->href_string()).ToLocal(&href)) {
 return false;
 }
 if (!href->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> protocol;
 if (!obj->Get(context, env->protocol_string()).ToLocal(&protocol)) {
 return false;
 }
 if (!protocol->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> auth;
 if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "auth"))
 .ToLocal(&auth)) {
 return false;
 }

 Local<Value> path;
 if (!obj->Get(context, env->path_string()).ToLocal(&path)) {
 return false;
 }

 return auth->IsUndefined() && path->IsUndefined();
}

static bool ContainsNul(const BufferValue& path) {
 return path.length() > 0 &&
 std::memchr(path.out(), '\0', path.length()) != nullptr;
}

// C++ equivalent of getValidatedPath(value, propName), used by CopyFile for
// the sync, callback, and promises paths. Accepts string, Uint8Array/Buffer,
// or WHATWG URL, rejects embedded NUL bytes, and converts file: URLs to
// paths. Returns an empty MaybeLocal and throws on failure.
static MaybeLocal<Value> GetValidatedPath(Environment* env,
 Local<Value> input,
 const char* prop_name) {
 Isolate* isolate = env->isolate();

 if (input->IsString() || input->IsUint8Array()) {
 return input;
 }

 if (IsUrlLike(env, input)) {
 Local<Context> context = env->context();
 Local<Value> href;
 if (!input.As<Object>()->Get(context, env->href_string()).ToLocal(&href)) {
 return MaybeLocal<Value>();
 }

 Utf8Value href_utf8(isolate, href);
 auto parsed = ada::parse<ada::url_aggregator>(href_utf8.ToStringView());
 if (!parsed) {
 url::ThrowInvalidURL(env, href_utf8.ToStringView(), std::nullopt);
 return MaybeLocal<Value>();
 }

 // Match lib/internal/url.js fileURLToPath(): non-file schemes throw
 // ERR_INVALID_URL_SCHEME with the same message as JS (`file`, not `file:`).
 if (parsed->type != ada::scheme::FILE) {
 THROW_ERR_INVALID_URL_SCHEME(isolate, "The URL must be of scheme file");
 return MaybeLocal<Value>();
 }

 std::optional<std::string> file_path = url::FileURLToPath(env, *parsed);
 if (!file_path.has_value()) {
 return MaybeLocal<Value>();
 }

 if (file_path->find('\0') != std::string::npos) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument '%s' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
 }

 Local<String> path_string;
 if (!String::NewFromUtf8(isolate,
 file_path->data(),
 NewStringType::kNormal,
 static_cast<int>(file_path->size()))
 .ToLocal(&path_string)) {
 return MaybeLocal<Value>();
 }
 return path_string;
 }

 if (isolate->HasPendingException()) {
 return MaybeLocal<Value>();
 }

 THROW_ERR_INVALID_ARG_TYPE(
 env,
 "The \"%s\" argument must be of type string or an instance of "
 "Buffer or URL. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
}

// Shared by the sync, callback, and promises copyFile paths. Path validation
// (string / Uint8Array / file: URL, NUL checks) happens here so JS callers
// can pass the original arguments through.
static void CopyFile(const FunctionCallbackInfo<Value>& args) {
 Environment* env = Environment::GetCurrent(args);
 Isolate* isolate = env->isolate();

 const int argc = args.Length();
 CHECK_GE(argc, 3); // src, dest, flags
 CHECK_GE(argc, 3); // src, dest, flags[, req]

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 Local<Value> src_val;
 if (!GetValidatedPath(env, args[0], "src").ToLocal(&src_val)) {
 return;
 }
 Local<Value> dest_val;
 if (!GetValidatedPath(env, args[1], "dest").ToLocal(&dest_val)) {
 return;
 }

 BufferValue src(isolate, args[0]);
 BufferValue src(isolate, src_val);
 CHECK_NOT_NULL(*src);
 ToNamespacedPath(env, &src);
 if (ContainsNul(src)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'src' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[0]));
 return;
 }

 BufferValue dest(isolate, args[1]);
 BufferValue dest(isolate, dest_val);
 CHECK_NOT_NULL(*dest);
 if (ContainsNul(dest)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'dest' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[1]));
 return;
 }

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 return;
 }

 ToNamespacedPath(env, &src);
 ToNamespacedPath(env, &dest);

 if (argc > 3) { // copyFile(src, dest, flags, req)
Expand Down

2 changes: 1 addition & 1 deletion
src/node_url.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -688,7 +688,7 @@ std::optional<std::string> FileURLToPath(Environment* env,
 if (hostname.size() > 0) {
 THROW_ERR_INVALID_FILE_URL_HOST(
 env->isolate(),
 "File URL host must be \"localhost\" or empty on ",
 "File URL host must be \"localhost\" or empty on %s",
 std::string(per_process::metadata.platform));
 return std::nullopt;
 }
Expand Down

62 changes: 62 additions & 0 deletions
test/parallel/test-fs-copyfile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ const {
 UV_ENOENT,
 UV_EEXIST
} = internalBinding('uv');
const { pathToFileURL } = require('url');
const src = fixtures.path('a.js');
const dest = tmpdir.resolve('copyfile.out');
const {
Expand DownExpand Up@@ -55,6 +56,22 @@ verify(src, dest);
fs.copyFileSync(src, dest, 0);
verify(src, dest);

// Verify Buffer and file: URL paths.
{
 const destBuf = tmpdir.resolve('copyfile.buffer');
 fs.copyFileSync(Buffer.from(src), Buffer.from(destBuf));
 verify(src, destBuf);

 const destUrl = tmpdir.resolve('copyfile.url');
 fs.copyFileSync(pathToFileURL(src), pathToFileURL(destUrl));
 verify(src, destUrl);

 const destU8 = tmpdir.resolve('copyfile.uint8');
 fs.copyFileSync(new Uint8Array(Buffer.from(src)),
 new Uint8Array(Buffer.from(destU8)));
 verify(src, destU8);
}

// Verify that UV_FS_COPYFILE_FICLONE can be used.
fs.unlinkSync(dest);
fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
Expand DownExpand Up@@ -142,6 +159,51 @@ assert.throws(() => {
 );
});

assert.throws(() => {
 fs.copyFileSync(new URL('http://example.com/a'), dest);
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

assert.throws(() => {
 fs.copyFile(new URL('http://example.com/a'), dest, common.mustNotCall());
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

if (common.isWindows) {
 ['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
} else {
 ['%2f', '%2F'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
 assert.throws(
 () => fs.copyFileSync(new URL('file://hostname/a/b/c'), dest),
 {
 code: 'ERR_INVALID_FILE_URL_HOST',
 name: 'TypeError',
 }
 );
}

assert.throws(() => {
 fs.copyFileSync(src, dest, 'r');
}, {
Expand Down

7 changes: 4 additions & 3 deletions
typings/internalBinding/fs.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,9 +72,10 @@ declare namespace InternalFSBinding {
 function close(fd: number, req: FSReqCallback): void;
 function close(fd: number): void;

 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: FSReqCallback): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, usePromises: typeof kUsePromises): Promise<void>;
 function copyFile(src: unknown, dest: unknown, mode?: unknown): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: FSReqCallback): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, usePromises: typeof kUsePromises): Promise<void>;

 function cpSyncCheckPaths(src: StringOrBuffer, dest: StringOrBuffer, dereference: boolean, recursive: boolean): void;
 function cpSyncOverrideFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, preserveTimestamps: boolean): void;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fs: validate copyFile paths in the existing C++ binding#65376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

anonrig
wants to merge
2
commits into

base:main
Choose a base branch

from

 Open


fs: validate copyFile paths in the existing C++ binding
#65376
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
e4dc3a1

fs: implement copyFileSync in C++


anonrig Aug 18, 2026
0fcda9b

fs: validate copyFile paths in the existing C++ binding


cursoragent Aug 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 1 addition & 7 deletions
lib/fs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3659,8 +3659,6 @@ function copyFile(src, dest, mode, callback) {
 const h = vfsState.handlers;
 if (h !== null && vfsVoid(h.copyFile(src, dest, mode), callback)) return;

 src = getValidatedPath(src, 'src');
 dest = getValidatedPath(dest, 'dest');
 callback = makeCallback(callback);

 const req = new FSReqCallback();
Expand All@@ -3682,11 +3680,7 @@ function copyFileSync(src, dest, mode) {
 const result = h.copyFileSync(src, dest, mode);
 if (result !== undefined) return;
 }
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 );
 binding.copyFile(src, dest, mode);
}

/**
Expand Down

7 changes: 1 addition & 6 deletions
lib/internal/fs/promises.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1335,12 +1335,7 @@ async function copyFile(src, dest, mode) {
 if (promise !== undefined) { await promise; return; }
 }
 return await PromisePrototypeThen(
 binding.copyFile(
 getValidatedPath(src, 'src'),
 getValidatedPath(dest, 'dest'),
 mode,
 kUsePromises,
 ),
 binding.copyFile(src, dest, mode, kUsePromises),
 undefined,
 handleErrorFromBinding,
 );
Expand Down

162 changes: 156 additions & 6 deletions
src/node_file.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
#include <errno.h>
#include <cerrno>
#include <cstdio>
#include <cstring>
#include <filesystem>

#if defined(__MINGW32__) || defined(_MSC_VER)
Expand DownExpand Up@@ -77,6 +78,7 @@ using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::NewStringType;
using v8::Nothing;
using v8::Number;
using v8::Object;
Expand DownExpand Up@@ -2416,24 +2418,172 @@ static void OpenFileHandle(const FunctionCallbackInfo<Value>& args) {
 }
}

// Matches lib/internal/url.js isURL(): duck-type WHATWG URL objects vs
// legacy url.parse() results (which have `auth` and `path` properties).
static bool IsUrlLike(Environment* env, Local<Value> value) {
 if (!value->IsObject() || value->IsUint8Array()) {
 return false;
 }

 Isolate* isolate = env->isolate();
 Local<Context> context = env->context();
 Local<Object> obj = value.As<Object>();

 Local<Value> href;
 if (!obj->Get(context, env->href_string()).ToLocal(&href)) {
 return false;
 }
 if (!href->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> protocol;
 if (!obj->Get(context, env->protocol_string()).ToLocal(&protocol)) {
 return false;
 }
 if (!protocol->BooleanValue(isolate)) {
 return false;
 }

 Local<Value> auth;
 if (!obj->Get(context, FIXED_ONE_BYTE_STRING(isolate, "auth"))
 .ToLocal(&auth)) {
 return false;
 }

 Local<Value> path;
 if (!obj->Get(context, env->path_string()).ToLocal(&path)) {
 return false;
 }

 return auth->IsUndefined() && path->IsUndefined();
}

static bool ContainsNul(const BufferValue& path) {
 return path.length() > 0 &&
 std::memchr(path.out(), '\0', path.length()) != nullptr;
}

// C++ equivalent of getValidatedPath(value, propName), used by CopyFile for
// the sync, callback, and promises paths. Accepts string, Uint8Array/Buffer,
// or WHATWG URL, rejects embedded NUL bytes, and converts file: URLs to
// paths. Returns an empty MaybeLocal and throws on failure.
static MaybeLocal<Value> GetValidatedPath(Environment* env,
 Local<Value> input,
 const char* prop_name) {
 Isolate* isolate = env->isolate();

 if (input->IsString() || input->IsUint8Array()) {
 return input;
 }

 if (IsUrlLike(env, input)) {
 Local<Context> context = env->context();
 Local<Value> href;
 if (!input.As<Object>()->Get(context, env->href_string()).ToLocal(&href)) {
 return MaybeLocal<Value>();
 }

 Utf8Value href_utf8(isolate, href);
 auto parsed = ada::parse<ada::url_aggregator>(href_utf8.ToStringView());
 if (!parsed) {
 url::ThrowInvalidURL(env, href_utf8.ToStringView(), std::nullopt);
 return MaybeLocal<Value>();
 }

 // Match lib/internal/url.js fileURLToPath(): non-file schemes throw
 // ERR_INVALID_URL_SCHEME with the same message as JS (`file`, not `file:`).
 if (parsed->type != ada::scheme::FILE) {
 THROW_ERR_INVALID_URL_SCHEME(isolate, "The URL must be of scheme file");
 return MaybeLocal<Value>();
 }

 std::optional<std::string> file_path = url::FileURLToPath(env, *parsed);
 if (!file_path.has_value()) {
 return MaybeLocal<Value>();
 }

 if (file_path->find('\0') != std::string::npos) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument '%s' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
 }

 Local<String> path_string;
 if (!String::NewFromUtf8(isolate,
 file_path->data(),
 NewStringType::kNormal,
 static_cast<int>(file_path->size()))
 .ToLocal(&path_string)) {
 return MaybeLocal<Value>();
 }
 return path_string;
 }

 if (isolate->HasPendingException()) {
 return MaybeLocal<Value>();
 }

 THROW_ERR_INVALID_ARG_TYPE(
 env,
 "The \"%s\" argument must be of type string or an instance of "
 "Buffer or URL. Received %s",
 prop_name,
 DetermineSpecificErrorType(env, input));
 return MaybeLocal<Value>();
}

// Shared by the sync, callback, and promises copyFile paths. Path validation
// (string / Uint8Array / file: URL, NUL checks) happens here so JS callers
// can pass the original arguments through.
static void CopyFile(const FunctionCallbackInfo<Value>& args) {
 Environment* env = Environment::GetCurrent(args);
 Isolate* isolate = env->isolate();

 const int argc = args.Length();
 CHECK_GE(argc, 3); // src, dest, flags
 CHECK_GE(argc, 3); // src, dest, flags[, req]

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 Local<Value> src_val;
 if (!GetValidatedPath(env, args[0], "src").ToLocal(&src_val)) {
 return;
 }
 Local<Value> dest_val;
 if (!GetValidatedPath(env, args[1], "dest").ToLocal(&dest_val)) {
 return;
 }

 BufferValue src(isolate, args[0]);
 BufferValue src(isolate, src_val);
 CHECK_NOT_NULL(*src);
 ToNamespacedPath(env, &src);
 if (ContainsNul(src)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'src' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[0]));
 return;
 }

 BufferValue dest(isolate, args[1]);
 BufferValue dest(isolate, dest_val);
 CHECK_NOT_NULL(*dest);
 if (ContainsNul(dest)) {
 THROW_ERR_INVALID_ARG_VALUE(
 env,
 "The argument 'dest' must be a string, Uint8Array, or URL "
 "without null bytes. Received %s",
 DetermineSpecificErrorType(env, args[1]));
 return;
 }

 int flags;
 if (!GetValidFileMode(env, args[2], UV_FS_COPYFILE).To(&flags)) {
 return;
 }

 ToNamespacedPath(env, &src);
 ToNamespacedPath(env, &dest);

 if (argc > 3) { // copyFile(src, dest, flags, req)
Expand Down

2 changes: 1 addition & 1 deletion
src/node_url.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -688,7 +688,7 @@ std::optional<std::string> FileURLToPath(Environment* env,
 if (hostname.size() > 0) {
 THROW_ERR_INVALID_FILE_URL_HOST(
 env->isolate(),
 "File URL host must be \"localhost\" or empty on ",
 "File URL host must be \"localhost\" or empty on %s",
 std::string(per_process::metadata.platform));
 return std::nullopt;
 }
Expand Down

62 changes: 62 additions & 0 deletions
test/parallel/test-fs-copyfile.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ const {
 UV_ENOENT,
 UV_EEXIST
} = internalBinding('uv');
const { pathToFileURL } = require('url');
const src = fixtures.path('a.js');
const dest = tmpdir.resolve('copyfile.out');
const {
Expand DownExpand Up@@ -55,6 +56,22 @@ verify(src, dest);
fs.copyFileSync(src, dest, 0);
verify(src, dest);

// Verify Buffer and file: URL paths.
{
 const destBuf = tmpdir.resolve('copyfile.buffer');
 fs.copyFileSync(Buffer.from(src), Buffer.from(destBuf));
 verify(src, destBuf);

 const destUrl = tmpdir.resolve('copyfile.url');
 fs.copyFileSync(pathToFileURL(src), pathToFileURL(destUrl));
 verify(src, destUrl);

 const destU8 = tmpdir.resolve('copyfile.uint8');
 fs.copyFileSync(new Uint8Array(Buffer.from(src)),
 new Uint8Array(Buffer.from(destU8)));
 verify(src, destU8);
}

// Verify that UV_FS_COPYFILE_FICLONE can be used.
fs.unlinkSync(dest);
fs.copyFileSync(src, dest, UV_FS_COPYFILE_FICLONE);
Expand DownExpand Up@@ -142,6 +159,51 @@ assert.throws(() => {
 );
});

assert.throws(() => {
 fs.copyFileSync(new URL('http://example.com/a'), dest);
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

assert.throws(() => {
 fs.copyFile(new URL('http://example.com/a'), dest, common.mustNotCall());
}, {
 code: 'ERR_INVALID_URL_SCHEME',
 name: 'TypeError',
 message: 'The URL must be of scheme file',
});

if (common.isWindows) {
 ['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
} else {
 ['%2f', '%2F'].forEach((i) => {
 assert.throws(
 () => fs.copyFileSync(new URL(`file:///c:/tmp/${i}`), dest),
 {
 code: 'ERR_INVALID_FILE_URL_PATH',
 name: 'TypeError',
 }
 );
 });
 assert.throws(
 () => fs.copyFileSync(new URL('file://hostname/a/b/c'), dest),
 {
 code: 'ERR_INVALID_FILE_URL_HOST',
 name: 'TypeError',
 }
 );
}

assert.throws(() => {
 fs.copyFileSync(src, dest, 'r');
}, {
Expand Down

7 changes: 4 additions & 3 deletions
typings/internalBinding/fs.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,9 +72,10 @@ declare namespace InternalFSBinding {
 function close(fd: number, req: FSReqCallback): void;
 function close(fd: number): void;

 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: FSReqCallback): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, usePromises: typeof kUsePromises): Promise<void>;
 function copyFile(src: unknown, dest: unknown, mode?: unknown): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: FSReqCallback): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, req: undefined, ctx: FSSyncContext): void;
 function copyFile(src: unknown, dest: unknown, mode: unknown, usePromises: typeof kUsePromises): Promise<void>;

 function cpSyncCheckPaths(src: StringOrBuffer, dest: StringOrBuffer, dereference: boolean, recursive: boolean): void;
 function cpSyncOverrideFile(src: StringOrBuffer, dest: StringOrBuffer, mode: number, preserveTimestamps: boolean): void;
Expand Down
Loading