test: fix unreliable known_issues test by Trott · Pull Request #6555 · nodejs/node

Trott · 2016-05-04T00:10:34Z

Checklist

tests and code linting passes
the commit message follows commit guidelines

Affected core subsystem(s)

test

Description of change

test-stdout-buffer-flush-on-exit was not failing reliably on POSIX
machines and not failing at all on Windows. Revised test fails reliably
on POSIX and is skipped (in CI) on Windows where the issue does not
exist.

Fixes: #6527

joaocgreis · 2016-05-04T00:22:03Z

LGTM

jasnell · 2016-05-04T02:23:45Z

LGTM

santigimeno · 2016-05-04T07:27:36Z

Can't you just calculate Math.pow(2, exponent) once in the parent and pass it as argument to the child?

santigimeno · 2016-05-04T07:28:30Z

LGTM with a comment

cjihrig · 2016-05-04T13:04:03Z

Is the console.log() needed, or can it be dropped?

I don’t know if it’s needed, but I’d like to have some way of knowing at what length the test failed after it has run.

I accidentally left it in from debugging. I can add it to the assert message, perhaps.

cjihrig · 2016-05-04T13:04:25Z

LGTM with nits addressed.

addaleax · 2016-05-04T13:45:52Z

LGTM, maybe with @santigimeno’s nit addressed if that works too.

Trott · 2016-05-05T03:47:44Z

Nits addressed.

`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: nodejs#6527

santigimeno · 2016-05-05T10:04:11Z

+[16, 18, 20].forEach((exponent) => {
+ const bigNum = Math.pow(2, exponent);
+ const longLine = lineSeed.repeat(bigNum);
+ const cmd = `${process.execPath} ${__filename} child ${exponent} ${bigNum}`;


I think the exponent argument is not needed anymore

Strictly speaking, that's true, but I left it in for the assert message.

santigimeno · 2016-05-05T10:07:07Z

Still LGTM with one nit

`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: nodejs#6527 PR-URL: nodejs#6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Trott · 2016-05-06T02:43:38Z

Landed in c4006dd

`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins · 2016-06-02T00:22:20Z

@Trott lts?

Trott · 2016-06-02T02:52:50Z

@thealphanerd Yes

`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Trott added test Issues and PRs related to the tests. known issue test labels May 4, 2016

Trott mentioned this pull request May 4, 2016
test: run known_issues tests in CI #6559
Closed
2 tasks

santigimeno reviewed May 4, 2016
View reviewed changes

cjihrig reviewed May 4, 2016
View reviewed changes

Trott force-pushed the known branch from 568035b to cdb5670Compare May 5, 2016 03:47

test: fix unreliable known_issues test
e594ea5
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: nodejs#6527

Trott force-pushed the known branch from cdb5670 to e594ea5Compare May 5, 2016 03:48

santigimeno reviewed May 5, 2016
View reviewed changes

Trott closed this May 6, 2016

evanlucas mentioned this pull request May 17, 2016
2016-05-17, Version 6.2.0 (Stable) #6810
Merged

MylesBorins added the lts-watch-v4.x label Jun 2, 2016

MylesBorins mentioned this pull request Jun 24, 2016
v4.4.7 proposal #7395
Merged

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Jul 11, 2016

Trott deleted the known branch January 13, 2022 22:43

Uh oh!

Uh oh!

Conversation

Trott commented May 4, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

joaocgreis commented May 4, 2016

Uh oh!

jasnell commented May 4, 2016

Uh oh!

santigimenoMay 4, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santigimeno commented May 4, 2016

Uh oh!

cjihrigMay 4, 2016

Choose a reason for hiding this comment

Uh oh!

addaleaxMay 4, 2016

Choose a reason for hiding this comment

Uh oh!

TrottMay 4, 2016

Choose a reason for hiding this comment

Uh oh!

cjihrig commented May 4, 2016

Uh oh!

addaleax commented May 4, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented May 5, 2016

Uh oh!

santigimenoMay 5, 2016

Choose a reason for hiding this comment

Uh oh!

TrottMay 6, 2016

Choose a reason for hiding this comment

Uh oh!

santigimeno commented May 5, 2016

Uh oh!

Trott commented May 6, 2016

Uh oh!

MylesBorins commented Jun 2, 2016

Uh oh!

Trott commented Jun 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

santigimenoMay 4, 2016•
edited
Loading

addaleax commented May 4, 2016•
edited
Loading