Uh oh!
There was an error while loading. Please reload this page.
test: run known_issues tests in CI - #6559
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Add `known_issues` tests to `make test` and `make test-ci` targets and their equivalents on Windows.
Trott
commented
May 4, 2016
MemberAuthor
jasnell
commented
May 4, 2016
Member
Appreciate it! Use of the labels really helps save time. |
orangemocha
commented
May 5, 2016
Contributor
cc @joaocgreis |
Trott
commented
May 6, 2016
MemberAuthor
#6555 landed, which means this can land, so I'm removing the |
Trott
commented
May 6, 2016
MemberAuthor
Trott
commented
May 6, 2016
MemberAuthor
Single test failure in CI looks unrelated. Opened an "investigate flaky test" issue for it. Re-running CI: https://ci.nodejs.org/job/node-test-pull-request/2521/ |
Trott
commented
May 6, 2016
MemberAuthor
CI is green. /bump @nodejs/collaborators |
cjihrig
commented
May 6, 2016
Contributor
LGTM, but I'm not comfortable being the only sign off on Python code :-) |
addaleax
commented
May 6, 2016
Member
LGTM |
Trott added a commit
to Trott/io.js
that referenced
this pull request
May 6, 2016
Add `known_issues` tests to `make test` and `make test-ci` targets and their equivalents on Windows. PR-URL: nodejs#6559 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Trott
commented
May 6, 2016
MemberAuthor
Landed in 5d0b1f4 |
evanlucas pushed a commit
that referenced
this pull request
May 17, 2016
Add `known_issues` tests to `make test` and `make test-ci` targets and their equivalents on Windows. PR-URL: #6559 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
commented
Jun 2, 2016
Contributor
@Trott lts? |
Trott
commented
Jun 2, 2016
MemberAuthor
@thealphanerd Yes. |
MylesBorins
commented
Jun 3, 2016
Contributor
@Trott does not land cleanly.. feel free to backport |
Trott
commented
Jun 3, 2016
MemberAuthor
It's not essential. I'm OK with leaving it out. |
3 tasks
aqrln pushed a commit
that referenced
this pull request
Apr 9, 2017
* Since #6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: #12262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
* Since nodejs#6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: nodejs#12262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit
that referenced
this pull request
Apr 18, 2017
* Since #6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: #12262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
* Since #6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: #12262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
* Since nodejs/node#6559 known_issues does run on CI. * Add some notes to explain the expectations around tests in known_issues. PR-URL: nodejs/node#12262 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Add
known_issuestests tomake testandmake test-citargets andtheir equivalents on Windows.
This should not land until #6555 lands first.(#6555 landed, woot.)/cc @cjihrig@Fishrock123 @nodejs/testing ... and whoever the Python folks are who can tell me if I'm Doing It Wrong in
testcfg.py... @thefourtheye? @bnoordhuis? @jbergstroem? Someone else?