src: disable V8 external memory reasonable size check by bitpshr · Pull Request #65589 · nodejs/node

bitpshr · 2026-08-27T13:20:35Z

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step, which defaults to 32. Allocating a buffer larger than that is a legitimate thing to do in Node, and it should raise a RangeError rather than terminate the process:

# Fatal error in , line 0
# Check failed: change_in_bytes < kMaxReasonableBytes.

This defaults the flag to 0 unless the user supplied a value, next to the other V8 defaults Node already sets explicitly. Per @Renegade334 on the issue, the 32 GB limit is a Chromium oriented sanity check rather than something Node wants to inherit.

The guard checks both the dashed and underscored spellings, since V8 accepts either, and appends only when neither is present so an explicit --external-memory-max-reasonable-size=N still wins.

On testing: reproducing the real thing needs more than 32 GB of RAM, which I do not have, so I verified against a lowered threshold instead. --external-memory-max-reasonable-size=1 plus a 2 GB allocation produces the identical fatal check, and the same allocation succeeds once the flag defaults to 0. The test covers the override path rather than the new default, because asserting the default is gone would need a >32 GB allocation in CI. I confirmed the test fails if the appended flag clobbers a user supplied value, so it does catch the case it is there for.

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: nodejs#65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-08-27T13:20:41Z

Review requested:

@nodejs/startup

codecov · 2026-08-27T15:07:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (9baabd4) to head (efc3936).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65589 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 751 751 Lines 254875 254880 +5 Branches 48108 48126 +18 ==========================================
- Hits 229579 229574 -5 - Misses 16466 16496 +30 + Partials 8830 8810 -20

Files with missing lines	Coverage Δ
src/node.cc	`76.44% <60.00%> (-0.11%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

👌

nodejs-github-bot · 2026-08-28T06:51:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76620/

nodejs-github-bot · 2026-08-29T13:28:50Z

Landed in 452c8c5

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bitpshr · 2026-08-27T13:20:35Z

Fixes: #65534

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step, which defaults to 32. Allocating a buffer larger than that is a legitimate thing to do in Node, and it should raise a RangeError rather than terminate the process:

# Fatal error in , line 0
# Check failed: change_in_bytes < kMaxReasonableBytes.

This defaults the flag to 0 unless the user supplied a value, next to the other V8 defaults Node already sets explicitly. Per @Renegade334 on the issue, the 32 GB limit is a Chromium oriented sanity check rather than something Node wants to inherit.

The guard checks both the dashed and underscored spellings, since V8 accepts either, and appends only when neither is present so an explicit --external-memory-max-reasonable-size=N still wins.

On testing: reproducing the real thing needs more than 32 GB of RAM, which I do not have, so I verified against a lowered threshold instead. --external-memory-max-reasonable-size=1 plus a 2 GB allocation produces the identical fatal check, and the same allocation succeeds once the flag defaults to 0. The test covers the override path rather than the new default, because asserting the default is gone would need a >32 GB allocation in CI. I confirmed the test fails if the appended flag clobbers a user supplied value, so it does catch the case it is there for.

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: nodejs#65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-08-27T13:20:41Z

Review requested:

@nodejs/startup

codecov · 2026-08-27T15:07:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (9baabd4) to head (efc3936).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65589 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 751 751 Lines 254875 254880 +5 Branches 48108 48126 +18 ==========================================
- Hits 229579 229574 -5 - Misses 16466 16496 +30 + Partials 8830 8810 -20

Files with missing lines	Coverage Δ
src/node.cc	`76.44% <60.00%> (-0.11%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

👌

nodejs-github-bot · 2026-08-28T06:51:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76620/

nodejs-github-bot · 2026-08-29T13:28:50Z

Landed in 452c8c5

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bitpshr · 2026-08-27T13:20:35Z

Fixes: #65534

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step, which defaults to 32. Allocating a buffer larger than that is a legitimate thing to do in Node, and it should raise a RangeError rather than terminate the process:

# Fatal error in , line 0
# Check failed: change_in_bytes < kMaxReasonableBytes.

This defaults the flag to 0 unless the user supplied a value, next to the other V8 defaults Node already sets explicitly. Per @Renegade334 on the issue, the 32 GB limit is a Chromium oriented sanity check rather than something Node wants to inherit.

The guard checks both the dashed and underscored spellings, since V8 accepts either, and appends only when neither is present so an explicit --external-memory-max-reasonable-size=N still wins.

On testing: reproducing the real thing needs more than 32 GB of RAM, which I do not have, so I verified against a lowered threshold instead. --external-memory-max-reasonable-size=1 plus a 2 GB allocation produces the identical fatal check, and the same allocation succeeds once the flag defaults to 0. The test covers the override path rather than the new default, because asserting the default is gone would need a >32 GB allocation in CI. I confirmed the test fails if the appended flag clobbers a user supplied value, so it does catch the case it is there for.

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: nodejs#65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-08-27T13:20:41Z

Review requested:

@nodejs/startup

codecov · 2026-08-27T15:07:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (9baabd4) to head (efc3936).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65589 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 751 751 Lines 254875 254880 +5 Branches 48108 48126 +18 ==========================================
- Hits 229579 229574 -5 - Misses 16466 16496 +30 + Partials 8830 8810 -20

Files with missing lines	Coverage Δ
src/node.cc	`76.44% <60.00%> (-0.11%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

👌

nodejs-github-bot · 2026-08-28T06:51:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76620/

nodejs-github-bot · 2026-08-29T13:28:50Z

Landed in 452c8c5

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bitpshr · 2026-08-27T13:20:35Z

Fixes: #65534

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step, which defaults to 32. Allocating a buffer larger than that is a legitimate thing to do in Node, and it should raise a RangeError rather than terminate the process:

# Fatal error in , line 0
# Check failed: change_in_bytes < kMaxReasonableBytes.

This defaults the flag to 0 unless the user supplied a value, next to the other V8 defaults Node already sets explicitly. Per @Renegade334 on the issue, the 32 GB limit is a Chromium oriented sanity check rather than something Node wants to inherit.

The guard checks both the dashed and underscored spellings, since V8 accepts either, and appends only when neither is present so an explicit --external-memory-max-reasonable-size=N still wins.

On testing: reproducing the real thing needs more than 32 GB of RAM, which I do not have, so I verified against a lowered threshold instead. --external-memory-max-reasonable-size=1 plus a 2 GB allocation produces the identical fatal check, and the same allocation succeeds once the flag defaults to 0. The test covers the override path rather than the new default, because asserting the default is gone would need a >32 GB allocation in CI. I confirmed the test fails if the appended flag clobbers a user supplied value, so it does catch the case it is there for.

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: nodejs#65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-08-27T13:20:41Z

Review requested:

@nodejs/startup

codecov · 2026-08-27T15:07:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (9baabd4) to head (efc3936).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65589 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 751 751 Lines 254875 254880 +5 Branches 48108 48126 +18 ==========================================
- Hits 229579 229574 -5 - Misses 16466 16496 +30 + Partials 8830 8810 -20

Files with missing lines	Coverage Δ
src/node.cc	`76.44% <60.00%> (-0.11%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

👌

nodejs-github-bot · 2026-08-28T06:51:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76620/

nodejs-github-bot · 2026-08-29T13:28:50Z

Landed in 452c8c5

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bitpshr · 2026-08-27T13:20:35Z

Fixes: #65534

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step, which defaults to 32. Allocating a buffer larger than that is a legitimate thing to do in Node, and it should raise a RangeError rather than terminate the process:

# Fatal error in , line 0
# Check failed: change_in_bytes < kMaxReasonableBytes.

This defaults the flag to 0 unless the user supplied a value, next to the other V8 defaults Node already sets explicitly. Per @Renegade334 on the issue, the 32 GB limit is a Chromium oriented sanity check rather than something Node wants to inherit.

The guard checks both the dashed and underscored spellings, since V8 accepts either, and appends only when neither is present so an explicit --external-memory-max-reasonable-size=N still wins.

On testing: reproducing the real thing needs more than 32 GB of RAM, which I do not have, so I verified against a lowered threshold instead. --external-memory-max-reasonable-size=1 plus a 2 GB allocation produces the identical fatal check, and the same allocation succeeds once the flag defaults to 0. The test covers the override path rather than the new default, because asserting the default is gone would need a >32 GB allocation in CI. I confirmed the test fails if the appended flag clobbers a user supplied value, so it does catch the case it is there for.

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: nodejs#65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-08-27T13:20:41Z

Review requested:

@nodejs/startup

codecov · 2026-08-27T15:07:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (9baabd4) to head (efc3936).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65589 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 751 751 Lines 254875 254880 +5 Branches 48108 48126 +18 ==========================================
- Hits 229579 229574 -5 - Misses 16466 16496 +30 + Partials 8830 8810 -20

Files with missing lines	Coverage Δ
src/node.cc	`76.44% <60.00%> (-0.11%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

👌

nodejs-github-bot · 2026-08-28T06:51:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76620/

nodejs-github-bot · 2026-08-29T13:28:50Z

Landed in 452c8c5

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bitpshr · 2026-08-27T13:20:35Z

Fixes: #65534

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step, which defaults to 32. Allocating a buffer larger than that is a legitimate thing to do in Node, and it should raise a RangeError rather than terminate the process:

# Fatal error in , line 0
# Check failed: change_in_bytes < kMaxReasonableBytes.

This defaults the flag to 0 unless the user supplied a value, next to the other V8 defaults Node already sets explicitly. Per @Renegade334 on the issue, the 32 GB limit is a Chromium oriented sanity check rather than something Node wants to inherit.

The guard checks both the dashed and underscored spellings, since V8 accepts either, and appends only when neither is present so an explicit --external-memory-max-reasonable-size=N still wins.

On testing: reproducing the real thing needs more than 32 GB of RAM, which I do not have, so I verified against a lowered threshold instead. --external-memory-max-reasonable-size=1 plus a 2 GB allocation produces the identical fatal check, and the same allocation succeeds once the flag defaults to 0. The test covers the override path rather than the new default, because asserting the default is gone would need a >32 GB allocation in CI. I confirmed the test fails if the appended flag clobbers a user supplied value, so it does catch the case it is there for.

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: nodejs#65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-08-27T13:20:41Z

Review requested:

@nodejs/startup

codecov · 2026-08-27T15:07:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (9baabd4) to head (efc3936).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65589 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 751 751 Lines 254875 254880 +5 Branches 48108 48126 +18 ==========================================
- Hits 229579 229574 -5 - Misses 16466 16496 +30 + Partials 8830 8810 -20

Files with missing lines	Coverage Δ
src/node.cc	`76.44% <60.00%> (-0.11%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

👌

nodejs-github-bot · 2026-08-28T06:51:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76620/

nodejs-github-bot · 2026-08-29T13:28:50Z

Landed in 452c8c5

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bitpshr · 2026-08-27T13:20:35Z

Fixes: #65534

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step, which defaults to 32. Allocating a buffer larger than that is a legitimate thing to do in Node, and it should raise a RangeError rather than terminate the process:

# Fatal error in , line 0
# Check failed: change_in_bytes < kMaxReasonableBytes.

This defaults the flag to 0 unless the user supplied a value, next to the other V8 defaults Node already sets explicitly. Per @Renegade334 on the issue, the 32 GB limit is a Chromium oriented sanity check rather than something Node wants to inherit.

The guard checks both the dashed and underscored spellings, since V8 accepts either, and appends only when neither is present so an explicit --external-memory-max-reasonable-size=N still wins.

On testing: reproducing the real thing needs more than 32 GB of RAM, which I do not have, so I verified against a lowered threshold instead. --external-memory-max-reasonable-size=1 plus a 2 GB allocation produces the identical fatal check, and the same allocation succeeds once the flag defaults to 0. The test covers the override path rather than the new default, because asserting the default is gone would need a >32 GB allocation in CI. I confirmed the test fails if the appended flag clobbers a user supplied value, so it does catch the case it is there for.

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: nodejs#65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-08-27T13:20:41Z

Review requested:

@nodejs/startup

codecov · 2026-08-27T15:07:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (9baabd4) to head (efc3936).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65589 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 751 751 Lines 254875 254880 +5 Branches 48108 48126 +18 ==========================================
- Hits 229579 229574 -5 - Misses 16466 16496 +30 + Partials 8830 8810 -20

Files with missing lines	Coverage Δ
src/node.cc	`76.44% <60.00%> (-0.11%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

👌

nodejs-github-bot · 2026-08-28T06:51:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76620/

nodejs-github-bot · 2026-08-29T13:28:50Z

Landed in 452c8c5

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

bitpshr · 2026-08-27T13:20:35Z

Fixes: #65534

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step, which defaults to 32. Allocating a buffer larger than that is a legitimate thing to do in Node, and it should raise a RangeError rather than terminate the process:

# Fatal error in , line 0
# Check failed: change_in_bytes < kMaxReasonableBytes.

This defaults the flag to 0 unless the user supplied a value, next to the other V8 defaults Node already sets explicitly. Per @Renegade334 on the issue, the 32 GB limit is a Chromium oriented sanity check rather than something Node wants to inherit.

The guard checks both the dashed and underscored spellings, since V8 accepts either, and appends only when neither is present so an explicit --external-memory-max-reasonable-size=N still wins.

On testing: reproducing the real thing needs more than 32 GB of RAM, which I do not have, so I verified against a lowered threshold instead. --external-memory-max-reasonable-size=1 plus a 2 GB allocation produces the identical fatal check, and the same allocation succeeds once the flag defaults to 0. The test covers the override path rather than the new default, because asserting the default is gone would need a >32 GB allocation in CI. I confirmed the test fails if the appended flag clobbers a user supplied value, so it does catch the case it is there for.

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: nodejs#65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net>

nodejs-github-bot · 2026-08-27T13:20:41Z

Review requested:

@nodejs/startup

codecov · 2026-08-27T15:07:59Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (9baabd4) to head (efc3936).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #65589 +/- ##
==========================================
- Coverage 90.07% 90.07% -0.01% 
==========================================
Files 751 751 Lines 254875 254880 +5 Branches 48108 48126 +18 ==========================================
- Hits 229579 229574 -5 - Misses 16466 16496 +30 + Partials 8830 8810 -20

Files with missing lines	Coverage Δ
src/node.cc	`76.44% <60.00%> (-0.11%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Renegade334

👌

nodejs-github-bot · 2026-08-28T06:51:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76620/

nodejs-github-bot · 2026-08-29T13:28:50Z

Landed in 452c8c5

V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 27, 2026

addaleax approved these changes Aug 27, 2026
View reviewed changes

Renegade334 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 27, 2026

Renegade334 approved these changes Aug 27, 2026
View reviewed changes

Renegade334 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 27, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2026

This comment has been minimized.
Sign in to view

Renegade334 added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 28, 2026

legendecas approved these changes Aug 28, 2026
View reviewed changes

jasnell approved these changes Aug 29, 2026
View reviewed changes

nodejs-github-bot merged commit 452c8c5 into nodejs:mainAug 29, 2026
113 of 115 checks passed

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 29, 2026

This was referenced Sep 2, 2026
deps: update V8 to 15.2 #65161
Open
build: derive V8_LOGGING_LEVEL from dcheck_always_on #65744
Open