Uh oh!
There was an error while loading. Please reload this page.
build: add --shared-perfetto flag - #65614
Open
aduh95 wants to merge 3 commits into
Open
Conversation
nodejs-github-bot
commented
Aug 28, 2026
Collaborator
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #65614 +/- ##
==========================================
- Coverage 90.17% 90.12% -0.06%
==========================================
Files 769 769 Lines 261448 261626 +178 Branches 49674 49668 -6 ==========================================
+ Hits 235759 235786 +27 - Misses 16736 16852 +116 - Partials 8953 8988 +35 🚀 New features to boost your workflow:
|
aduh95
marked this pull request as draft
August 28, 2026 13:43
aduh95force-pushed
the
shared-perfetto-sdk
branch
from
August 31, 2026 16:59
ac1e1e8 to
a040aaeCompareSigned-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95force-pushed
the
shared-perfetto-sdk
branch
from
September 4, 2026 13:34
a040aae to
0242613Compareaduh95
marked this pull request as ready for review
September 4, 2026 13:34
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95force-pushed
the
shared-perfetto-sdk
branch
from
September 4, 2026 14:18
0a435be to
b84cf45Compare
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Sep 4, 2026
Collaborator
nodejs-github-bot
commented
Sep 4, 2026
Collaborator
nodejs-github-bot
commented
Sep 4, 2026
Collaborator
Contributor
Changelog@@ -1301,0 +1302,8 @@+/nix/store/zfisa71cs2rc5qwd7wv89v54gd48knz5-perfetto-sdk-58.2 (aarch64-darwin)+/nix/store/5gg54qf3b7xk32rshsnamlg0d21imazb-perfetto-sdk-58.2 (aarch64-linux)+/nix/store/sy3bgw5f9g8g0zwbxns3qknab5ncb8y9-perfetto-sdk-58.2 (x86_64-darwin)+/nix/store/dy9bqw5rzzcaj7nbspq63gxcvvhd2s4i-perfetto-sdk-58.2 (x86_64-linux)+/nix/store/riqv60hi34gjsfk8cbvgpm15jcwnx30y-perfetto-sdk-58.2-dev (aarch64-darwin)+/nix/store/c2hj3vkrjg3vp5gm7cj573afwgnvgn82-perfetto-sdk-58.2-dev (aarch64-linux)+/nix/store/b74ljrh1z52l01636wblrlgxhajir4ik-perfetto-sdk-58.2-dev (x86_64-darwin)+/nix/store/k7k45cp5mj2qdrr7h9zkm24549amgjh7-perfetto-sdk-58.2-dev (x86_64-linux)@@ -1494,0 +1503,4 @@+/nix/store/dmcp8nf832l2fbhhbac84bq4prrlk1nq-protobuf-34.1 (x86_64-darwin)+/nix/store/wylvda2p4ab62dzzsgppbclpmh4j2f8r-protobuf-35.1 (aarch64-darwin)+/nix/store/14zdwpp05sjf7813mcjjzhgl816hjbqj-protobuf-35.1 (aarch64-linux)+/nix/store/9d8d0spap5fb4d4hkxliag8zlfhjcg67-protobuf-35.1 (x86_64-linux)@@ -1588,0 +1601,8 @@+/nix/store/m59bb6fx8i7q9ar970x8y4pqky31z9fi-re2-2025-11-05 (aarch64-darwin)+/nix/store/q2wb70xl8vf69880ym2pilc9fpp5i7zp-re2-2025-11-05 (aarch64-linux)+/nix/store/fh849rr6slz7d44xdbi1556ama6g5hvm-re2-2025-11-05 (x86_64-darwin)+/nix/store/3x5532sa2gihl6gqxmi38vrmax01cwxz-re2-2025-11-05 (x86_64-linux)+/nix/store/ysvwsxmz1vyv28jnplfk07s6ys6cb013-re2-2025-11-05-dev (aarch64-darwin)+/nix/store/ywzpib7jl9djfbhvlf8pkd1pbhjcbb46-re2-2025-11-05-dev (aarch64-linux)+/nix/store/dvzkr8dc8m5lmr4vvkpga60bzgwacq2f-re2-2025-11-05-dev (x86_64-darwin)+/nix/store/yxak24k0j97addadfrag61qbc97fq5i7-re2-2025-11-05-dev (x86_64-linux) |
nodejs-github-bot
commented
Sep 4, 2026
Collaborator
jasnell
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted to draft, I need to investigate the abseil version conflict