Uh oh!
There was an error while loading. Please reload this page.
build: add --shared-abseil configure flag - #65682
Merged
Merged
Conversation
nodejs-github-bot
commented
Aug 31, 2026
Collaborator
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #65682 +/- ##
==========================================
+ Coverage 90.12% 90.14% +0.02%
==========================================
Files 769 769 Lines 261448 261448 Branches 49638 49632 -6 ==========================================
+ Hits 235633 235688 +55 + Misses 16829 16792 -37 + Partials 8986 8968 -18 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Changelog@@ -16,0 +17,8 @@+/nix/store/y920274366mm39dly3ia2i3wsccpn51d-abseil-cpp-20260107.1 (aarch64-darwin)+/nix/store/3qjql2462isf3jwsykmq1869dcq7y1ga-abseil-cpp-20260107.1 (aarch64-linux)+/nix/store/g5bfb54qhcprz6fbwy6y0344gyhdq39n-abseil-cpp-20260107.1 (x86_64-darwin)+/nix/store/l6gapc4fk3sk0jw4nl0a2vv5kg524pyp-abseil-cpp-20260107.1 (x86_64-linux)+/nix/store/q72vmagbml3b8rz7l66msrll11p326jz-abseil-cpp-20260107.1-dev (aarch64-darwin)+/nix/store/bx5779p5qm7jq21n7ikcwrmxz6zyln98-abseil-cpp-20260107.1-dev (aarch64-linux)+/nix/store/s84wwacmp88nld1znzjkrn3s0gsg930c-abseil-cpp-20260107.1-dev (x86_64-darwin)+/nix/store/ndpd5dd1gsza5mw34cy3024zfm28hds5-abseil-cpp-20260107.1-dev (x86_64-linux) |
legendecas
approved these changes
Sep 2, 2026
nodejs-github-bot
commented
Sep 2, 2026
Collaborator
nodejs-github-bot
commented
Sep 2, 2026
Collaborator
nodejs-github-bot
commented
Sep 2, 2026
Collaborator
nodejs-github-bot
commented
Sep 2, 2026
Collaborator
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#65682 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
panva
approved these changes
Sep 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
aduh95
commented
Sep 4, 2026
ContributorAuthor
Landed in 0df3c02 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A requirement for #65614 (abseil is a requirement of both perfetto and V8, and it needs to be the same version)