build: add `--shared-highway` configure flag by aduh95 · Pull Request #65686 · nodejs/node

aduh95 · 2026-08-31T15:51:15Z

V8 supports it, we might as well

nodejs-github-bot · 2026-08-31T15:51:20Z

Review requested:

@nodejs/actions
@nodejs/gyp
@nodejs/v8-update

codecov · 2026-08-31T18:09:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (ddc0a0a) to head (1e9fd95).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #65686 +/- ##
==========================================
+ Coverage 90.12% 90.17% +0.04% 
==========================================
Files 769 769 Lines 261448 261448 Branches 49638 49674 +36 ==========================================
+ Hits 235633 235759 +126 + Misses 16829 16736 -93 + Partials 8986 8953 -33

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-08-31T22:09:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76784/

nodejs-github-bot · 2026-08-31T22:09:41Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7333/

nodejs-github-bot · 2026-08-31T22:10:02Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7333/

nodejs-github-bot · 2026-08-31T22:10:03Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7333/

nodejs-github-bot · 2026-09-01T11:26:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76818/

github-actions · 2026-09-03T21:13:30Z

Platform	Number of requisites	Proportion of new derivations
`x86_64-linux`	488 -> 489 => +1	1 / 489 = 0.2%
`aarch64-linux`	489 -> 490 => +1	1 / 490 = 0.2%
`x86_64-darwin`	428 -> 429 => +1	1 / 429 = 0.2%
`aarch64-darwin`	431 -> 432 => +1	1 / 432 = 0.2%
Total	1836 -> 1840 => +4	4 / 1840 = 0.2%

Changelog

@@ -617,0 +618,4 @@+/nix/store/9ps8zgr1ayyb0xsfjgc5l4fj5cl6580l-libhwy-1.3.0 (x86_64-darwin)+/nix/store/mv5xsa097plw3k09r541c31xg0ma9r6i-libhwy-1.4.0 (aarch64-darwin)+/nix/store/l71xwd2dvawcswgpi64pmpvki33fm8bh-libhwy-1.4.0 (aarch64-linux)+/nix/store/y7llycqq0c2g83bir7sbqc2970lzl9vp-libhwy-1.4.0 (x86_64-linux)

nodejs-github-bot · 2026-09-04T07:40:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76948/

nodejs-github-bot · 2026-09-04T07:40:45Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7341/

nodejs-github-bot · 2026-09-04T07:41:07Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7341/

nodejs-github-bot · 2026-09-04T07:41:10Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7341/

panva

RSLGTM

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#65682 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#65686 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 · 2026-09-04T13:32:15Z

Landed in 1e9fd95

This comment was marked as outdated.
Sign in to view

aduh95 requested a review from legendecas September 3, 2026 11:50

legendecas reviewed Sep 3, 2026
View reviewed changes

Comment threadtools/v8_gypfiles/v8.gyp Outdated

This comment was marked as outdated.
Sign in to view

aduh95 force-pushed the shared-hwy branch from 150beb5 to 92a8cd0Compare September 3, 2026 17:47

This comment was marked as outdated.
Sign in to view

legendecas approved these changes Sep 4, 2026
View reviewed changes

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2026

aduh95 requested a review from richardlau September 4, 2026 11:31

panva approved these changes Sep 4, 2026
View reviewed changes

build: add --shared-abseil configure flag
0df3c02
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#65682 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

build: add --shared-highway configure flag
1e9fd95
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#65686 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

aduh95 force-pushed the shared-hwy branch from e0693ab to 1e9fd95Compare September 4, 2026 13:31

panva approved these changes Sep 4, 2026
View reviewed changes

aduh95 merged commit 1e9fd95 into nodejs:mainSep 4, 2026
25 checks passed

aduh95 deleted the shared-hwy branch September 4, 2026 13:32

This comment was marked as off-topic.
Sign in to view

Uh oh!

Uh oh!

Conversation

aduh95 commented Aug 31, 2026

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

This comment was marked as outdated.

codecovBot commented Aug 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

nodejs-github-bot commented Aug 31, 2026

Uh oh!

nodejs-github-bot commented Sep 1, 2026

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actionsBot commented Sep 3, 2026

Uh oh!

nodejs-github-bot commented Sep 4, 2026

Uh oh!

nodejs-github-bot commented Sep 4, 2026

Uh oh!

nodejs-github-bot commented Sep 4, 2026

Uh oh!

nodejs-github-bot commented Sep 4, 2026

Uh oh!

panva left a comment

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Sep 4, 2026

Uh oh!

Uh oh!

This comment was marked as off-topic.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecovBot commented Aug 31, 2026•
edited
Loading