Uh oh!
There was an error while loading. Please reload this page.
src: move and update comment about 'node.js' compilation. - #7277
Closed
danbev wants to merge 4 commits into
Closed
Conversation
Currently the comment regarding execution of src/node.js seems to refer to the file before the refactorings done in ec6af31. Also, it looks like the comment itself might have "drifted" a little in the file. Updated the comment to refer to the lib/internal/bootstrap_node.js file, moved it closer to the compilation step, and updated the name that is generated in node_natives.h.
| // Compile, execute the lib/internal/bootstrap_node.js file. (Which was | ||
| // included as static C string in node_natives.h. | ||
| // 'internal_bootstrap_node_native is the string containing that source code.) | ||
| Local<String> script_name = FIXED_ONE_BYTE_STRING(env->isolate(), "node.js"); |
Contributor
There was a problem hiding this comment.
Perhaps this script name should be updated too since it has been named bootstrap_node.js for some time now?
ContributorAuthor
There was a problem hiding this comment.
I'll take a stab at changing this to bootstrap_node.js.
| try_catch.SetVerbose(false); | ||
| // Execute the lib/internal/bootstrap_node.js file which was included as a | ||
| // static in node_natives.h by node_js2c. 'internal_bootstrap_node_native' |
cjihrig
commented
Jun 14, 2016
Contributor
Don't forget about #7277 (comment) |
| // is the string containing that source code. | ||
| Local<String> script_name = FIXED_ONE_BYTE_STRING(env->isolate(), "node.js"); | ||
| Local<String> script_name = FIXED_ONE_BYTE_STRING(env->isolate(), | ||
| "bootstrap_node.js"); |
Contributor
There was a problem hiding this comment.
Can you line up the opening " with the e in env on the previous line.
mscdex
commented
Jun 14, 2016
Contributor
| Local<String> script_name = FIXED_ONE_BYTE_STRING(env->isolate(), "node.js"); | ||
| // Execute the lib/internal/bootstrap_node.js file which was included as a | ||
| // static in node_natives.h by node_js2c. 'internal_bootstrap_node_native' |
cjihrig
commented
Jun 15, 2016
Contributor
The CI had a Jenkins failure, and some Alpine failures which have since been corrected. LGTM |
mscdex
commented
Jun 15, 2016
Contributor
LGTM |
danbev
commented
Jun 16, 2016
ContributorAuthor
cjihrig pushed a commit
that referenced
this pull request
Jun 17, 2016
This commit updates the node.js script name to reflect its actual name, which is now bootstrap_node.js. This commit also fixes the requisite message tests, and relocates a comment which seems to have drifted. PR-URL: #7277 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
cjihrig
commented
Jun 17, 2016
Contributor
Landed in 81b6882. Thanks! |
evanlucas pushed a commit
that referenced
this pull request
Jun 27, 2016
This commit updates the node.js script name to reflect its actual name, which is now bootstrap_node.js. This commit also fixes the requisite message tests, and relocates a comment which seems to have drifted. PR-URL: #7277 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
Merged
MylesBorins
commented
Jul 11, 2016
Contributor
@cjihrig lts? |
cjihrig
commented
Jul 12, 2016
Contributor
No, I believe this is accurate in v4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
Currently the comment regarding execution of src/node.js seems to refer
to the file before the refactorings done in ec6af31. Also, it looks like
the comment itself might have "drifted" a little in the file.
Updated the comment to refer to the lib/internal/bootstrap_node.js file,
moved it closer to the compilation step, and updated the name that is
generated in node_natives.h.