Uh oh!
There was an error while loading. Please reload this page.
test: add test for exec() known issue - #7375
Closed
Trott wants to merge 4 commits into
Closed
Conversation
Trott
commented
Jun 22, 2016
MemberAuthor
2 tasks
| const assert = require('assert'); | ||
| const exec = require('child_process').exec; | ||
| const keepAlive = setInterval(() => {}, 9999); |
Contributor
There was a problem hiding this comment.
Won't the child process keep the event loop open? Works for me locally without the timer.
cjihrig
commented
Jun 22, 2016
Contributor
LGTM with a couple comments. |
Trott
commented
Jun 23, 2016
MemberAuthor
@cjihrig Nits addressed. Also added a test for |
Trott
commented
Jun 23, 2016
MemberAuthor
cjihrig
commented
Jun 23, 2016
Contributor
Changes LGTM |
santigimeno
commented
Jun 23, 2016
Member
LGTM |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jun 24, 2016
PR-URL: nodejs#7375 Refs: nodejs#7342 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Trott
commented
Jun 24, 2016
MemberAuthor
Landed in c964574 |
Merged
Merged
MylesBorins
commented
Jul 11, 2016
Contributor
@Trott lts? |
Trott
commented
Jul 12, 2016
MemberAuthor
@thealphanerd If it lands and CI's cleanly, yes. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test child_process
Description of change
Refs: #7342