Uh oh!
There was an error while loading. Please reload this page.
Revert "child_process: measure buffer length in bytes" - #7377
Closed
Trott wants to merge 2 commits into
Closed
Conversation
4 tasks
rvagg
commented
Jun 27, 2016
Member
lgtm, I'm always up for a revert and new tests! |
jasnell
commented
Jun 27, 2016
Member
LGTM |
Trott
commented
Jun 27, 2016
MemberAuthor
Trott
commented
Jun 30, 2016
MemberAuthor
Closing. Revert was done as part of #7391 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
child_process
Description of change
This needs #7375 to land first.
Refs: #7342
The commit being reverted fixed a bug but accidentally introduced a breaking change. This reverts it. The change should be re-proposed as semver-major.