Uh oh!
There was an error while loading. Please reload this page.
deps: Add a way to create a function without a prototype - #7586
Conversation
This is an non-ABI breaking version port of https://chromium.googlesource.com/v8/v8/+/46428e45e9982a7490685ff1af6ffe680096c1a4 which adds an API that will be used by the inspector code.
jeisinger
commented
Jul 7, 2016
@nodejs/v8 |
bnoordhuis
commented
Jul 7, 2016
LGTM but can't it land in 5.1? That way we can pick it up through a regular upgrade. |
jeisinger
commented
Jul 7, 2016
@natorion wdyt Ben Noordhuis notifications@github.com schrieb am Do., 7. Juli 2016,
|
natorion
commented
Jul 8, 2016
Unfortunately V8 switched its branch builders to 5.2 and 5.3 already (V8 branched last week). There is no test coverage from the V8 side anymore and 5.1 is abandoned. |
MylesBorins
commented
Jul 8, 2016
@natorion this could be included in the LTS branch no? |
natorion
commented
Jul 8, 2016
Change of plans. @jeisinger can merge this one to 5.1 on the V8 repo and I will manually trigger the builders and have a look at the test results. |
jeisinger
commented
Jul 8, 2016
Pick up the latest branch-head for V8 5.1. Introduces a semver-minor overload of v8::Function::New() for use by v8_inspector. Refs: nodejs#7586 PR-URL: nodejs#7615 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Pick up the latest branch-head for V8 5.1. This branch brings in improved language support and performance improvements. For full details: http://v8project.blogspot.com/2016/04/v8-release-51.html * Picks up the latest branch head for 5.1 [1] * Edit v8 gitignore to allow trace_event copy * Update V8 DEP trace_event as per deps/v8/DEPS [2] [1] https://chromium.googlesource.com/v8/v8.git/+/5.1.281.75 [2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/c8c8665 Introduces a semver-minor overload of v8::Function::New() for use by v8_inspector. PR-URL: nodejs#8054 Refs: nodejs#7016 Refs: nodejs#7586 Refs: nodejs#7615 Reviewed-By: addaleax - Anna Henningsen <anna@addaleax.net> Reviewed-By: thealphanerd - Myles Borins <myles.borins@gmail.com> Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
deps/v8
Description of change
This is an non-ABI breaking version port of
https://chromium.googlesource.com/v8/v8/+/46428e45e9982a7490685ff1af6ffe680096c1a4
which adds an API that will be used by the inspector code.