Uh oh!
There was an error while loading. Please reload this page.
deps: update V8 to 5.1.281.75 - #7615
Merged
Merged
Conversation
cjihrig
commented
Jul 8, 2016
Contributor
LGTM |
1 similar comment
targos
commented
Jul 8, 2016
Member
LGTM |
indutny
commented
Jul 8, 2016
Member
Rubber-stamp LGTM |
MylesBorins
commented
Jul 8, 2016
Contributor
LGTM if CI is green |
Pick up the latest branch-head for V8 5.1. Introduces a semver-minor overload of v8::Function::New() for use by v8_inspector. Refs: nodejs#7586 PR-URL: nodejs#7615 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
bnoordhuis
commented
Jul 9, 2016
MemberAuthor
@Fishrock123 Out of curiosity, why did @nodejs-github-bot add the 'lib / src' label? All the changes were in deps/v8. |
MylesBorins
commented
Jul 9, 2016
Contributor
@bnoordhuis --> nodejs/github-bot#53 "labels: prevent deps from getting "lib / src" label " |
i5ting
commented
Jul 19, 2016
nice job |
ofrobots added a commit
to ofrobots/node
that referenced
this pull request
Aug 25, 2016
Pick up the latest branch-head for V8 5.1. This branch brings in improved language support and performance improvements. For full details: http://v8project.blogspot.com/2016/04/v8-release-51.html * Picks up the latest branch head for 5.1 [1] * Edit v8 gitignore to allow trace_event copy * Update V8 DEP trace_event as per deps/v8/DEPS [2] [1] https://chromium.googlesource.com/v8/v8.git/+/5.1.281.75 [2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/c8c8665 Introduces a semver-minor overload of v8::Function::New() for use by v8_inspector. PR-URL: nodejs#8054 Refs: nodejs#7016 Refs: nodejs#7586 Refs: nodejs#7615 Reviewed-By: addaleax - Anna Henningsen <anna@addaleax.net> Reviewed-By: thealphanerd - Myles Borins <myles.borins@gmail.com> Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick up the latest branch-head for V8 5.1. Introduces a semver-minor
overload of v8::Function::New() for use by v8_inspector.
Refs: #7586
R=@nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/3220/
CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/184/