Uh oh!
There was an error while loading. Please reload this page.
tools: increase lint coverage - #7647
Conversation
targos
commented
Jul 11, 2016
LGTM if CI is happy |
bnoordhuis
commented
Jul 11, 2016
LGTM |
Trott
commented
Jul 11, 2016
Trott
commented
Jul 12, 2016
Only failure in CI is a FreeBSD build failure. |
There was a problem hiding this comment.
Not sure. Perhaps this should use separate declarations and const instead, if it's already being changed?
i.e.
constassert=require('assert');constStream=require('stream');constinherits=require('util').inherits;The same for other variable declarations changed by this commit. Thoughts?
There was a problem hiding this comment.
I agree. We changed a ton of these multiline declarations a while ago, so it would be more consistent to also have seperate declarations here.
There was a problem hiding this comment.
Btw, eslint has a rule that could be used to forbid multiline declarations: one-var. Perhaps we should that on that sometime, if multiline declarations are already cleaned up in most places?
There was a problem hiding this comment.
one-var: [2, {uninitialized: never}] gives 26 errors, 4 in lib which looks acceptable. Also doing it for initialized variables gives over 100 though.
There was a problem hiding this comment.
@ChALkeR@silverwind nits addressed, rebased against master, force pushed, PTAL
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation.
Trott
commented
Jul 12, 2016
| test/tmp*/ | ||
| tools/doc/node_modules | ||
| tools/eslint | ||
| **/node_modules |
There was a problem hiding this comment.
I think this can be reduced to node_modules
silverwind
commented
Jul 12, 2016
LGTM, might wanna restart CI to make sure the last change works. |
Trott
commented
Jul 12, 2016
Seems like overkill, but Overkill is my middle name, so CI: https://ci.nodejs.org/job/node-test-pull-request/3270/ |
ChALkeR
commented
Jul 12, 2016
LGTM |
Trott
commented
Jul 12, 2016
Two build failures, but no test failures on CI. Running again: https://ci.nodejs.org/job/node-test-pull-request/3272/ |
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. PR-URL: nodejs#7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Trott
commented
Jul 13, 2016
Landed in cbbddc4 |
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins
commented
Aug 30, 2016
@Trott this is not landing cleanly, would you be willing to bacakport? |
Trott
commented
Aug 31, 2016
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
Extend linting to tools/license2rtf.js and any other JS that gets added
to the
toolsdirectory by default.This incidentally simplifies lint invocation and .eslintignore file.