Uh oh!
There was an error while loading. Please reload this page.
V4.x backport for tools: increase lint coverage (https://github.com/nodejs/node/pull/7647) - #8349
Closed
Trott wants to merge 1 commit into
Closed
V4.x backport for tools: increase lint coverage (https://github.com/nodejs/node/pull/7647)#8349Trott wants to merge 1 commit into
tools: increase lint coverage (https://github.com/nodejs/node/pull/7647)#8349Trott wants to merge 1 commit into
Conversation
Trott
commented
Aug 31, 2016
MemberAuthor
I built this on top of #8348 just to make sure it would land cleanly after that landed. |
jasnell
commented
Aug 31, 2016
Member
Small favor... can you include some of the specific detail of what is being backported in title or body of this PR so folks like myself don't have to click through to the other one to see what it's about ;-) LGTM if CI is green |
Trottforce-pushed
the
v4.x-lint-backport
branch
from
September 5, 2016 17:20
a09cdf9 to
0cfcee9CompareExtend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation.
Trottforce-pushed
the
v4.x-lint-backport
branch
from
September 5, 2016 17:23
0cfcee9 to
2d633b6CompareTrott
commented
Sep 5, 2016
MemberAuthor
Rebased, squashed, should be good to go. @thealphanerd |
tools: increase lint coverage (https://github.com/nodejs/node/pull/7647)Trott
commented
Sep 6, 2016
MemberAuthor
Description added to title and body of PR as requested. |
MylesBorins pushed a commit
that referenced
this pull request
Sep 7, 2016
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins
commented
Sep 7, 2016
Contributor
landed as 6123520 |
MylesBorins pushed a commit
that referenced
this pull request
Sep 28, 2016
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V4.x backport for #7647: