Uh oh!
There was an error while loading. Please reload this page.
doc: add npm link to Readme, general cleanup - #7769
Conversation
README.md missing npm link removed unnecessary comma formatted links for consistency and readability
| * [Website](https://nodejs.org/en/) | ||
| * [Contributing to the project](./CONTRIBUTING.md) | ||
| * Website: [nodejs.org](https://nodejs.org/en/) | ||
| * Project Contributing: [CONTRIBUTING.md](./CONTRIBUTING.md) |
There was a problem hiding this comment.
I am not a native English speaker, but «Project Contributing» does sound a little suspicious to me.
/cc @nodejs/documentation
removed unnecessary comma formatted links for consistency and readability
| uses an event-driven, non-blocking I/O model that makes it lightweight and | ||
| efficient. The Node.js package ecosystem, npm, is the largest ecosystem of open | ||
| source libraries in the world. | ||
| efficient. The Node.js package ecosystem [npm](https://github.com/npm/npm), |
There was a problem hiding this comment.
The comma before npm should not be removed.
There was a problem hiding this comment.
Maybe the link should rather go to https://www.npmjs.com/?
oscarmorrison
commented
Jul 16, 2016
Thanks @ChALkeR updated based on your feedback |
oscarmorrison
commented
Jul 17, 2016
| * [Website](https://nodejs.org/en/) | ||
| * [Contributing to the project](./CONTRIBUTING.md) | ||
| * Website: [nodejs.org](https://nodejs.org/en/) |
There was a problem hiding this comment.
I know this wasn't part of this PR, but does anyone know why we are sending everyone to /en?
There was a problem hiding this comment.
No reason, it was a copy-paste of what the default is.
This should be fixed.
npm link lgtm but I'm not sure about the other stuff and I would rather keep the newcomer links not verbose. |
cjihrig
commented
Jul 18, 2016
LGTM either way once the |
oscarmorrison
commented
Jul 18, 2016
How about just as: |
Trott
commented
Jul 19, 2016
Nitpick (ignore if you wish) but I believe a trailing slash is more correct here:
|
oscarmorrison
commented
Jul 20, 2016
Updated based on feedback |
oscarmorrison
commented
Jul 24, 2016
Ready to go? @Fishrock123@cjihrig@Trott@ChALkeR |
thefourtheye
commented
Jul 25, 2016
LGTM. |
addaleax
commented
Jul 27, 2016
Sorry to ask again, but could you rebase this? |
oscarmorrison
commented
Jul 27, 2016
I have closed this PR for a single commit branched from current master: |
Checklist
Affected core subsystem(s)
doc
Description of change
README.md missing npm link
formatted links for consistency and readability