Skip to content

doc: add npm link and cleanup Readme - #7894

Closed
oscarmorrison wants to merge 1 commit into
nodejs:masterfrom
oscarmorrison:patch-2
Closed

doc: add npm link and cleanup Readme#7894
oscarmorrison wants to merge 1 commit into
nodejs:masterfrom
oscarmorrison:patch-2

Conversation

@oscarmorrison

@oscarmorrisonoscarmorrison commented Jul 27, 2016

Copy link
Copy Markdown
Contributor

Note: this is a cleaned (single commit) of the PR #7769

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

README.md missing npm link
formatted links for consistency and readability

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 27, 2016
@oscarmorrisonoscarmorrison mentioned this pull request Jul 27, 2016
Closed
2 tasks
@addaleax

addaleax commented Jul 27, 2016

Copy link
Copy Markdown
Member

LGTM (and for whoever lands this, there already are reviews in #7769)

@oscarmorrison

oscarmorrison commented Jul 27, 2016

Copy link
Copy Markdown
ContributorAuthor

Hi @addaleax@Fishrock123@cjihrig@Trott@ChALkeR,
I decided to make it a single commit off the current master.
Old Ref: PR #7769

Is it ok to go?

@jasnell

jasnell commented Jul 29, 2016

Copy link
Copy Markdown
Member

LGTM

Just an fyi @oscarmorrison ... it most cases, multiple commits in a single PR can be "squashed" into a single commit without requiring a new PR to be opened. This can be done using git rebase -i (the -i is for "interactive" mode).

silverwind
silverwind reviewed Jul 29, 2016
View reviewed changes
Comment threadREADME.md Outdated

@silverwindsilverwindJul 29, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would leave two dead links at the bottom of the page. I'd prefer if you could just update the links on the bottom instead. The relative link to CONTRIBUTING.md could be problematic, how about just adding a link to the file on master instead?

@lpinca

lpinca commented Sep 25, 2016•
edited
Loading

Copy link
Copy Markdown
Member

I agree with @yorkie and @silverwind about the changed links. I think it would be better to just define them at the bottom.
Apart from this LGTM.

@oscarmorrison can you please rebase this against master? Thanks!

@oscarmorrison

oscarmorrison commented Sep 26, 2016

Copy link
Copy Markdown
ContributorAuthor

@lpinca You think I would remove the https://www.npmjs.com link?

@lpinca

lpinca commented Sep 26, 2016

Copy link
Copy Markdown
Member

No, I don't think so I would keep it for now.

@rvagg
rvaggforce-pushed the master branch 2 times, most recently from c133999 to 83c7a88CompareOctober 18, 2016 17:02
@oscarmorrison
oscarmorrisonforce-pushed the patch-2 branch 2 times, most recently from e8e52c5 to 590bc47CompareNovember 9, 2016 03:47
@oscarmorrison

oscarmorrison commented Nov 9, 2016

Copy link
Copy Markdown
ContributorAuthor

@lpinca@jasnell@addaleax
can we get this out. I have rebased against master, and removed the changes, as no longer needed(since there has been some readme changes since this original PR)

lpinca
lpinca reviewed Nov 9, 2016
View reviewed changes
Comment threadREADME.md Outdated

@lpincalpincaNov 9, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this line is too long, can you please wrap it a 80 chars? Thanks.

@oscarmorrison
doc: add npm link and cleanup Readme
ff9d5ec
missing the npm link in the readme.
wrap line
@oscarmorrison

oscarmorrison commented Nov 9, 2016

Copy link
Copy Markdown
ContributorAuthor

Thanks @lpinca i have made change and squashed commit.

@silverwind

silverwind commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

Thanks! Landed in d548d28.

silverwind pushed a commit that referenced this pull request Nov 9, 2016
@oscarmorrison@silverwind
doc: add npm link to README
d548d28
PR-URL: #7894
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@oscarmorrison@addaleax
doc: add npm link to README
6f513e0
PR-URL: #7894
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@oscarmorrison@MylesBorins
doc: add npm link to README
f707b00
PR-URL: #7894
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@oscarmorrison@MylesBorins
doc: add npm link to README
8380154
PR-URL: #7894
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@oscarmorrison@MylesBorins
doc: add npm link to README
51cae9a
PR-URL: #7894
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@oscarmorrison@MylesBorins
doc: add npm link to README
e393a51
PR-URL: #7894
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
+1 more reviewer
@silverwindsilverwindsilverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@oscarmorrison@addaleax@jasnell@lpinca@silverwind@yorkie@MylesBorins@nodejs-github-bot