[WIP] deps: upgrade libuv to 1.10.0 by saghul · Pull Request #8280 · nodejs/node

saghul · 2016-08-26T10:00:00Z

We are planning to release libuv 1.10.0 late next week, this is a placeholder for the update PR, to see if smoke comes out. A few more commits will land before we cut the release.

/cc @cjihrig

saghul · 2016-08-26T13:13:14Z

CI: https://ci.nodejs.org/job/node-test-commit/4780/

Fishrock123 · 2016-08-26T16:34:32Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/372/ (I think I have it right..)

saghul · 2016-08-26T16:51:46Z

I spotted a problem on Windows. A PR will land shortly so I'll update this.

saghul · 2016-08-27T09:14:42Z

Updated to fix the Windows build issue. Jenkins seems to be away for the weekend, I'll try to run a CI later.

jbergstroem · 2016-08-28T20:09:05Z

New CI: https://ci.nodejs.org/job/node-test-commit/4811/

saghul · 2016-08-29T08:05:42Z

CI is green except some RPi binary tests where Jenkins failed to mkdir for some reason.

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/374/ (hopefully I started this one right)

cjihrig · 2016-09-13T22:50:02Z

Fixes #4351 per #4351 (comment)

ronkorving · 2016-09-21T10:02:03Z

Can this land before Node 7?

saghul · 2016-09-21T10:18:15Z

I don't know, when does Node 7 land?

ronkorving · 2016-09-21T10:24:11Z

https://github.com/nodejs/node/milestone/15 seems to indicate a code freeze on September 30? Maybe @rvagg or @jasnell can give more details?

targos · 2016-09-21T10:45:51Z

Adding to the 7.0.0 milestone so we don't forget about it.

jasnell · 2016-09-21T15:53:41Z

The v7.x branch has already been cut. Anything that is semver-patch or semver-minor will be pulled over. Anything semver-major will require CTC review and approval to land in v7.x at this point. The first beta build will be going out today.

v7.0.0 is targeted for mid to late October depending largely on when V8 5.4 goes stable, so there's still a short amount of time (but not a lot)

saghul · 2016-09-21T16:14:13Z

@jasnell Ack. At the moment we are waiting on a patch to finalize z/OS support, other than that the release is ready.

saghul · 2016-09-23T10:28:12Z

Updated the PR with latest v1.x. Can someone help kick off a CITGM? Thanks!

evanlucas · 2016-09-23T10:30:33Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/394/

saghul · 2016-09-23T10:33:19Z

Thanks Evan!

seishun · 2016-10-02T14:19:05Z

I can confirm that this fixes #6763.

Fishrock123 · 2016-10-05T21:04:23Z

@saghul anything in here that needs to land in v7 specifically, or is this good for many minor / patch version?

cjihrig · 2016-10-05T21:06:10Z

Note, the release hasn't actually happened yet. It is still waiting on libuv/libuv#1037.

jasnell · 2016-10-17T17:22:26Z

@saghul ... ping... what's the status on this? Should this still be on the v7 milestone? Note that we're a week out from the actual 7.0.0 release.

seishun · 2016-10-17T18:04:09Z

If the libuv upgrade doesn't make into 7.0.0, when would the next window for that be?

jasnell · 2016-10-17T18:06:52Z

that depends on how significant the update will be. If it can be landed as a semver-minor, then it can land any time within v7.x after v7.0.0 is released. If it must be landed as a semver-major, it won't go into a release until next April

saghul · 2016-10-17T20:25:10Z

I should be a semver minor, v1x maintains backwards compatibility.

The status is we are waiting for some final issues to be ironed out in the
z/OS PR so it can land. I may try to push for a release before the end of
the week because then I'll go missing for a bit. Colin will take this over
most likely in that case.

On Oct 17, 2016 20:07, "James M Snell" notifications@github.com wrote:

that depends on how significant the update will be. If it can be landed as
a semver-minor, then it can land any time within v7.x after v7.0.0 is
released. If it must be landed as a semver-major, it won't go into a
release until next April
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8280 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATYGOHZE_PXqHQejwRp4ciQ-BgTC0oNks5q07l0gaJpZM4Jt7P0
.

jasnell · 2016-10-18T22:42:46Z

Ok, then I'm going to take this off the v7 milestone critical path. If it lands, great, if not, then it can go into a 7.x minor.

cjihrig · 2016-10-24T14:50:00Z

I'll be sending a replacement PR for this soon.

Fixes: nodejs#4351Fixes: nodejs#6763 Refs: nodejs#8280 PR-URL: nodejs#9267 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: #4351Fixes: #6763 Refs: #8280 PR-URL: #9267 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: nodejs/node#4351Fixes: nodejs/node#6763 Refs: nodejs/node#8280 PR-URL: nodejs/node#9267 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Aug 26, 2016

addaleax added the wip Issues and PRs that are still a work in progress. label Aug 26, 2016

saghul force-pushed the uv-1.10.0 branch from db776aa to 462491eCompare August 27, 2016 09:08

Trott force-pushed the master branch from b0df363 to c5ce7f4Compare September 21, 2016 00:09

targos added this to the 7.0.0 milestone Sep 21, 2016

WIP
055ebfd

saghul force-pushed the uv-1.10.0 branch from 462491e to 055ebfdCompare September 23, 2016 10:18

addaleax mentioned this pull request Oct 6, 2016
Revert "repl: disable Ctrl+C support on win32 for now" #8645
Closed
2 tasks

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88Compare October 18, 2016 17:02

jasnell removed this from the 7.0.0 milestone Oct 18, 2016

cjihrig closed this Oct 24, 2016

cjihrig removed the wip Issues and PRs that are still a work in progress. label Oct 24, 2016

cjihrig mentioned this pull request Oct 25, 2016
deps: upgrade libuv to 1.10.0 #9267
Merged
2 tasks

Uh oh!

Uh oh!

Conversation

saghul commented Aug 26, 2016

Uh oh!

saghul commented Aug 26, 2016

Uh oh!

Fishrock123 commented Aug 26, 2016

Uh oh!

saghul commented Aug 26, 2016

Uh oh!

saghul commented Aug 27, 2016

Uh oh!

jbergstroem commented Aug 28, 2016

Uh oh!

saghul commented Aug 29, 2016

Uh oh!

cjihrig commented Sep 13, 2016

Uh oh!

ronkorving commented Sep 21, 2016

Uh oh!

saghul commented Sep 21, 2016

Uh oh!

ronkorving commented Sep 21, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Sep 21, 2016

Uh oh!

jasnell commented Sep 21, 2016

Uh oh!

saghul commented Sep 21, 2016

Uh oh!

saghul commented Sep 23, 2016

Uh oh!

evanlucas commented Sep 23, 2016

Uh oh!

saghul commented Sep 23, 2016

Uh oh!

seishun commented Oct 2, 2016

Uh oh!

Fishrock123 commented Oct 5, 2016

Uh oh!

cjihrig commented Oct 5, 2016

Uh oh!

jasnell commented Oct 17, 2016

Uh oh!

seishun commented Oct 17, 2016

Uh oh!

jasnell commented Oct 17, 2016

Uh oh!

saghul commented Oct 17, 2016

Uh oh!

jasnell commented Oct 18, 2016

Uh oh!

cjihrig commented Oct 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ronkorving commented Sep 21, 2016•
edited
Loading