Revert "repl: disable Ctrl+C support on win32 for now" by addaleax · Pull Request #8645 · nodejs/node

addaleax · 2016-09-18T09:25:48Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

repl

Description of change

This reverts commit f59b888, since apparently libuv/libuv#1054 fixed the underlying problem that led to temporary disabling. I’d really like Windows users (@seishun? @bzoz?) to check that everything works as expected.

Ref: libuv/libuv#1054
Ref: #7837

seishun · 2016-09-18T10:57:43Z

Too early for that since libuv hasn't been upgraded.

addaleax · 2016-09-18T12:34:53Z

@seishun yeah, I realize that you’d have to apply the libuv change as well :)

cjihrig

LGTM, once it's time to land this. The libuv update should be in the near future.

bzoz

LGTM

jasnell

LGTM

jasnell · 2016-10-06T23:00:49Z

@addaleax ... ping :-)

addaleax · 2016-10-06T23:03:56Z

This is still blocked … presumably on #8280, but generally whatever libuv update includes the fix.

jasnell · 2016-10-06T23:08:16Z

ok, figured as much, just wanted to check in on it tho :-)

This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: nodejs#7837

addaleax · 2016-10-27T14:10:35Z

Rebased now that the libuv update has landed – this should work now.

seishun

LGTM. Can't reproduce #7837 anymore.

addaleax · 2016-10-27T14:25:42Z

@seishun 🎉 Thanks for confirming!

addaleax · 2016-10-30T17:55:34Z

CI: https://ci.nodejs.org/job/node-test-commit/5871/

addaleax · 2016-11-16T18:45:45Z

Landed in 2e28875

This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: #7837 PR-URL: #8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins · 2016-11-18T21:20:53Z

this should be backported when we update libuv to v1.10.x

addaleax · 2017-01-23T04:39:38Z

@MylesBorins This should land on v6.x (because the commit that is reverted by this PR is also in v6.x). But together with or after the libuv upgrade, yes.

This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: #7837 PR-URL: #8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins · 2017-01-23T06:17:57Z

thanks for the heads up

This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: #7837 PR-URL: #8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: nodejs#7837 PR-URL: nodejs#8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: #7837 PR-URL: #8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins · 2017-03-28T08:53:30Z

@addaleax it would appear that this shouldn't have landed on v6.x before the libuv upgrade

reverted the revert in 1978911

Full original message: Revert "repl: disable Ctrl+C support on win32 for now" This reverts commit 1d400ea. Fixes: nodejs#12085 Refs: nodejs#8645 PR-URL: nodejs#12123 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Full original message: Revert "repl: disable Ctrl+C support on win32 for now" The original fix was a stop gap until a libuv update landed. As the libuv update has not yet landed on v6.x the revert should not have landed. This commit reverts 1d400ea reapplying the stopgap fix until we update libuv. Fixes: #12085 Refs: #8645 PR-URL: #12123 Reviewed-By: Anna Henningsen <anna@addaleax.net>

This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: #7837 PR-URL: #8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: nodejs/node#7837 PR-URL: nodejs/node#8645 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added repl Issues and PRs related to the REPL subsystem. windows Issues and PRs related to the Windows platform. labels Sep 18, 2016

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Sep 18, 2016

addaleax added the blocked PRs that are blocked by other issues or PRs. label Sep 18, 2016

cjihrig approved these changes Sep 18, 2016
View reviewed changes

bzoz approved these changes Sep 19, 2016
View reviewed changes

addaleax added the dont-land-on-v4.x label Sep 20, 2016

jasnell approved these changes Sep 20, 2016
View reviewed changes

Trott force-pushed the master branch from b0df363 to c5ce7f4Compare September 21, 2016 00:10

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88Compare October 18, 2016 17:02

Revert "repl: disable Ctrl+C support on win32 for now"
c6b00bf
This reverts commit f59b888 now that the libuv update containing the proper fix has landed in 63243bc. Ref: libuv/libuv#1054 Ref: nodejs#7837

addaleax force-pushed the revert-repl-ctrl-c-win32 branch from 9a0fe1f to c6b00bfCompare October 27, 2016 14:06

addaleax added lts-watch-v6.x and removed blocked PRs that are blocked by other issues or PRs. labels Oct 27, 2016

seishun approved these changes Oct 27, 2016
View reviewed changes

addaleax closed this Nov 16, 2016

addaleax deleted the revert-repl-ctrl-c-win32 branch November 16, 2016 18:45

MylesBorins mentioned this pull request Nov 18, 2016
deps: upgrade libuv to 1.10.1 #9647
Merged
2 tasks

addaleax removed the dont-land-on-v6.x label Jan 23, 2017

MylesBorins added land-on-v6.x and removed lts-watch-v6.x labels Jan 23, 2017

MylesBorins mentioned this pull request Jan 24, 2017
v6.10.0 proposal #10974
Merged

italoacasas mentioned this pull request Jan 25, 2017
Proposal to update v7.x-staging #10989
Closed

italoacasas mentioned this pull request Jan 29, 2017
v7.5.0 proposal #11062
Merged

seishun mentioned this pull request Mar 28, 2017
Sometimes REPL cannot display the result #12085
Closed

MylesBorins added lts-watch-v6.x and removed land-on-v6.x labels Mar 28, 2017

MylesBorins mentioned this pull request Mar 28, 2017
deps: upgrade libuv to 1.10.0 #9267
Merged
2 tasks

MylesBorins mentioned this pull request Mar 29, 2017
Revert "Revert "repl: disable Ctrl+C support..." #12123
Merged

MylesBorins added land-on-v6.x and removed lts-watch-v6.x labels May 16, 2017

MylesBorins mentioned this pull request May 23, 2017
v6.11.0 proposal #13059
Merged

Uh oh!

Uh oh!

Conversation

addaleax commented Sep 18, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

seishun commented Sep 18, 2016

Uh oh!

addaleax commented Sep 18, 2016

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

bzoz left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Oct 6, 2016

Uh oh!

addaleax commented Oct 6, 2016

Uh oh!

jasnell commented Oct 6, 2016

Uh oh!

addaleax commented Oct 27, 2016

Uh oh!

seishun left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax commented Oct 27, 2016

Uh oh!

addaleax commented Oct 30, 2016

Uh oh!

addaleax commented Nov 16, 2016

Uh oh!

MylesBorins commented Nov 18, 2016

Uh oh!

addaleax commented Jan 23, 2017

Uh oh!

MylesBorins commented Jan 23, 2017

Uh oh!

MylesBorins commented Mar 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants