Skip to content

inspector: listen on process.debugPort - #8386

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:debug-port
Sep 14, 2016
Merged

inspector: listen on process.debugPort#8386
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:debug-port

Conversation

@cjihrig

@cjihrigcjihrig commented Sep 2, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

This commit consolidates the debugging port used by the inspector and Node's legacy debugger. This eliminates any chance of the two debuggers working side by side, but the inspector is currently an unofficial feature, and the legacy debugger should eventually be removed in favor of it.

Fixes: #8201

@cjihrigcjihrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 2, 2016
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 2, 2016
@cjihrigcjihrig added debugger inspector Issues and PRs related to the V8 inspector protocol labels Sep 2, 2016
@jasnell

jasnell commented Sep 2, 2016

Copy link
Copy Markdown
Member

LGTM if CI is green.

@addaleax

addaleax commented Sep 5, 2016

Copy link
Copy Markdown
Member

@cjihrig this needs a rebase :)

@cjihrig

cjihrig commented Sep 9, 2016

Copy link
Copy Markdown
ContributorAuthor

@addaleax rebased. Sorry for the delay. PTAL

@cjihrig

cjihrig commented Sep 9, 2016

Copy link
Copy Markdown
ContributorAuthor

And CI: https://ci.nodejs.org/job/node-test-pull-request/3991/

@cjihrig

cjihrig commented Sep 10, 2016

Copy link
Copy Markdown
ContributorAuthor

CI failures look unrelated. Since this is semver major, can another CTC member take a look? Perhaps @ofrobots?

@cjihrig

cjihrig commented Sep 12, 2016

Copy link
Copy Markdown
ContributorAuthor

ping @nodejs/ctc, please.

@bnoordhuis

bnoordhuis commented Sep 13, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@indutny

indutny commented Sep 13, 2016

Copy link
Copy Markdown
Member

LGTM

@cjihrig
inspector: listen on process.debugPort
9f1f7e2
This commit consolidates the debugging port used by the
inspector and Node's legacy debugger.
Fixes: nodejs#8201
PR-URL: nodejs#8386
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@cjihrig

cjihrig commented Sep 14, 2016

Copy link
Copy Markdown
ContributorAuthor

Final CI came back OK: https://ci.nodejs.org/job/node-test-pull-request/4040/

@cjihrig
cjihrig merged commit 9f1f7e2 into nodejs:masterSep 14, 2016
@cjihrig
cjihrig deleted the debug-port branch September 14, 2016 01:13
@ofrobots

ofrobots commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

Sorry that I missed the ping on this. The use of different ports between inspector and the old debug protocol was quite intentional due to (very valid) concerns raised by the Debugger implementers: See original PR: #7212.

@cjihrig

cjihrig commented Sep 15, 2016

Copy link
Copy Markdown
ContributorAuthor

Was this it?

We should use a different default port number for the new debug
protocol. This makes it easier for debuggers to guess which protocol
they are expected to use to talk to a node process with a debug
server.

Given that you can set the port manually, wouldn't debuggers have to be able to determine which protocol was being used with 100% certainty?

@ofrobots

ofrobots commented Sep 15, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

The issue is that some debuggers support both the old protocol and new, and when a user requests that the debugger attach to a running process at port 5858, the debugger has no way of knowing with protocol to use. I think this was originally requested by the VSCode folks, but I can't seem to find the discussion (/cc @joshgav, @nojvek).

@joshgav

joshgav commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

Discussion on side-by-side ongoing at #8464, would appreciate input from you all there.

@joshgav

joshgav commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

/cc @nodejs/diagnostics

@ofrobots

ofrobots commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

#8550.

@cjihrigcjihrig mentioned this pull request Oct 6, 2016
Merged
3 tasks
cjihrig added a commit to cjihrig/node that referenced this pull request Oct 10, 2016
@cjihrig
test: add cluster inspector debug port test
2aa2f85
This commit adds a test for the debug port value in cluster
workers using the inspector debugger.
Refs: nodejs#8201
Refs: nodejs#8386
Refs: nodejs#8550
PR-URL: nodejs#8958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@cjihrig@jasnell
test: add cluster inspector debug port test
96faba6
This commit adds a test for the debug port value in cluster
workers using the inspector debugger.
Refs: #8201
Refs: #8386
Refs: #8550
PR-URL: #8958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.inspectorIssues and PRs related to the V8 inspector protocolsemver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cjihrig@jasnell@addaleax@bnoordhuis@indutny@ofrobots@joshgav@nodejs-github-bot