Skip to content

test: add cluster inspector debug port test - #8958

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:test
Oct 10, 2016
Merged

test: add cluster inspector debug port test#8958
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:test

Conversation

@cjihrig

@cjihrigcjihrig commented Oct 6, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This commit adds a test for the debug port value in cluster workers using the inspector debugger.

Refs: #8201
Refs: #8386
Refs: #8550

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2016
@mscdexmscdex added cluster Issues and PRs related to the cluster subsystem. inspector Issues and PRs related to the V8 inspector protocol labels Oct 6, 2016
jasnell
jasnell approved these changes Oct 6, 2016
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imyller
imyller approved these changes Oct 7, 2016
View reviewed changes

@imyllerimyller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig

cjihrig commented Oct 10, 2016

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/4444/

@cjihrig
test: add cluster inspector debug port test
2aa2f85
This commit adds a test for the debug port value in cluster
workers using the inspector debugger.
Refs: nodejs#8201
Refs: nodejs#8386
Refs: nodejs#8550
PR-URL: nodejs#8958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@cjihrig
cjihrig merged commit 2aa2f85 into nodejs:masterOct 10, 2016
@cjihrig
cjihrig deleted the test branch October 10, 2016 15:38
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@cjihrig@jasnell
test: add cluster inspector debug port test
96faba6
This commit adds a test for the debug port value in cluster
workers using the inspector debugger.
Refs: #8201
Refs: #8386
Refs: #8550
PR-URL: #8958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@Fishrock123

Fishrock123 commented Oct 11, 2016

Copy link
Copy Markdown
Contributor

depends on #8386

@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
+1 more reviewer
@imyllerimyllerimyller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clusterIssues and PRs related to the cluster subsystem.inspectorIssues and PRs related to the V8 inspector protocoltestIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cjihrig@Fishrock123@bnoordhuis@jasnell@imyller@mscdex@nodejs-github-bot