inspector: add --inspect-brk flag by joshgav · Pull Request #8979 · nodejs/node

joshgav · 2016-10-07T23:07:40Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

inspector

Description of change

add --inspect-brk flag to provide same behavior as --debug-brk flag but for inspector. This allows complete separation of inspector and debugger (old debugger) flags.

cjihrig · 2016-10-07T23:23:43Z

If this gets merged, it should have tests.

eugeneo · 2016-10-07T23:35:32Z

https://github.com/nodejs/node/blob/master/test/inspector/inspector-helper.js#L404 - I think this flag can be used here.

cjihrig · 2016-10-12T14:13:49Z

Is this change necessary?

Strangely it didn't work for me without it. Let me check again though.

Okay figured out this one for the moment and fixed in latest commit. Now I need to figure out how to run code inside the worker process - which I'm not sure how to do since it breaks immediately with --inspect-brk, orphaning the child. Any ideas?

@joshgav I think you'd have to connect to the debugger to move past the break. There are other tests that exercise --debug-brk, but I don't think any that do it with the cluster module. Maybe this would be better to move to a separate test.

nojvek · 2016-10-20T16:19:40Z

Should this be visible in in the help text of node -h. Currently inspect is insider knowledge and not discoverable. Inspector has been merged in node for a while, is its status still experimental?

add an --inspect-brk option which breaks on first line of user script. same behavior as old --debug-brk flag. PR-URL: nodejs#8979 Reviewed-By: <tbd> Reviewed-By: <tbd>

joshgav · 2016-12-15T04:35:57Z

Rebased, moved test to a better place, and added docs to command-line help.

@cjihrig @ofrobots @eugeneo LGTY? Thanks!

joshgav · 2017-01-03T23:33:36Z

CI passed, going to land: https://ci.nodejs.org/job/node-test-pull-request/5690/

add an --inspect-brk option which breaks on first line of user script. same behavior as old --debug-brk flag. PR-URL: nodejs#8979 Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@keybase.io>

joshgav · 2017-01-03T23:51:24Z

landed in 6ff3b03

targos · 2017-01-28T10:12:26Z

This is semver-minor, right? Adding the label.

italoacasas · 2017-01-31T00:00:49Z

This is not landing clearly in v7, there is plan to backport this ?

joshgav · 2017-02-03T23:25:17Z

@italoacasas backported in #11149, which should be followed with #11114 to fix the misaligned help text. Would you do the landing on the 7.x branch, or would I do that? Thanks!

italoacasas · 2017-02-04T01:27:52Z

@joshgav for the v7.x-staging branch I think everyone can land the backport PR after the proper review. At this point is like landing something in master.

sam-github · 2017-04-22T03:44:12Z

+ " --inspect[=host:port] activate inspector on host:port\n"
+ " (default: 127.0.0.1:9229)\n"
+ " --inspect-brk[=host:port] activate inspector on host:port\n"
+ " and break at start of user script\n"


--inspect-port was omitted from the docs, see #12581

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 7, 2016

jasnell added the wip Issues and PRs that are still a work in progress. label Oct 7, 2016

mscdex mentioned this pull request Oct 7, 2016
inspector,doc: update hint text, add guide #8978
Closed
4 tasks

mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Oct 7, 2016

joshgav force-pushed the inspect-brk branch 2 times, most recently from 5f41374 to 24d5e39Compare October 11, 2016 20:41

joshgav force-pushed the inspect-brk branch from 24d5e39 to be4d83eCompare October 11, 2016 20:42

joshgav removed the wip Issues and PRs that are still a work in progress. label Oct 11, 2016

cjihrig reviewed Oct 12, 2016
View reviewed changes

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88Compare October 18, 2016 17:02

joshgav closed this Dec 15, 2016

joshgav force-pushed the inspect-brk branch from 43b1710 to 4a5c719Compare December 15, 2016 03:08

nodejs-github-bot added lts-watch-v6.x labels Dec 15, 2016

joshgav reopened this Dec 15, 2016

nodejs-github-bot added the dont-land-on-v7.x label Dec 15, 2016

joshgav added debugger and removed dont-land-on-v7.x labels Dec 15, 2016

joshgav force-pushed the inspect-brk branch from b80f0d6 to c2efd8aCompare December 15, 2016 04:31

nodejs-github-bot added the dont-land-on-v7.x label Dec 15, 2016

joshgav force-pushed the inspect-brk branch from 26ae822 to 94661b1Compare January 3, 2017 22:47

nodejs-github-bot added the dont-land-on-v7.x label Jan 3, 2017

joshgav force-pushed the inspect-brk branch from 94661b1 to acc16cfCompare January 3, 2017 22:52

nodejs-github-bot added the dont-land-on-v7.x label Jan 3, 2017

joshgav force-pushed the inspect-brk branch from acc16cf to 6ff3b03Compare January 3, 2017 23:49

nodejs-github-bot added the dont-land-on-v7.x label Jan 3, 2017

joshgav merged commit 6ff3b03 into nodejs:masterJan 3, 2017

joshgav mentioned this pull request Jan 9, 2017
Fixes #7065: cli help documentation for --debug and --debug-brk #7086
Closed
4 tasks

mscdex removed the dont-land-on-v7.x label Jan 13, 2017

This was referenced Jan 19, 2017
v7.x-staging update proposal #10886
Closed
Proposal to update v7.x-staging #10989
Closed

targos added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v4.x labels Jan 28, 2017

evanlucas added the dont-land-on-v7.x label Jan 31, 2017

This was referenced Feb 3, 2017
backport: backporting misaligned "node --help" text to v7.x staging #11114
Merged
src, inspector: add --inspect-brk option (backport 7.x) #11149
Merged

jasnell mentioned this pull request Apr 4, 2017
8.0.0 Release Proposal #12220
Closed

sam-github reviewed Apr 22, 2017
View reviewed changes

MylesBorins added backport-requested-v6.x and removed lts-watch-v6.x labels Sep 19, 2017

Uh oh!

Uh oh!

Conversation

joshgav commented Oct 7, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

cjihrig commented Oct 7, 2016

Uh oh!

eugeneo commented Oct 7, 2016

Uh oh!

cjihrigOct 12, 2016

Choose a reason for hiding this comment

Uh oh!

joshgavOct 13, 2016

Choose a reason for hiding this comment

Uh oh!

joshgavOct 14, 2016

Choose a reason for hiding this comment

Uh oh!

cjihrigOct 16, 2016

Choose a reason for hiding this comment

Uh oh!

nojvek commented Oct 20, 2016

Uh oh!

joshgav commented Dec 15, 2016

Uh oh!

joshgav commented Jan 3, 2017

Uh oh!

joshgav commented Jan 3, 2017

Uh oh!

targos commented Jan 28, 2017

Uh oh!

italoacasas commented Jan 31, 2017

Uh oh!

joshgav commented Feb 3, 2017

Uh oh!

italoacasas commented Feb 4, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sam-githubApr 22, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

joshgav commented Oct 7, 2016•
edited
Loading

italoacasas commented Feb 4, 2017•
edited
Loading