Uh oh!
There was an error while loading. Please reload this page.
doc: add the diagnostics team to cc for async_wrap - #9471
Conversation
sam-github
commented
Nov 4, 2016
LGTM |
addaleax
commented
Nov 4, 2016
/cc @nodejs/diagnostics |
Qard
commented
Nov 4, 2016
LGTM also |
joshgav
commented
Nov 4, 2016
LGTM |
Fishrock123
commented
Nov 4, 2016
I feel like that group has far more people than actually know in detail about it, maybe a separate team is more appropriate? (Also I guess I should be joining the Diagnostics WG...) |
AndreasMadsen
commented
Nov 4, 2016
Agreed. But isn't the list more about who to cc for issues, than who to cc for PR reviews? There are a lot of people in @nodejs/diagnostics who are |
Fishrock123
commented
Nov 4, 2016
@AndreasMadsen That does expose some ambiguity, but I originally made this with two things in mind:
General discussion is imo a bit more high level and idk where to put that exactly. |
AndreasMadsen
commented
Nov 4, 2016
@Fishrock123 I see. If the list is for PR reviews and similar then @nodejs/diagnostics is definitely too board. |
addaleax
commented
Nov 4, 2016
@AndreasMadsen so it is just you and @trevnorris then? |
cjihrig
left a comment
There was a problem hiding this comment.
This is something that we need, so LGTM once it's decided exactly who should be CCed :-)
Trott
commented
Nov 5, 2016
Nit: Except for the platform wildcard entry at the bottom, everything else in the list is in alphabetical (or at least alphabetical-ish) order, so perhaps this new entry should be placed alphabetically as well? |
AndreasMadsen
commented
Nov 5, 2016
@addaleax I think there are others. Maybe @Fishrock123 and @Qard? |
Fishrock123
commented
Nov 5, 2016
I think @trevnorris, @AndreasMadsen, and myself are probably the ones who best understand the implementation right now. |
15ba013 to
b6adbd3Compareaddaleax
commented
Nov 6, 2016
I’ve updated this with @trevnorris, @AndreasMadsen, @Fishrock123, @Qard and tried to address @Trott’s nit (which may have failed because I am not sure what exactly is supposed to be ordered alphabetically here) |
Qard
commented
Nov 20, 2016
Does anyone in @nodejs/diagnostics specifically object to getting notifications about async_wrap stuff? I mean, even if they aren't experts on the subject, I feel like basically everyone in the working group would have some interest in at least being notified of the developments relating to async_wrap. |
watson
commented
Nov 21, 2016
@Qard I'd love to get notifications on this |
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: nodejs#9467 (comment)
b6adbd3 to
d93c0f8Compareaddaleax
commented
Nov 26, 2016
@Qard Okay, I’ve switched this back to @nodejs/diagnostics. I guess we can still update the doc to be more selective if it turns out that this is too noisy. |
addaleax
commented
Dec 5, 2016
Landed in 62eee49 |
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: nodejs#9467 (comment) PR-URL: nodejs#9471 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Add a group of people to the “Who to CC in issues” list as the maintainers of `async_hooks`. Ref: #9467 (comment) PR-URL: #9471 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Add the nodejs/diagnostics team to the “Who to CC in issues” list
as the maintainers of
async_hooks.Ref: #9467 (comment)