Uh oh!
There was an error while loading. Please reload this page.
doc: changed order of invocations in example. - #9614
Closed
atripes wants to merge 1 commit into
Closed
Conversation
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined.
cjihrig
commented
Nov 15, 2016
Contributor
I'm not getting an error prior to this change. |
jasnell
commented
Nov 18, 2016
Member
Not getting an error either. That said, I prefer this ordering. |
cjihrig
commented
Nov 18, 2016
Contributor
Yea, I do prefer this order too. |
lpinca
approved these changes
Nov 19, 2016
lpinca
left a comment
Member
There was a problem hiding this comment.
LGTM with commit message fixed as I also don't get an error with current order.
cjihrig
reviewed
Nov 20, 2016
| console.error(e); | ||
| }); | ||
| req.end(); | ||
cjihrig
approved these changes
Nov 20, 2016
italoacasas pushed a commit
that referenced
this pull request
Nov 24, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
commented
Nov 24, 2016
Landed in 550a958 Thanks for the contribution @atrioom |
lpinca
commented
Nov 24, 2016
Member
@italoacasas the landed commit does not follow the commit message guidelines. |
italoacasas pushed a commit
that referenced
this pull request
Nov 24, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
commented
Nov 24, 2016
@lpinca I made some changes, I hope that one fit better. |
Member
@italoacasas not a biggie but the second line ("When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined.") is too long. Those lines should be wrapped at 72 chars. |
atripes
commented
Nov 25, 2016
Author
Hello and thank you for the help. I had this issue in a full grown application, I will try to reproduce it in a small test environment. Maybe add modules until I get the error. Thanks for accepting it anyways. |
addaleax pushed a commit
that referenced
this pull request
Dec 5, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 20, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 20, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined. PR-URL: #9614 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
When you call req.end() before you add .on listeners you get an Error that you can't call .on on undefined.