Skip to content

test: improve test-fs-read-stream.js - #9629

Closed
jennabelle wants to merge 1 commit into
nodejs:masterfrom
jennabelle:make-tests-more-clear
Closed

test: improve test-fs-read-stream.js#9629
jennabelle wants to merge 1 commit into
nodejs:masterfrom
jennabelle:make-tests-more-clear

Conversation

@jennabelle

@jennabellejennabelle commented Nov 16, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

tests: refactor to ES6 to strengthen tests

changed var to const, assert.equal() to assert.strictEqual()

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 16, 2016
@Fishrock123

Fishrock123 commented Nov 16, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/4856/

Trott
Trott approved these changes Nov 16, 2016
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnoordhuis

bnoordhuis commented Nov 16, 2016

Copy link
Copy Markdown
Member

@jennabelle Can you make the commit log conform to the house style? CONTRIBUTING.md outlines what it should look like. The first line should at least start with test: and not exceed 50 columns.

@jennabellejennabelle changed the title changed var to const, assert.equal() to assert.strictEqual()test: changed var to const, assert.equal() to assert.strictEqual()Nov 16, 2016
@jennabelle

jennabelle commented Nov 16, 2016

Copy link
Copy Markdown
ContributorAuthor

@bnoordhuis done, but pls let me know if there is something i missed.

@mscdexmscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 16, 2016
bnoordhuis
bnoordhuis approved these changes Nov 16, 2016
View reviewed changes

@bnoordhuisbnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM but you only updated the title of the pull request, not the commit, and it's still > 50 columns.

mhdawson
mhdawson approved these changes Nov 17, 2016
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided title is updated to meet commit guidelines.

@jennabellejennabelle changed the title test: changed var to const, assert.equal() to assert.strictEqual()test: change var to const, assert.equal() to assert.strictEqual()Nov 19, 2016
@jennabellejennabelle changed the title test: change var to const, assert.equal() to assert.strictEqual()test: refactor to ES6 to strengthen testsNov 19, 2016
@jennabelle

jennabelle commented Nov 19, 2016

Copy link
Copy Markdown
ContributorAuthor

@bnoordhuis@mhdawson sorry, i misunderstood earlier- just changed title to < 50 cols and commit log should conform to CONTRIBUTING.md guidelines now- pls let me know what u think

@fhinkel

fhinkel commented Nov 21, 2016

Copy link
Copy Markdown
Member

You need to change the commit message. Do that locally with git commit --amend and force push. To see if it worked, click at the top on "Commits(1)".

@gibfahn

gibfahn commented Nov 21, 2016•
edited
Loading

Copy link
Copy Markdown
Member

@jennabelle This is the bit you need to change:
image

Commit message could be something like this (second line optional):

test: improve test-fs-read-stream.js
Changed var to const and assert.equal() to assert.strictEqual()

@jennabelle

jennabelle commented Nov 27, 2016

Copy link
Copy Markdown
ContributorAuthor

@gibfahn@fhinkel@mhdawson@bnoordhuis Thanks for the direction, done.

screen shot 2016-11-27 at 12 51 07 am

@fhinkel

fhinkel commented Nov 27, 2016

Copy link
Copy Markdown
Member

LGTM Thanks!

bnoordhuis
bnoordhuis approved these changes Nov 28, 2016
View reviewed changes

@bnoordhuisbnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the commit log title is not the same as the pull request title.

@jennabellejennabelle changed the title test: refactor to ES6 to strengthen teststest: improve test-fs-read-stream.jsNov 28, 2016
@jennabelle

jennabelle commented Nov 28, 2016

Copy link
Copy Markdown
ContributorAuthor

@bnoordhuis Thx, done.

@mhdawson

mhdawson commented Dec 6, 2016

Copy link
Copy Markdown
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/5268/

gibfahn
gibfahn approved these changes Dec 7, 2016
View reviewed changes

@gibfahngibfahn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, LGTM

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 7, 2016
@jennabelle@Trott
test: improve test-fs-read-stream.js
29b2e88
var -> const
assert.equal() -> assert.strictEqual()
PR-URL: nodejs#9629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@Trott

Trott commented Dec 7, 2016

Copy link
Copy Markdown
Member

Landed in 29b2e88. Thanks for your patience and persistence! 🎉

@TrottTrott closed this Dec 7, 2016
addaleax pushed a commit that referenced this pull request Dec 8, 2016
@jennabelle@addaleax
test: improve test-fs-read-stream.js
e695862
var -> const
assert.equal() -> assert.strictEqual()
PR-URL: #9629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@jennabelle@addaleax
test: improve test-fs-read-stream.js
314b04d
var -> const
assert.equal() -> assert.strictEqual()
PR-URL: nodejs#9629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@italoacasasitaloacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@jennabelle@MylesBorins
test: improve test-fs-read-stream.js
70861d6
var -> const
assert.equal() -> assert.strictEqual()
PR-URL: #9629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@mhdawsonmhdawsonmhdawson approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fsIssues and PRs related to the fs subsystem / file system.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

15 participants

@jennabelle@Fishrock123@bnoordhuis@fhinkel@gibfahn@mhdawson@Trott@jasnell@lpinca@targos@cjihrig@mscdex@MylesBorins@addaleax@nodejs-github-bot