Uh oh!
There was an error while loading. Please reload this page.
test: fix flaky test-dgram-empty-packet & friends - #9724
Closed
Trott wants to merge 4 commits into
Closed
Conversation
Trott
commented
Nov 21, 2016
MemberAuthor
Trottforce-pushed
the
de-timer-ize
branch
2 times, most recently
from
November 21, 2016 19:25
f60c297 to
06c26b6Comparecjihrig
commented
Nov 21, 2016
Contributor
Looks like the CI had a hiccup on OS X, which is pretty relevant to this test. |
Trott
commented
Nov 21, 2016
MemberAuthor
@cjihrig Yeah, looks like the bug on OS X is still there on the verison of OS X in CI. Putting the skip-code back in... |
Trott
commented
Nov 21, 2016
MemberAuthor
Trott
commented
Nov 21, 2016
MemberAuthor
CI looks good. /cc @nodejs/testing @indutny |
santigimeno
commented
Nov 22, 2016
Member
The changes look good. I only see an issue with relying that every UDP message is going to be received by the server. This, though highly unlikely, could be a source of flakiness. |
Trottforce-pushed
the
de-timer-ize
branch
3 times, most recently
from
November 23, 2016 06:55
b33bfca to
c1c40fdCompareTrott
commented
Nov 23, 2016
MemberAuthor
@santigimeno I've wrapped the |
santigimeno
approved these changes
Nov 23, 2016
santigimeno
left a comment
Member
There was a problem hiding this comment.
LGTM with a couple of suggestions. Thanks!
Member
There was a problem hiding this comment.
maybe check that buffer is empty. Also s/bytes/info or even removing the 2nd argument if we're doing nothing with it
* Liberal use of common.mustCall()
* Rename test-dgram-empty-packet -> test-dgram-send-empty-packet
* Remove use of timers to avoid CI failures like seen in the Ref below:
```
not ok 237 parallel/test-dgram-empty-packet
---
duration_ms: 0.717
severity: fail
stack: |-
...
throw new Error('Timeout');
^
Error: Timeout
at Timeout._onTimeout
...
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
```
Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console:Trott
commented
Nov 24, 2016
MemberAuthor
Excellent suggestions from @santigimeno incorporated. CI again: https://ci.nodejs.org/job/node-test-pull-request/4978/ |
santigimeno
approved these changes
Nov 24, 2016
Trott
commented
Nov 24, 2016
MemberAuthor
Raspberry Pi failure in CI is a build failure and unrelated. |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 24, 2016
* Liberal use of common.mustCall()
* Rename test-dgram-empty-packet -> test-dgram-send-empty-packet
* Remove use of timers to avoid CI failures like seen in the Ref below:
```
not ok 237 parallel/test-dgram-empty-packet
---
duration_ms: 0.717
severity: fail
stack: |-
...
throw new Error('Timeout');
^
Error: Timeout
at Timeout._onTimeout
...
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
```
Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console:
PR-URL: nodejs#9724
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>Trott
commented
Nov 24, 2016
MemberAuthor
Landed in 9b0f53d |
addaleax pushed a commit
that referenced
this pull request
Dec 5, 2016
* Liberal use of common.mustCall()
* Rename test-dgram-empty-packet -> test-dgram-send-empty-packet
* Remove use of timers to avoid CI failures like seen in the Ref below:
```
not ok 237 parallel/test-dgram-empty-packet
---
duration_ms: 0.717
severity: fail
stack: |-
...
throw new Error('Timeout');
^
Error: Timeout
at Timeout._onTimeout
...
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
```
Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console:
PR-URL: #9724
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* Liberal use of common.mustCall()
* Rename test-dgram-empty-packet -> test-dgram-send-empty-packet
* Remove use of timers to avoid CI failures like seen in the Ref below:
```
not ok 237 parallel/test-dgram-empty-packet
---
duration_ms: 0.717
severity: fail
stack: |-
...
throw new Error('Timeout');
^
Error: Timeout
at Timeout._onTimeout
...
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
```
Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console:
PR-URL: nodejs#9724
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
* Liberal use of common.mustCall()
* Rename test-dgram-empty-packet -> test-dgram-send-empty-packet
* Remove use of timers to avoid CI failures like seen in the Ref below:
```
not ok 237 parallel/test-dgram-empty-packet
---
duration_ms: 0.717
severity: fail
stack: |-
...
throw new Error('Timeout');
^
Error: Timeout
at Timeout._onTimeout
...
at ontimeout (timers.js:365:14)
at tryOnTimeout (timers.js:237:5)
at Timer.listOnTimeout (timers.js:207:5)
```
Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console:
PR-URL: #9724
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test dgram
Description of change
Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console: