Skip to content

repl: preprocess only for defaultEval - #9752

Closed
princejwesley wants to merge 1 commit into
nodejs:masterfrom
princejwesley:repl.9743
Closed

repl: preprocess only for defaultEval#9752
princejwesley wants to merge 1 commit into
nodejs:masterfrom
princejwesley:repl.9743

Conversation

@princejwesley

@princejwesleyprincejwesley commented Nov 22, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

Description of change

Code preprocessing is applicable only for default
eval function. Therefore, Moved preprocess function
invocation inside defaultEval function.

Fixes: #9743

@nodejs-github-botnodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Nov 22, 2016
addaleax
addaleax approved these changes Nov 22, 2016
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI, thank you for doing this :)

Comment threadtest/parallel/test-repl-eval.js Outdated

@addaleaxaddaleaxNov 22, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest that you add a comment describing why this particular input was chosen?

@princejwesleyprincejwesleyNov 22, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 😄

@princejwesley

princejwesley commented Nov 22, 2016

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/4954/

YarnSphere
YarnSphere reviewed Nov 23, 2016
View reviewed changes
Comment threadlib/repl.js Outdated

@YarnSphereYarnSphereNov 23, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appending of the \n isn't needed for custom eval functions?
Because it was being appended before.

@princejwesleyprincejwesleyNov 23, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nunocastromartins Good point. \n was appended for most of the cases and it was done in same preprocess. I'll add \n for all cases as if eval function receives what user entered including the final enter.

CC: @Fishrock123

@Fishrock123

Fishrock123 commented Nov 23, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Last CI wasn't so happy...?

New: https://ci.nodejs.org/job/node-test-pull-request/4971/

@princejwesley

princejwesley commented Nov 23, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

New CI: https://ci.nodejs.org/job/node-test-pull-request/4974/
Another attempt : https://ci.nodejs.org/job/node-test-pull-request/4988/

@princejwesley

princejwesley commented Nov 27, 2016

Copy link
Copy Markdown
ContributorAuthor

@Fishrock123 CI is green 😄

@princejwesley

princejwesley commented Nov 28, 2016

Copy link
Copy Markdown
ContributorAuthor

@nodejs/collaborators I'll land this tomorrow if there is no objection.

@princejwesley

princejwesley commented Nov 30, 2016

Copy link
Copy Markdown
ContributorAuthor

@addaleax review the changes made after your approval.

@princejwesleyprincejwesley mentioned this pull request Nov 30, 2016
Closed
@not-an-aardvarknot-an-aardvark mentioned this pull request Dec 2, 2016
Merged
3 tasks
@princejwesley

princejwesley commented Dec 2, 2016

Copy link
Copy Markdown
ContributorAuthor

@nodejs/collaborators ping

addaleax
addaleax approved these changes Dec 2, 2016
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

(sorry, I was a bit busy here at NINA)

@princejwesley
repl: preprocess only for defaultEval
b345fab
Code preprocessing is applicable only for default
eval function. Therefore, Moved `preprocess` function
invocation inside `defaultEval` function.
Fixes: nodejs#9743
PR-URL: nodejs#9752
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@princejwesley

princejwesley commented Dec 3, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased, CI again: https://ci.nodejs.org/job/node-test-pull-request/5157/

princejwesley added a commit that referenced this pull request Dec 5, 2016
@princejwesley
repl: preprocess only for defaultEval
9366b8d
Code preprocessing is applicable only for default
eval function. Therefore, Moved `preprocess` function
invocation inside `defaultEval` function.
Fixes: #9743
PR-URL: #9752
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@princejwesley

princejwesley commented Dec 5, 2016

Copy link
Copy Markdown
ContributorAuthor

Landed in 9366b8

Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@princejwesley@Fishrock123
repl: preprocess only for defaultEval
6087e36
Code preprocessing is applicable only for default
eval function. Therefore, Moved `preprocess` function
invocation inside `defaultEval` function.
Fixes: #9743
PR-URL: #9752
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@princejwesleyJonathan Darling
repl: preprocess only for defaultEval
f908538
Code preprocessing is applicable only for default
eval function. Therefore, Moved `preprocess` function
invocation inside `defaultEval` function.
Fixes: nodejs#9743
PR-URL: nodejs#9752
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@princejwesley@MylesBorins
repl: preprocess only for defaultEval
86efc93
Code preprocessing is applicable only for default
eval function. Therefore, Moved `preprocess` function
invocation inside `defaultEval` function.
Fixes: #9743
PR-URL: #9752
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@princejwesley@MylesBorins
repl: preprocess only for defaultEval
aed2f35
Code preprocessing is applicable only for default
eval function. Therefore, Moved `preprocess` function
invocation inside `defaultEval` function.
Fixes: #9743
PR-URL: #9752
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@YarnSphereYarnSphereYarnSphere left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

replIssues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node REPL preprocessing input string for custom eval functions

6 participants

@princejwesley@Fishrock123@addaleax@YarnSphere@MylesBorins@nodejs-github-bot