Skip to content

deps: upgrade npm in LTS to 3.10.10 - #9847

Closed
iarna wants to merge 1 commit into
nodejs:v6.x-stagingfrom
npm:npm-3.10.10
Closed

deps: upgrade npm in LTS to 3.10.10#9847
iarna wants to merge 1 commit into
nodejs:v6.x-stagingfrom
npm:npm-3.10.10

Conversation

@iarna

@iarnaiarna commented Nov 29, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change

This release is really small, just a fix for a regression where failed optional dependencies in shrinkwraps could cause the entire install to fail. This also corrects the supported Node.js versions to include 0.12.

Changelogs

r: @jasnell
r: @Fishrock123

@iarnaiarna added dont-land-on-v4.x npm Issues and PRs related to the npm client dependency or the npm registry. labels Nov 29, 2016
@nodejs-github-botnodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. v6.x labels Nov 29, 2016
@Fishrock123

Fishrock123 commented Nov 30, 2016

Copy link
Copy Markdown
Contributor

I think this also needs to land on v7?

@Fishrock123

Fishrock123 commented Nov 30, 2016

Copy link
Copy Markdown
Contributor

LGTM even on v7

@MylesBorins

MylesBorins commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

I would say that until we have discussed v4 at the ctc meeting this should land on master and be backported to 7 / 6

thoughts?

@Fishrock123

Fishrock123 commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

@thealphanerd I agree. I'll handle it.

@Fishrock123
Fishrock123 changed the base branch from v6.x-staging to masterDecember 5, 2016 14:52
@Fishrock123
Fishrock123 changed the base branch from master to v6.x-stagingDecember 5, 2016 14:52
@Fishrock123

Fishrock123 commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

Landed in 95b238a on master, thanks!

@jasnell

jasnell commented Dec 5, 2016

Copy link
Copy Markdown
Member

The commit appears to have landed without metadata and I'm curious about the base branch changes. This PR says it was intended for v6.x-staging but landed on master?

@Fishrock123

Fishrock123 commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

force-pushed, landed in c8cf71d now.

@jasnell To answer your other question, this is effectively targeting the wrong branch.

Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@iarna@Fishrock123
deps: upgrade npm to 3.10.10
c8cf71d
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@iarna@Fishrock123
deps: upgrade npm to 3.10.10
4bcda63
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@iarnaJonathan Darling
deps: upgrade npm to 3.10.10
086389d
PR-URL: nodejs#9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@iarna@MylesBorins
deps: upgrade npm to 3.10.10
284d3cc
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@hulbert

hulbert commented Dec 15, 2016

Copy link
Copy Markdown

Apologies if this is an inappropriate place to ask but any sense of when a 6.x.x release will go out with this? It is the single thing blocking us from switching to node 6.

Funnily enough we've had a branch w/ node 6 passing CI and then it broke as soon as we tried the 6.9.x LTS releases because of this.

@MylesBorins

MylesBorins commented Dec 15, 2016

Copy link
Copy Markdown
Contributor

@hulbert this is is staging. Expect an RC next week and a release in 3

MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@iarna@MylesBorins
deps: upgrade npm to 3.10.10
3c5966f
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 21, 2016
Merged
MylesBorins added a commit that referenced this pull request Jan 3, 2017
@MylesBorins
2017-01-03, Version 6.9.3 'Boron' (LTS) Release
42149d7
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) #9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) #9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) #8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) #10103
- improved support for generator functions (Teddy Katz)
#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) #9685
PR-URL: #10394
MylesBorins added a commit that referenced this pull request Jan 3, 2017
@MylesBorins
2017-01-03, Version 6.9.3 'Boron' (LTS) Release
2bf1c24
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) #9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) #9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) #8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) #10103
- improved support for generator functions (Teddy Katz)
#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) #9685
PR-URL: #10394
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
@imyller
2017-01-03, Version 6.9.3 'Boron' (LTS) Release
96fa035
 This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) nodejs/node#9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
nodejs/node#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
nodejs/node#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) nodejs/node#9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) nodejs/node#8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
nodejs/node#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) nodejs/node#10103
- improved support for generator functions (Teddy Katz)
nodejs/node#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) nodejs/node#9685
PR-URL: nodejs/node#10394
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
@imyller
2017-01-03, Version 6.9.3 'Boron' (LTS) Release
0a82bea
 This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) nodejs/node#9675
* deps:
- *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
nodejs/node#9847
- *V8*: Destructuring of arrow function arguments via computed
property no longer throws (Michaël Zasso)
nodejs/node#10386)
* inspector:
- /json/version returns object, not an object wrapped in an array
(Ben Noordhuis) nodejs/node#9762
* module:
- using --debug-brk and --eval together now works as expected
(Kelvin Jin) nodejs/node#8876
* process:
- improve performance of nextTick up to 20% (Evan Lucas)
nodejs/node#8932
* repl:
- the division operator will no longer be accidentally parsed as
regex (Teddy Katz) nodejs/node#10103
- improved support for generator functions (Teddy Katz)
nodejs/node#9852
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) nodejs/node#9685
PR-URL: nodejs/node#10394
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@wraithgar
wraithgar deleted the npm-3.10.10 branch June 26, 2025 15:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iarna@Fishrock123@MylesBorins@jasnell@hulbert@nodejs-github-bot