Uh oh!
There was an error while loading. Please reload this page.
Test: update vm tests - #9875
Closed
makenova wants to merge 1 commit into
Closed
Conversation
change var to const or let change assert.equal to assert.strictEqual
cjihrig
approved these changes
Dec 1, 2016
imyller
commented
Dec 1, 2016
Member
lpinca
approved these changes
Dec 2, 2016
targos
approved these changes
Dec 3, 2016
targos pushed a commit
that referenced
this pull request
Dec 3, 2016
change var to const or let change assert.equal to assert.strictEqual PR-URL: #9875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
commented
Dec 3, 2016
Member
addaleax pushed a commit
that referenced
this pull request
Dec 5, 2016
change var to const or let change assert.equal to assert.strictEqual PR-URL: #9875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
change var to const or let change assert.equal to assert.strictEqual PR-URL: nodejs#9875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
jmdarling pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
change var to const or let change assert.equal to assert.strictEqual PR-URL: nodejs#9875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
change var to const or let change assert.equal to assert.strictEqual PR-URL: #9875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tests
Description of change
change
vartoconstorletchange
assert.equaltoassert.strictEqual