Uh oh!
There was an error while loading. Please reload this page.
test: edited assertion and timeout for test - #9889
Closed
danielgsims wants to merge 2 commits into
Closed
Conversation
In this change, the setTimeout needed a second argument, so I set that value to 0. In addition, I changed the assertion to be a strictEquals instead of equals.
danielgsims
commented
Dec 1, 2016
Author
This was from the Code & Learn at NINA. |
cjihrig
reviewed
Dec 1, 2016
| }); | ||
| }); | ||
| }); | ||
| }, 0); |
Contributor
There was a problem hiding this comment.
I assume this should be a timer for the purposes of this test, even though it is effectively a setImmediate().
Contributor
There was a problem hiding this comment.
It should probably also be a duration of 1. Duration of 0 gets changed to 1 internally anyways.
cjihrig
approved these changes
Dec 1, 2016
Trott
commented
Dec 1, 2016
Member
Trott
commented
Dec 5, 2016
Member
@lpinca IAre you sure about the |
lpinca
commented
Dec 5, 2016
Member
@Trott no, I'm not honestly not sure. Happy to keep |
I changed the var declarations to const in this unit test
danielgsims
commented
Dec 6, 2016
Author
Changed var declarations. Let me know if there's anything else. |
lpinca
approved these changes
Dec 6, 2016
lpinca
commented
Dec 6, 2016
Member
@danielgsims Thanks! |
jasnell
commented
Dec 7, 2016
Member
Trott
commented
Dec 7, 2016
Member
Landing. While landing, I'll change the |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 7, 2016
In this change, the setTimeout needed a second argument, so I set that value to 1. In addition, I changed the assertion to be a strictEquals instead of equals. I changed the var declarations to const in this test. PR-URL: nodejs#9889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Dec 7, 2016
Member
Landed in b0c10a2. |
addaleax pushed a commit
that referenced
this pull request
Dec 8, 2016
In this change, the setTimeout needed a second argument, so I set that value to 1. In addition, I changed the assertion to be a strictEquals instead of equals. I changed the var declarations to const in this test. PR-URL: #9889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
In this change, the setTimeout needed a second argument, so I set that value to 1. In addition, I changed the assertion to be a strictEquals instead of equals. I changed the var declarations to const in this test. PR-URL: nodejs#9889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Dec 20, 2016
In this change, the setTimeout needed a second argument, so I set that value to 1. In addition, I changed the assertion to be a strictEquals instead of equals. I changed the var declarations to const in this test. PR-URL: #9889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
In this change, the setTimeout needed a second argument, so I set that value to 1. In addition, I changed the assertion to be a strictEquals instead of equals. I changed the var declarations to const in this test. PR-URL: #9889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
In this change, the setTimeout needed a second argument, so I set that value to 1. In addition, I changed the assertion to be a strictEquals instead of equals. I changed the var declarations to const in this test. PR-URL: #9889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
In this change, the setTimeout needed a second argument, so I set that
value to 0. In addition, I changed the assertion to be a strictEquals
instead of equals.