Uh oh!
There was an error while loading. Please reload this page.
test: Update to const and use regex for assertions - #9891
Closed
Intregrisist wants to merge 1 commit into
Closed
Conversation
Trott
commented
Dec 1, 2016
Member
cjihrig
approved these changes
Dec 3, 2016
lpinca
reviewed
Dec 3, 2016
Member
There was a problem hiding this comment.
Nit: can you please add a leading ^ and a trailing $ to these regexes?
lpinca
approved these changes
Dec 3, 2016
Intregrisist
commented
Dec 3, 2016
ContributorAuthor
I can update. |
ContributorAuthor
@lpinca please review 6cc35ac. Commit squashed to a single commit. |
Intregrisistforce-pushed
the
test-update
branch
from
December 3, 2016 17:20
6cc35ac to
5cae0c3Comparelpinca
reviewed
Dec 3, 2016
Member
There was a problem hiding this comment.
@Intregrisist you probably also have to add the TypeError part or it will fail:
/^TypeError:"localPort"optionshouldbeanumber:foobar$/ContributorAuthor
There was a problem hiding this comment.
Please CR: 98309e6 Tests are passing on my local. Sorry I missed it.
Use const over var. Assert error message with regex.
Intregrisistforce-pushed
the
test-update
branch
from
December 3, 2016 17:29
98309e6 to
f2cd619Comparelpinca
commented
Dec 3, 2016
Member
jasnell
approved these changes
Dec 4, 2016
jasnell
left a comment
Member
There was a problem hiding this comment.
LGTM! thank you for the PR and for participating in the code-and-learn!
jasnell pushed a commit
that referenced
this pull request
Dec 4, 2016
Use const over var. Assert error message with regex. PR-URL: #9891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Dec 4, 2016
Member
Landed in 4a204ee. thank you! |
addaleax pushed a commit
that referenced
this pull request
Dec 5, 2016
Use const over var. Assert error message with regex. PR-URL: #9891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Use const over var. Assert error message with regex. PR-URL: nodejs#9891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Use const over var. Assert error message with regex. PR-URL: nodejs#9891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 20, 2016
Use const over var. Assert error message with regex. PR-URL: #9891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
Use const over var. Assert error message with regex. PR-URL: #9891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
Use const over var. Assert error message with regex. PR-URL: #9891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Use const over var.
Assert error message with regex.
Warning
This PR changes Error message expectation and manipulating test to pass. Please be advised.