Uh oh!
There was an error while loading. Please reload this page.
test: update test to use common.fail - #9900
Closed
jaybrownlee wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
Dec 1, 2016
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but the commit message is only partially accurate.
jaybrownlee
commented
Dec 1, 2016
Author
What could i add to the commit message to make it more accurate? |
cjihrig
commented
Dec 1, 2016
Contributor
Most of the body is fine. It's just the first line. Maybe just |
imyller
commented
Dec 1, 2016
Member
@jaybrownlee You should format the commit message as described in CONTRIBUTING guidelines. |
use common.fail instead of assert(false) change var to let or const as appropriate
jaybrownleeforce-pushed
the
update-test-vm-syntax-error-stderr
branch
from
December 1, 2016 16:34
79bb484 to
8dc87b6Comparejaybrownlee
commented
Dec 1, 2016
Author
commit message updated as suggested |
imyller
commented
Dec 1, 2016
Member
@jaybrownlee Thank you. Looks good 👍 |
gibfahn
commented
Dec 2, 2016
Member
lpinca
approved these changes
Dec 3, 2016
jasnell
approved these changes
Dec 5, 2016
jasnell pushed a commit
that referenced
this pull request
Dec 5, 2016
use common.fail instead of assert(false) change var to let or const as appropriate PR-URL: #9900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Dec 5, 2016
Member
Landed in fa22854. Thank you for the PR and for participating in the code-and-learn! |
Fishrock123 pushed a commit
that referenced
this pull request
Dec 5, 2016
use common.fail instead of assert(false) change var to let or const as appropriate PR-URL: #9900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
use common.fail instead of assert(false) change var to let or const as appropriate PR-URL: nodejs#9900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
use common.fail instead of assert(false) change var to let or const as appropriate PR-URL: nodejs#9900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 20, 2016
use common.fail instead of assert(false) change var to let or const as appropriate PR-URL: #9900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
use common.fail instead of assert(false) change var to let or const as appropriate PR-URL: #9900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
use common.fail instead of assert(false) change var to let or const as appropriate PR-URL: #9900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
use common.fail instead of assert(false)
also changes var to let & const as appropriate