Skip to content

Use const in test-require-json.js - #9904

Closed
sarahmeyer wants to merge 2 commits into
nodejs:masterfrom
sarahmeyer:test-require-json-use-const
Closed

Use const in test-require-json.js#9904
sarahmeyer wants to merge 2 commits into
nodejs:masterfrom
sarahmeyer:test-require-json-use-const

Conversation

@sarahmeyer

@sarahmeyersarahmeyer commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Use modern syntax for variable declaration in test-require-json.js

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdexmscdex added the module Issues and PRs related to the module subsystem. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
MylesBorins
MylesBorins approved these changes Dec 1, 2016
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented Dec 3, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5139/

jasnell pushed a commit that referenced this pull request Dec 5, 2016
@sarahmeyer@jasnell
test: use const instead of var in test-require-json.js
f51c02f
PR-URL: #9904
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Dec 5, 2016

Copy link
Copy Markdown
Member

Landed in f51c02f. Thank you for the PR and for participating in the code-and-learn! :-)

@jasnelljasnell closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@sarahmeyer@Fishrock123
test: use const instead of var in test-require-json.js
f62567b
PR-URL: #9904
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@sarahmeyer@addaleax
test: use const instead of var in test-require-json.js
e9d4665
PR-URL: nodejs#9904
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@sarahmeyerJonathan Darling
test: use const instead of var in test-require-json.js
59f69fd
PR-URL: nodejs#9904
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@sarahmeyer@MylesBorins
test: use const instead of var in test-require-json.js
dc06e7a
PR-URL: #9904
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.moduleIssues and PRs related to the module subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@sarahmeyer@Trott@jasnell@MylesBorins@addaleax@lpinca@cjihrig@mscdex@imyller@nodejs-github-bot