Skip to content

test: Updated tls-getcipher test - #9923

Closed
Ethan-Arrowood wants to merge 2 commits into
nodejs:masterfrom
Ethan-Arrowood:my-branch
Closed

test: Updated tls-getcipher test#9923
Ethan-Arrowood wants to merge 2 commits into
nodejs:masterfrom
Ethan-Arrowood:my-branch

Conversation

@Ethan-Arrowood

@Ethan-ArrowoodEthan-Arrowood commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Description of change

Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions called exactly once.
Changed assert.equal to assert.strictEqual.

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdexmscdex added the tls Issues and PRs related to the tls subsystem. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@Ethan-Arrowood
test: updated tls-getcipher test
63bcc6a
Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.
@Trott

Trott commented Dec 1, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5094/

@Ethan-Arrowood

Ethan-Arrowood commented Dec 2, 2016

Copy link
Copy Markdown
ContributorAuthor

What went wrong here? Why did it fail on the arm-fanned and windows-fanned tests? How I can I fix my code so it works on those?

@Trott

Trott commented Dec 2, 2016

Copy link
Copy Markdown
Member

@Ethan-Arrowood Someone must have gotten alarmed at the number of CI jobs I started yesterday (due to Code & Learn) and thought they were all stalled jobs. So yours (and many others) were terminated.

No problem, though! I'll just run yours again. CI: https://ci.nodejs.org/job/node-test-pull-request/5106/

@Ethan-Arrowood

Ethan-Arrowood commented Dec 2, 2016 via email

Copy link
Copy Markdown
ContributorAuthor

cjihrig
cjihrig requested changes Dec 2, 2016
View reviewed changes
Comment threadtest/parallel/test-tls-getcipher.js Outdated

var server = tls.createServer(options,
const server = tls.createServer(options,
common.mustCall(function(cleartextStream) {}));

@cjihrigcjihrigDec 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be lined up now.

@Ethan-ArrowoodEthan-ArrowoodDec 2, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by lined up? Sorry, still new to this!

@TrottTrottDec 2, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ethan-Arrowood The argument (common.mustCall...)on line 22 should line up with the argument on line 21 (options). So line 22 needs to be indented two more spaces. I'm surprised this isn't caught by the linter.

@Ethan-ArrowoodEthan-ArrowoodDec 3, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I went ahead and fixed that issue and made another commit

@Ethan-Arrowood
test: updated tls-getcipher indentation
2366e67
Very simple fix to indentation issue on line 22.
@Ethan-Arrowood

Ethan-Arrowood commented Dec 4, 2016

Copy link
Copy Markdown
ContributorAuthor

Silly question, but when does my approved PR's get closed? Will it be done automatically or is there something I need to do?

@cjihrig

cjihrig commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

It should only need a new CI run, and then someone with commit access will land it.

New CI: https://ci.nodejs.org/job/node-test-pull-request/5184/

@Trott

Trott commented Dec 5, 2016

Copy link
Copy Markdown
Member

CI was fine except that Windows stalled (on the CI side, nothing to do with this change). Re-running just Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/5657/

lpinca
lpinca reviewed Dec 5, 2016
View reviewed changes
Comment threadtest/parallel/test-tls-getcipher.js
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

@lpincalpincaDec 5, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please move this require after the hasCrypto check?

jasnell pushed a commit that referenced this pull request Dec 5, 2016
@Ethan-Arrowood@jasnell
test: updated tls-getcipher test
be1f52b
Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.
PR-URL: #9923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Dec 5, 2016

Copy link
Copy Markdown
Member

Landed in be1f52b. Thank you for the PR and for participating in the code-and-learn!
I addressed @lpinca's request to move the require when landing.

@jasnelljasnell closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@Ethan-Arrowood@Fishrock123
test: updated tls-getcipher test
64b2494
Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.
PR-URL: #9923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@Ethan-Arrowood@addaleax
test: updated tls-getcipher test
47c925a
Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.
PR-URL: nodejs#9923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@Ethan-ArrowoodJonathan Darling
test: updated tls-getcipher test
d5b0a95
Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.
PR-URL: nodejs#9923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Ethan-Arrowood@MylesBorins
test: updated tls-getcipher test
46f2584
Changed var to ES6 syntax const/let.
Added common.mustCall function wrapper to all functions
called exactly once.
Changed assert.equal to assert.strictEqual.
PR-URL: #9923
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Ethan-Arrowood@Trott@cjihrig@jasnell@lpinca@mscdex@MylesBorins@addaleax@imyller@nodejs-github-bot