Skip to content

test: Change equal to strictEqual and pass delay to setTimeout - #9938

Closed
qualquervalor2 wants to merge 3 commits into
nodejs:masterfrom
qualquervalor2:tweakDomainExitTest
Closed

test: Change equal to strictEqual and pass delay to setTimeout#9938
qualquervalor2 wants to merge 3 commits into
nodejs:masterfrom
qualquervalor2:tweakDomainExitTest

Conversation

@qualquervalor2

@qualquervalor2qualquervalor2 commented Dec 1, 2016•
edited by Fishrock123
Loading

Copy link
Copy Markdown
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • Changed assert.equal to assert.strictEqual
  • Passed a delay value to setTimeout

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdexmscdex added the domain Issues and PRs related to the domain subsystem. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
Fishrock123
Fishrock123 suggested changes Dec 2, 2016
View reviewed changes
Comment threadtest/parallel/test-domain-exit-dispose.js Outdated
disposalFailed = true;
process.exit(1);
});
}, 0);

@Fishrock123Fishrock123Dec 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qualquervalor2 Could you check if this works with setImmediate() instead of setTimeout()?

If it doesn't work, could you change the 0 to a 1? The 0 becomes a 1 under the hood so it would be better to be explicit up front. :)

@qualquervalor2qualquervalor2Dec 2, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setImediate() did not work. Updated the PR to use 1.

jasnell
jasnell reviewed Dec 5, 2016
View reviewed changes
Comment threadtest/parallel/test-domain-exit-dispose.js Outdated
disposalFailed = true;
process.exit(1);
});
}, 1);

@jasnelljasnellDec 5, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can likely be changed to use common.mustCall() ... for instance:

setTimeout(common.mustCall(()=>{},0),1);

mhdawson
mhdawson approved these changes Dec 6, 2016
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Dec 6, 2016

Copy link
Copy Markdown
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/5270/

@jasnell

jasnell commented Dec 7, 2016

Copy link
Copy Markdown
Member

@Fishrock123 ... are you good with this now?

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 7, 2016
Chris Henney@Trott
test: refactor test-domain-exit-dispose
25dfb8e
change equal to strictEqual, fix setTimeout
PR-URL: nodejs#9938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott

Trott commented Dec 7, 2016

Copy link
Copy Markdown
Member

Landed in 25dfb8e

@TrottTrott closed this Dec 7, 2016
@Trott

Trott commented Dec 7, 2016

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

addaleax pushed a commit that referenced this pull request Dec 8, 2016
Chris Henney@addaleax
test: refactor test-domain-exit-dispose
de99726
change equal to strictEqual, fix setTimeout
PR-URL: #9938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Chris Henney@addaleax
test: refactor test-domain-exit-dispose
5d9c224
change equal to strictEqual, fix setTimeout
PR-URL: nodejs#9938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@italoacasasitaloacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Chris Henney@MylesBorins
test: refactor test-domain-exit-dispose
a64f406
change equal to strictEqual, fix setTimeout
PR-URL: #9938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Chris Henney@MylesBorins
test: refactor test-domain-exit-dispose
e539db8
change equal to strictEqual, fix setTimeout
PR-URL: #9938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Chris Henney@MylesBorins
test: refactor test-domain-exit-dispose
fed9a9e
change equal to strictEqual, fix setTimeout
PR-URL: #9938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
+2 more reviewers
@Fishrock123Fishrock123Fishrock123 approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.domainIssues and PRs related to the domain subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@qualquervalor2@mhdawson@jasnell@Trott@Fishrock123@lpinca@mscdex@MylesBorins@addaleax@imyller@nodejs-github-bot