Uh oh!
There was an error while loading. Please reload this page.
test: clean up tls junk test - #9940
Closed
dguo wants to merge 1 commit into
Closed
Conversation
imyller
commented
Dec 1, 2016
Member
@dguo Can you please remove modifications made to |
dguoforce-pushed
the
test-tls-junk-cleanup
branch
from
December 1, 2016 16:47
3b660f0 to
6999a3fCompareContributorAuthor
Done. Sorry about that. Would it make sense to open a separate PR for adding |
imyller
commented
Dec 1, 2016
Member
@dguo As a Mac user myself, I think it would make sense to have /cc @nodejs/platform-macos |
jasnell
approved these changes
Dec 5, 2016
Trott
commented
Dec 6, 2016
Member
jasnell pushed a commit
that referenced
this pull request
Dec 6, 2016
PR-URL: #9940 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Dec 6, 2016
Member
Landed in 244dd5b. Thank you for the PR and for participating in the code-and-learn! |
Fishrock123 pushed a commit
that referenced
this pull request
Dec 6, 2016
PR-URL: #9940 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9940 Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9940 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #9940 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9940 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9940 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
vartoconstcommon.mustCallandcommon.fail