Skip to content

Test console fix assert equals - #9942

Closed
mcrummey wants to merge 4 commits into
nodejs:masterfrom
mcrummey:testConsoleFixAssertEquals
Closed

Test console fix assert equals#9942
mcrummey wants to merge 4 commits into
nodejs:masterfrom
mcrummey:testConsoleFixAssertEquals

Conversation

@mcrummey

@mcrummeymcrummey commented Dec 1, 2016

Copy link
Copy Markdown
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
Affected core subsystem(s)

test

Description of change

using strictEquals instead of equals.

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdexmscdex added the console Issues and PRs related to the console subsystem. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mcrummeymcrummey closed this Dec 2, 2016
@mcrummey
mcrummey deleted the testConsoleFixAssertEquals branch December 2, 2016 20:27
@mcrummey

Copy link
Copy Markdown
Author

Closed this PR because I merged the changes into PR #9873. Accidentally created two PRs when there should have been one.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.consoleIssues and PRs related to the console subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mcrummey@mscdex@imyller@nodejs-github-bot