Skip to content

using strictEquals instead of equals - #9873

Closed
mcrummey wants to merge 1 commit into
nodejs:masterfrom
mcrummey:test-console-make-strict-equal
Closed

using strictEquals instead of equals#9873
mcrummey wants to merge 1 commit into
nodejs:masterfrom
mcrummey:test-console-make-strict-equal

Conversation

@mcrummey

@mcrummeymcrummey commented Dec 1, 2016•
edited
Loading

Copy link
Copy Markdown
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Update console test to use assert.strictEquals instead of assert.equals

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller

imyller commented Dec 1, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5041/

@imyller

imyller commented Dec 1, 2016

Copy link
Copy Markdown
Member

@mcrummey May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

@mscdexmscdex added the console Issues and PRs related to the console subsystem. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mcrummeymcrummey closed this Dec 1, 2016
@gibfahn

gibfahn commented Dec 2, 2016

Copy link
Copy Markdown
Member

@mcrummey Did you mean to close this PR? If you update your local branch, it will automatically update the PR.

If you're having trouble with git, let us know and someone can walk you through it.

@mcrummeymcrummey reopened this Dec 2, 2016
@mcrummeymcrummey mentioned this pull request Dec 2, 2016
Closed
2 tasks
jasnell
jasnell approved these changes Dec 4, 2016
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the PR and for participating in the code-and-learn!

@jasnell

jasnell commented Dec 4, 2016

Copy link
Copy Markdown
Member

@mcrummey ... can I ask you to please squash the commits in this PR down to a single commit? If you are not familiar with how to do so, please see: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Once done, you can update this PR simply by force pushing back to your branch.

We will be able to get this landed once those are squashed. Thank you!

@mcrummey
mcrummeyforce-pushed the test-console-make-strict-equal branch from 3f1239f to d561a0aCompareDecember 5, 2016 02:22
@Trott

Trott commented Dec 5, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5191/

@Trott

Trott commented Dec 5, 2016

Copy link
Copy Markdown
Member

FIPS test failure is unrelated. At this time, still waiting on Raspberry Pi and Windows tests to finish. Looking good so far, though.

@Trott

Trott commented Dec 5, 2016

Copy link
Copy Markdown
Member

The one (and hopefully only) Raspberry PI build failure is also unrelated.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2016
Matt Crummey@Trott
test: refactor test-console
073aa2c
assert.equal() -> assert.strictEqual()
PR-URL: nodejs#9873
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Dec 5, 2016

Copy link
Copy Markdown
Member

Landed in 073aa2c.
Thanks for the contribution! 🎉

@TrottTrott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
Matt Crummey@Fishrock123
test: refactor test-console
a801ffb
assert.equal() -> assert.strictEqual()
PR-URL: #9873
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Matt Crummey@addaleax
test: refactor test-console
26d61c3
assert.equal() -> assert.strictEqual()
PR-URL: nodejs#9873
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Matt CrummeyJonathan Darling
test: refactor test-console
b1553a2
assert.equal() -> assert.strictEqual()
PR-URL: nodejs#9873
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Matt Crummey@MylesBorins
test: refactor test-console
e30df80
assert.equal() -> assert.strictEqual()
PR-URL: #9873
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.consoleIssues and PRs related to the console subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@mcrummey@imyller@gibfahn@jasnell@Trott@cjihrig@mscdex@MylesBorins@addaleax@nodejs-github-bot