Skip to content

change assert.equal to assert.strictEqual - #9946

Closed
aileenvl wants to merge 3 commits into
nodejs:masterfrom
aileenvl:typo-test-cluster-send-handle_Aileen
Closed

change assert.equal to assert.strictEqual #9946
aileenvl wants to merge 3 commits into
nodejs:masterfrom
aileenvl:typo-test-cluster-send-handle_Aileen

Conversation

@aileenvl

@aileenvlaileenvl commented Dec 1, 2016•
edited
Loading

Copy link
Copy Markdown
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

make a change from assert.equal() to asser.strictEqual()

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdexmscdex added cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Dec 1, 2016
@mscdex

mscdex commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

Please follow the commit message guidelines here.

@aileenvlaileenvl changed the title Change assert.equal to assert.strictEqualtest: change assert.equal to assert.strictEqualDec 1, 2016
@aileenvlaileenvl changed the title test: change assert.equal to assert.strictEqualtest: change assert.equal to assert.strictEqual Change test from assert.equal() to assert.strictEqual() Dec 1, 2016
@aileenvlaileenvl changed the title test: change assert.equal to assert.strictEqual Change test from assert.equal() to assert.strictEqual() change assert.equal to assert.strictEqual Dec 1, 2016
Aileen added 2 commits December 1, 2016 11:09
Aileen
test:change assert.equal() to assert.strictEqual()
d5be696
this commit makes a change on test file from an asset.equal() to assert.strictEqual()
Aileen
Merge branch 'typo-test-cluster-send-handle_Aileen' ofhttps://github…
5d324db
….com/aileenvl/node into typo-test-cluster-send-handle_Aileen
change commit message to follow guidelines
jasnell
jasnell approved these changes Dec 5, 2016
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits will need to be squashed but LGTM

@addaleax

addaleax commented Dec 8, 2016

Copy link
Copy Markdown
Member

Landed in 558fa1c, thanks for the contribution!

@addaleaxaddaleax closed this Dec 8, 2016
addaleax pushed a commit that referenced this pull request Dec 8, 2016
Aileen@addaleax
test: change assert.equal to assert.strictEqual
558fa1c
PR-URL: #9946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Dec 8, 2016
Aileen@addaleax
test: change assert.equal to assert.strictEqual
72fb05d
PR-URL: #9946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Aileen@addaleax
test: change assert.equal to assert.strictEqual
653f2b7
PR-URL: nodejs#9946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@italoacasasitaloacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Aileen@MylesBorins
test: change assert.equal to assert.strictEqual
bc125bd
PR-URL: #9946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Aileen@MylesBorins
test: change assert.equal to assert.strictEqual
29dd2b8
PR-URL: #9946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Aileen@MylesBorins
test: change assert.equal to assert.strictEqual
0b148b9
PR-URL: #9946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

clusterIssues and PRs related to the cluster subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aileenvl@mscdex@addaleax@jasnell@MylesBorins@imyller@nodejs-github-bot