Skip to content

Updated test-crypto-ecb.js to change assert.equal to assert.strictEqual - #9980

Closed
daniel-pittman wants to merge 1 commit into
nodejs:masterfrom
daniel-pittman:additional_test_updates
Closed

Updated test-crypto-ecb.js to change assert.equal to assert.strictEqual#9980
daniel-pittman wants to merge 1 commit into
nodejs:masterfrom
daniel-pittman:additional_test_updates

Conversation

@daniel-pittman

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Description of change

Updated test-crypto-ecb.js to change assert.equal to assert.strictEqual

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdexmscdex added the crypto Issues and PRs related to the crypto subsystem. label Dec 1, 2016
@mscdex

Copy link
Copy Markdown
Contributor

Please see the commit message guidelines here.

@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual
@daniel-pittman

Copy link
Copy Markdown
ContributorAuthor

Git commit message updated.

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM if CI is ✅

@Trott

Trott commented Dec 4, 2016

Copy link
Copy Markdown
Member

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.
PR-URL: nodejs#9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Dec 4, 2016

Copy link
Copy Markdown
Member

Landed in 99a3b63. Thanks for the contribution! 🎉

@TrottTrott closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.
PR-URL: #9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.
PR-URL: nodejs#9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.
PR-URL: nodejs#9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.
PR-URL: #9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.
PR-URL: #9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.
PR-URL: #9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Dec 21, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.cryptoIssues and PRs related to the crypto subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@daniel-pittman@mscdex@Trott@MylesBorins@addaleax@imyller@nodejs-github-bot