Skip to content

test:changed equal to strictEqual in test-child-fork-exec-path.js - #9982

Closed
hirabhullar wants to merge 2 commits into
nodejs:masterfrom
hirabhullar:my-branch
Closed

test:changed equal to strictEqual in test-child-fork-exec-path.js#9982
hirabhullar wants to merge 2 commits into
nodejs:masterfrom
hirabhullar:my-branch

Conversation

@hirabhullar

@hirabhullarhirabhullar commented Dec 1, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdexmscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@mscdex

mscdex commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

Please see the commit message guidelines here.

@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@hirabhullar
test: refactor test-child-fork-exec-path.js
df2fe33
Changed equal to strictEqual
@hirabhullar
test: refactor test-fs-write.js
94e8940
Changed var to const and equal to strictEqual
@hirabhullar

hirabhullar commented Dec 1, 2016

Copy link
Copy Markdown
ContributorAuthor

Comments updated

cjihrig
cjihrig approved these changes Dec 3, 2016
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The commits will need to be squashed prior to landing.

@Trott

Trott commented Dec 6, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5239/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2016
@hirabhullar@Trott
test: refactor test-child-fork-exec-path.js
108314b
Changed equal to strictEqual
PR-URL: nodejs#9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2016
@hirabhullar@Trott
test: refactor test-fs-write.js
7a23c0a
Changed var to const and equal to strictEqual
PR-URL: nodejs#9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Dec 6, 2016

Copy link
Copy Markdown
Member

Landed in 108314b and 7a23c0a.

Since these appear to be separate and unrelated changes, I didn't squash the two commits.

Thanks for the contribution! 🎉

@TrottTrott closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@hirabhullar@Fishrock123
test: refactor test-child-fork-exec-path.js
2f731e5
Changed equal to strictEqual
PR-URL: #9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@hirabhullar@Fishrock123
test: refactor test-fs-write.js
8936d83
Changed var to const and equal to strictEqual
PR-URL: #9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@hirabhullar@addaleax
test: refactor test-child-fork-exec-path.js
c506b7b
Changed equal to strictEqual
PR-URL: nodejs#9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@hirabhullar@addaleax
test: refactor test-fs-write.js
b893dc9
Changed var to const and equal to strictEqual
PR-URL: nodejs#9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@hirabhullarJonathan Darling
test: refactor test-child-fork-exec-path.js
460b4e1
Changed equal to strictEqual
PR-URL: nodejs#9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@hirabhullarJonathan Darling
test: refactor test-fs-write.js
ec0cc9b
Changed var to const and equal to strictEqual
PR-URL: nodejs#9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@hirabhullar@MylesBorins
test: refactor test-child-fork-exec-path.js
9c7bf1f
Changed equal to strictEqual
PR-URL: #9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@hirabhullar@MylesBorins
test: refactor test-fs-write.js
c5a75f0
Changed var to const and equal to strictEqual
PR-URL: #9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@hirabhullar@mscdex@Trott@jasnell@cjihrig@MylesBorins@addaleax@imyller@nodejs-github-bot