Skip to content

Change var to const or let in test-child-process-ipc.js - #9990

Closed
malenesok007 wants to merge 1 commit into
nodejs:masterfrom
malenesok007:myChanges
Closed

Change var to const or let in test-child-process-ipc.js#9990
malenesok007 wants to merge 1 commit into
nodejs:masterfrom
malenesok007:myChanges

Conversation

@malenesok007

@malenesok007malenesok007 commented Dec 1, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@imyller

imyller commented Dec 1, 2016

Copy link
Copy Markdown
Member

@malenesok007 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

@mscdexmscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@malenesok007

malenesok007 commented Dec 1, 2016

Copy link
Copy Markdown
ContributorAuthor

Hi I have modify the commit message. Is there something I am missing? Thanks.

cjihrig
cjihrig approved these changes Dec 5, 2016
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI.

@Trott

Trott commented Dec 8, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5326/

silverwind
silverwind suggested changes Dec 9, 2016
View reviewed changes
Comment threadtest/parallel/test-child-process-ipc.js Outdated

@silverwindsilverwindDec 9, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter error here:

 error 'child' is never reassigned. Use 'const' instead prefer-const

@Trott

Trott commented Dec 22, 2016

Copy link
Copy Markdown
Member

Ping @malenesok007: Can you change the let to const as identified in the comment from @silverwind? You can run make jslint (or, if on Windows, vcbuild jslint nosign I think) to check for other lint errors before pushing.

@Trott

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

Because it was a straightforward lint fix, I made the change and pushed it to @malenesok007's branch.

@silverwind Can you take a look and, if appropriate, update your review? Thanks!

@Trott

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5568/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 24, 2016
@malenesok007@Trott
test: refactor test-child-process-ipc
ff88a5a
Change var to const or let.
Change assert.equal() to assert.strictEqual().
PR-URL: nodejs#9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@Trott

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

Landed in ff88a5a.
Thanks for the contribution! 🎉

@TrottTrott closed this Dec 24, 2016
targos pushed a commit that referenced this pull request Dec 26, 2016
@malenesok007@targos
test: refactor test-child-process-ipc
610ec55
Change var to const or let.
Change assert.equal() to assert.strictEqual().
PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorinsMylesBorins mentioned this pull request Dec 27, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
@malenesok007@targos
test: refactor test-child-process-ipc
16460e9
Change var to const or let.
Change assert.equal() to assert.strictEqual().
PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@evanlucasevanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@malenesok007@evanlucas
test: refactor test-child-process-ipc
c2b525a
Change var to const or let.
Change assert.equal() to assert.strictEqual().
PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@malenesok007@evanlucas
test: refactor test-child-process-ipc
599a2a9
Change var to const or let.
Change assert.equal() to assert.strictEqual().
PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@malenesok007@MylesBorins
test: refactor test-child-process-ipc
c074982
Change var to const or let.
Change assert.equal() to assert.strictEqual().
PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@malenesok007@MylesBorins
test: refactor test-child-process-ipc
3ffd4d6
Change var to const or let.
Change assert.equal() to assert.strictEqual().
PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@malenesok007@MylesBorins
test: refactor test-child-process-ipc
4efdbaf
Change var to const or let.
Change assert.equal() to assert.strictEqual().
PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@silverwindsilverwindsilverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@malenesok007@imyller@Trott@silverwind@jasnell@cjihrig@mscdex@targos@nodejs-github-bot