Skip to content

Add Release Schedule - #1890

Merged
fhemberger merged 6 commits into
masterfrom
feature/lts-release-plan
Nov 11, 2018
Merged

Add Release Schedule#1890
fhemberger merged 6 commits into
masterfrom
feature/lts-release-plan

Conversation

@fhemberger

@fhembergerfhemberger commented Nov 7, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

@fhemberger
fhemberger requested a review from TrottNovember 7, 2018 08:19
@thom4parisotthom4parisot mentioned this pull request Nov 7, 2018
Closed
ZYSzys
ZYSzys approved these changes Nov 7, 2018
View reviewed changes

@ZYSzysZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But IMHO, I wonder if it's better to put this section into about/releases.md since this is release related ?

richardlau
richardlau reviewed Nov 7, 2018
View reviewed changes
Comment threadlayouts/about-release-schedule.hbs
@richardlau

richardlau commented Nov 7, 2018

Copy link
Copy Markdown
Member

cc @nodejs/release

@fhemberger

fhemberger commented Nov 7, 2018

Copy link
Copy Markdown
ContributorAuthor

@ZYSzys The "Release" page explains more what kind of changes land in version numbers. I'm currently not sure if we need this explanation anyway or if it can be replaced entirely by the release schedule.

Feedback is appreciated.

@ZYSzys

ZYSzys commented Nov 7, 2018•
edited
Loading

Copy link
Copy Markdown
Member

I didn't mean replacing the "Release" page with the release schedule, I'm saying can we just add a section called schedule into the "Release" page simply ?

@Trott

Trott commented Nov 7, 2018

Copy link
Copy Markdown
Member

I agree with @fhemberger's suspicion that https://nodejs.org/en/about/releases/ can be deleted entirely or replaced with the schedule here. Most of it is not very informative.

@fhemberger
fhembergerforce-pushed the feature/lts-release-plan branch from 69f65d0 to dc7fce8CompareNovember 8, 2018 16:15
@fhemberger

fhemberger commented Nov 8, 2018

Copy link
Copy Markdown
ContributorAuthor

Ok, replaced the old "Releases" page entirely with the release schedule. The information wasn't really helpful anyway. PTAL.

@fhemberger

fhemberger commented Nov 8, 2018

Copy link
Copy Markdown
ContributorAuthor

/cc @nodejs/nodejs-fa @nodejs/nodejs-ko @nodejs/nodejs-uk @nodejs/nodejs-cn

@ZYSzysZYSzys mentioned this pull request Nov 9, 2018
Merged
@taggontaggon mentioned this pull request Nov 9, 2018
Merged
vsemozhetbyt
vsemozhetbyt reviewed Nov 10, 2018
View reviewed changes
Comment threadlocale/uk/about/releases.md Outdated
ZYSzysand others added 4 commits November 11, 2018 10:05
@ZYSzysMaledong
zh-cn: add release schedule (#1892)
372be71
1. Add release schedule
2. Current => 当前版
3. Translate maintenance & active
MaleDong
zh-CN: Modify the Columns in Chinese
90ac746
Due to the actual table in
#1890, so we can make the
meanings more clear by adding "Date" in the Chinese meanings.
@taggon@fhemberger
Korean translation: add release schedule (#1894)
1040768
* Korean translation: add release schedule
* Fixed a misspelled word
@fhemberger
Add Ukrainian translation
07d5f53
@fhemberger
fhemberger merged commit 95a3bdd into masterNov 11, 2018
fhemberger pushed a commit that referenced this pull request Nov 11, 2018
MaleDong@fhemberger
zh-CN: Modify the Columns in Chinese
333c2d2
Due to the actual table in
#1890, so we can make the
meanings more clear by adding "Date" in the Chinese meanings.
@fhemberger

fhemberger commented Nov 11, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks everybody!

@fhemberger
fhemberger deleted the feature/lts-release-plan branch February 20, 2019 22:43
@richardlaurichardlau mentioned this pull request Nov 11, 2019
Closed
@snyk-botsnyk-bot mentioned this pull request Mar 12, 2020
Open
@dirgam92dirgam92 mentioned this pull request Mar 14, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Mar 21, 2023
Merged
@NOUIYNOUIY mentioned this pull request Apr 5, 2023
Open
@NOUIYNOUIY mentioned this pull request Apr 14, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Apr 28, 2023
Open
@NOUIYNOUIY mentioned this pull request May 4, 2023
Open
@snyk-botsnyk-bot mentioned this pull request May 18, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Jun 1, 2023
Open
@jydmykjydmyk mentioned this pull request Jun 5, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments
@TrottTrottTrott approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+2 more reviewers
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
@marswongmarswongmarswong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fhemberger@richardlau@ZYSzys@Trott@marswong@vsemozhetbyt@taggon