Skip to content

update schedule.json - #2757

Closed
ghost wants to merge 5 commits into
masterfrom
unknown repository
Closed

update schedule.json#2757
ghost wants to merge 5 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Nov 10, 2019

Copy link
Copy Markdown
  1. According to our plan in https://nodejs.org/en/about/releases/, we've now published the 13th version of Nodejs, add this to the schedule for the maintance.

  2. Add the missing coding name for v12.

@ghost
ghost self-requested a review November 10, 2019 06:29
@ghostghost changed the title add v13 to the schedule.jsonupdate schedule.jsonNov 10, 2019
1. According to our plan in https://nodejs.org/en/about/releases/, we've
now published the 13th version of Nodejs, add this to the schedule for
the maintance.
2. Add the missing coding name for v12.
@XhmikosR
XhmikosR requested a review from TrottNovember 10, 2019 14:49
@Trott

Trott commented Nov 10, 2019

Copy link
Copy Markdown
Member

Looks good to me but I never even noticed this file before (that I can remember anyway) so I'll leave the actual approving to others (which has already happened anyway).

@XhmikosR

This comment has been minimized.

@Trott

This comment has been minimized.

@XhmikosR

This comment has been minimized.

@nschonni

Copy link
Copy Markdown
Member

Should the build just curl this file from https://github.com/nodejs/Release/blob/master/schedule.json instead of keeping a separate copy?

@ghost

ghost commented Nov 11, 2019

Copy link
Copy Markdown
Author

@nschonni: Not sure yet, but according to your description, it seems this file here is duplicated?
@nodejs/release: It seems this file has been defined in the https://github.com/nodejs/Release/blob/master/schedule.json, so do we have to maintain this copy here? Just for a confirm.
If you think this file can be removed, I'll remove it.

@richardlau

Copy link
Copy Markdown
Member

I think the file in the repository is a placeholder that gets overridden during build by load-schedule (called by deploy):

"deploy": "npm-run-all load-schedule build:deploy external:survey gzip",
"load-versions": "node scripts/load-versions.js",
"load-schedule": "curl -sS https://raw.githubusercontent.com/nodejs/Release/master/schedule.json -o source/schedule.json",
(see #1890)

@XhmikosR

Copy link
Copy Markdown
Contributor

Can't we remove the folder and the file completely?

@ghost

ghost commented Nov 12, 2019

Copy link
Copy Markdown
Author

I think the file in the repository is a placeholder that gets overridden during build by load-schedule (called by deploy):

"deploy": "npm-run-all load-schedule build:deploy external:survey gzip",
"load-versions": "node scripts/load-versions.js",
"load-schedule": "curl -sS https://raw.githubusercontent.com/nodejs/Release/master/schedule.json -o source/schedule.json",

(see #1890)

So this file should be totally removed, or just run the script to update the file, just like what I submitted?

@XhmikosR

Copy link
Copy Markdown
Contributor

This patch is moot since this is overwritten on build time. We should instead see if we can just remove the folder and the file.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@XhmikosR@nschonni@richardlau@csabapalfi@osk2@aymen94